From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 848D9C71155 for ; Mon, 30 Nov 2020 17:27:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38D4E2076E for ; Mon, 30 Nov 2020 17:27:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kali.org header.i=@kali.org header.b="Kh3Kt8oE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728363AbgK3R0p (ORCPT ); Mon, 30 Nov 2020 12:26:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbgK3R0o (ORCPT ); Mon, 30 Nov 2020 12:26:44 -0500 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B114AC0617A7 for ; Mon, 30 Nov 2020 09:26:00 -0800 (PST) Received: by mail-oi1-x244.google.com with SMTP id c80so15006768oib.2 for ; Mon, 30 Nov 2020 09:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kali.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Ru7NLccMoPibYPRiKwpFm+Vj44WvO34VSPqaKP+92ak=; b=Kh3Kt8oEDlhs3pKFJGJqSbxdh3/n7jwMaX8Vdoy2d4Kkq7FjR4PhSmV/g00+P8RNm7 +VfgHkuYFsgjU1Gsq/WdWVSio15EzpL+3GQQ/tGGwtXKeVYa260+DildkHcYl6Gwtcci g1H9BSZZCS2wB0Ssi3onqx/C1kZwl1YVg63KzhEGhfCZ753gZMtfq+RMIVGw/lmUkuAw P6P8Aa3nBiyihnX/eRNo0JUwRh4PA53r5OHzmjc5Wnvm6IwDVLSAGCW3tWE7KLf5kSVf FbB+eQdU7R8Rcev7NrSaftTkvRiec89HJrUkhGDHM2jdDE+FPFJf5d1PpkbqHiEQ3LIH hBpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Ru7NLccMoPibYPRiKwpFm+Vj44WvO34VSPqaKP+92ak=; b=USUD8zYZ0cpz7uDi/uNCBH5+4wyI6GFrn/3dV7EudN01Liow4zLLFTKOChUAyTk3eF wvNgjO8PPSn6G9RdehTbFnhDRf+m2HzKJOuqkBC+llqP7Ml7lqK6Rv28NQpncQ0k9cJC FHHrOa5JAKqQf7jizBWdchqiSQNrLAAJ56FrxS68hIMP2pVIQpFyF/qITpjQ41ElatXp WQ6zQ/FAxjrISYNSO+I7QnKcJpd72nbz6ksAFpbtHlY/XsGZohXE0Gq+YU9OQ89JYkIi 0SQHiOM5RiNXv0wV1zuzjA4CvEa/xBvZut1wi3BtbYl9T+h50OSZJwBTr3RPOiD8uF65 MFWg== X-Gm-Message-State: AOAM533US1YP03CONzuDsiI5/UHQA6NYZBIbSkvUhnnw/MtZBrfEUQV5 W+gG64NSrEK4xNpNeY0kjkQup2QYg3TvIMFlSms= X-Google-Smtp-Source: ABdhPJyAMv3FHovUbayRLahomb+9JxRUxoLtpBroVudFxPP9U7QGw1edXqxkdwuZCCAsJ/En4ZHrdA== X-Received: by 2002:a05:6808:8c8:: with SMTP id k8mr15419478oij.84.1606757159932; Mon, 30 Nov 2020 09:25:59 -0800 (PST) Received: from Steevs-MBP.hackershack.net (cpe-173-175-113-3.satx.res.rr.com. [173.175.113.3]) by smtp.gmail.com with ESMTPSA id e15sm9319333otj.43.2020.11.30.09.25.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Nov 2020 09:25:59 -0800 (PST) Subject: Re: [PATCH] arm64: dts: qcom: c630: Fix pinctrl pins properties To: Bjorn Andersson , Andy Gross , Shawn Guo Cc: Rob Herring , Vinod Koul , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201130170028.319798-1-bjorn.andersson@linaro.org> From: Steev Klimaszewski Message-ID: <58cf6829-4121-db46-04f7-0dc6c59b2053@kali.org> Date: Mon, 30 Nov 2020 11:25:58 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201130170028.319798-1-bjorn.andersson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/20 11:00 AM, Bjorn Andersson wrote: > The "pins" property takes an array of pin _names_, not pin numbers. Fix > this. > > Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630") > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > index 399aef2a0951..bb314973eb0c 100644 > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -432,7 +432,7 @@ &tlmm { > gpio-reserved-ranges = <0 4>, <81 4>; > > i2c3_hid_active: i2c2-hid-active { > - pins = <37>; > + pins = "gpio37"; > function = "gpio"; > > input-enable; > @@ -441,7 +441,7 @@ i2c3_hid_active: i2c2-hid-active { > }; > > i2c5_hid_active: i2c5-hid-active { > - pins = <125>; > + pins = "gpio125"; > function = "gpio"; > > input-enable; > @@ -450,7 +450,7 @@ i2c5_hid_active: i2c5-hid-active { > }; > > i2c11_hid_active: i2c11-hid-active { > - pins = <92>; > + pins = "gpio92"; > function = "gpio"; > > input-enable; > @@ -459,7 +459,7 @@ i2c11_hid_active: i2c11-hid-active { > }; > > wcd_intr_default: wcd_intr_default { > - pins = <54>; > + pins = "gpio54"; > function = "gpio"; > > input-enable; Tested-by: Steev Klimaszewski