From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17EB42820C6 for ; Wed, 11 Mar 2026 07:51:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773215485; cv=none; b=WuT+DyE1Yo3Re/jUMhYtidVbtjz5HmqsiT4RQQSp9lCl5zLlIOAt+fBKFwg+aDMCNDIgseyeqIMB7/OWCCoNOrN4XA9+g2nfqO5nH1H1pi+JuwMO1bOhZsE2iZsJC+Toi7DJQiobPKIFBTJhuDWR3OaybRm0QhenOoE5Kh+PWjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773215485; c=relaxed/simple; bh=33px9R0U+Jj2AGVLCrfgkPaFqA8tfSwub53xsJDNeJs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=LxKa0LOtZfgQpc26D1S4zCwvEqsMXJo7aU1PXtKTmFHQfG3ydkMNYkKWcypdnUKJqQuORhXKHZIZ+geSOFRpLrV2DfsZWaASGeWolbqlfHqbmoMudImkkAbRwjthCxCdKy6nw67yunshm8vlS2zTcqaFsaEWoOrMQHkBdUgqv+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w0ELg-0004cM-Fl; Wed, 11 Mar 2026 08:51:20 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w0ELe-004pDl-2c; Wed, 11 Mar 2026 08:51:20 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1w0ELf-000000002EI-3eIP; Wed, 11 Mar 2026 08:51:19 +0100 Message-ID: <58d0b77fa33d9774b7f6038fb0a88f6dd384921a.camel@pengutronix.de> Subject: Re: [PATCH] reset: don't overwrite fwnode_reset_n_cells From: Philipp Zabel To: Bartosz Golaszewski , Mark Brown , Geert Uytterhoeven Cc: linux-kernel@vger.kernel.org, brgl@kernel.org Date: Wed, 11 Mar 2026 08:51:19 +0100 In-Reply-To: <20260310151515.34681-1-bartosz.golaszewski@oss.qualcomm.com> References: <20260310151515.34681-1-bartosz.golaszewski@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hi Bartosz, Mark, On Di, 2026-03-10 at 16:15 +0100, Bartosz Golaszewski wrote: > Fix a logic bug in reser_register() where we set fwnode_reset_n_cells to > 1 if fwnode is set and fwnode_xlate is not but we do it after assigning > of_fwnode_handle(of_node) to fwnode. >=20 > Modify the logic to: assign fwnode from of_node if applicable, if fwnode > is still not set, try to get it from the device and only then check > of_xlate and fwnode_xlate and either assign fwnode_reset_n_cells from OF > or default to fwnode_reset_simple_xlate and fwnode_reset_n_cells =3D 1. >=20 > Fixes: ba8dbbb14b7e ("reset: convert the core API to using firmware nodes= ") > Reported-by: Mark Brown > Closes: https://lore.kernel.org/all/0b72286b-33dd-4bc9-8c0e-161c2f4baed8@= sirena.org.uk/ > Signed-off-by: Bartosz Golaszewski Applied to reset/next, thank you! [1/1] reset: don't overwrite fwnode_reset_n_cells https://git.pengutronix.de/cgit/pza/linux/commit/?id=3D62d11b80ea5d regards Philipp