From: Matthieu Baerts <matttbe@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Jason Xing <kerneljasonxing@gmail.com>,
mptcp@lists.linux.dev, Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: clamp window like before the cleanup
Date: Thu, 6 Mar 2025 12:20:29 +0100 [thread overview]
Message-ID: <58d604b3-760f-449d-95b4-c56d8b9da400@kernel.org> (raw)
In-Reply-To: <CANn89iJ2S+mCs8PxZ-EBAfH--j6v9cUazCc8O4FWvMat=_yURQ@mail.gmail.com>
Hi Eric,
On 06/03/2025 12:08, Eric Dumazet wrote:
> On Thu, Mar 6, 2025 at 11:16 AM Eric Dumazet <edumazet@google.com> wrote:
>> On Thu, Mar 6, 2025 at 11:12 AM Matthieu Baerts <matttbe@kernel.org> wrote:
>>> On 06/03/2025 11:02, Eric Dumazet wrote:
(...)
>>>> I am wondering if this could hide an issue in MPTCP ?
>>> Indeed, I was wondering the same thing. I didn't see anything obvious
>>> when looking at this issue. The behaviours around the window clamping,
>>> with MPTCP single flow, and "plain" TCP were quite similar I think.
>>
>> OK, let me run mptcp tests just in case I see something dubious.
>
> I have no idea why only MPTCP flows can trigger the condition, I do
> not think it matters anyway.
Thank you for having looked! Did you manage to trigger this condition
with "plain" TCP (without MPTCP) when using "./mptcp_connect.sh -tt"?
The TCP only connections will be printed like this:
nsX TCP -> nsY (<IP>:<port>) TCP
But yes, it probably doesn't matter.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-03-06 11:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 14:49 Matthieu Baerts (NGI0)
2025-03-06 5:21 ` Jason Xing
2025-03-06 9:45 ` Eric Dumazet
2025-03-06 9:55 ` Matthieu Baerts
2025-03-06 10:02 ` Eric Dumazet
2025-03-06 10:12 ` Matthieu Baerts
2025-03-06 10:16 ` Eric Dumazet
2025-03-06 11:08 ` Eric Dumazet
2025-03-06 11:20 ` Matthieu Baerts [this message]
2025-03-06 11:18 ` Jason Xing
2025-03-07 0:31 ` Jason Xing
2025-03-06 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58d604b3-760f-449d-95b4-c56d8b9da400@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®