From: Armin Wolf <W_Armin@gmx.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
auslands-kv@gmx.de, corentin.chary@gmail.com, luke@ljones.dev,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: Ignore return value when writing thermal policy
Date: Mon, 2 Dec 2024 15:32:14 +0100 [thread overview]
Message-ID: <58da1c4a-45ca-406b-9466-1186c0114cca@gmx.de> (raw)
In-Reply-To: <877a18c8-048c-6c7c-72c3-d899349b278d@linux.intel.com>
Am 02.12.24 um 15:29 schrieb Ilpo Järvinen:
> On Mon, 2 Dec 2024, Armin Wolf wrote:
>> Am 29.11.24 um 20:29 schrieb Armin Wolf:
>>> Am 25.11.24 um 10:39 schrieb Hans de Goede:
>>>> On 24-Nov-24 6:19 PM, Armin Wolf wrote:
>>>>> On some machines like the ASUS Vivobook S14 writing the thermal policy
>>>>> returns the currently writen thermal policy instead of an error code.
>>>>>
>>>>> Ignore the return code to avoid falsely returning an error when the
>>>>> thermal policy was written successfully.
>>>>>
>>>>> Reported-by: auslands-kv@gmx.de
>>>>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219517
>>>>> Fixes: 2daa86e78c49 ("platform/x86: asus_wmi: Support throttle
>>>>> thermal policy")
>>>>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
>>>> Thanks, patch looks good to me:
>>>>
>>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>>>
>>>> Regards,
>>>>
>>>> Hans
>>> I forgot to add the following tag:
>>>
>>> Tested-by: auslands-kv@gmx.de
>>>
>>> Can we pick this patch for the next fixes pull?
>>>
>>> Thanks,
>>> Armin Wolf
>>>
>> Another user (Edoardo Brogiolo <brogioloedoardo@gmail.com>) reported a similar
>> issue with another Asus machine,
>> see https://bbs.archlinux.org/viewtopic.php?id=301341 for details.
>>
>> Are there any blockers left for this patch to get accepted upstream?
> Hi Armin,
>
> I don't think there are any blocker I'm aware of. It's just that I'm
> extremely busy right after the merge window has closed as usual.
>
Ok, then i will just wait a bit.
Thanks,
Armin Wolf
next prev parent reply other threads:[~2024-12-02 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 17:19 Armin Wolf
2024-11-25 9:39 ` Hans de Goede
2024-11-29 19:29 ` Armin Wolf
2024-12-02 14:23 ` Armin Wolf
2024-12-02 14:29 ` Ilpo Järvinen
2024-12-02 14:32 ` Armin Wolf [this message]
2024-12-02 17:03 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58da1c4a-45ca-406b-9466-1186c0114cca@gmx.de \
--to=w_armin@gmx.de \
--cc=auslands-kv@gmx.de \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®