From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753330AbdIFV0s (ORCPT ); Wed, 6 Sep 2017 17:26:48 -0400 Received: from mail-bl2nam02on0057.outbound.protection.outlook.com ([104.47.38.57]:47276 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752693AbdIFV0W (ORCPT ); Wed, 6 Sep 2017 17:26:22 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gary.Hook@amd.com; Subject: Re: [RFC Part2 PATCH v3 02/26] crypto: ccp: Add Platform Security Processor (PSP) device support To: Borislav Petkov , Brijesh Singh References: <20170724200303.12197-1-brijesh.singh@amd.com> <20170724200303.12197-3-brijesh.singh@amd.com> <20170906170029.bvpii7e7x3fglhwt@pd.tnic> <20170906204606.f34esvg464ynsrjn@pd.tnic> Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Joerg Roedel , "Michael S . Tsirkin" , Paolo Bonzini , =?UTF-8?B?XCJSYWRpbSBLcsSNbcOhxZlcIg==?= , Tom Lendacky , Herbert Xu , "David S . Miller" , linux-crypto@vger.kernel.org From: Gary R Hook Message-ID: <58daec6d-4c37-ff7f-1473-8ec64f0a9f3a@amd.com> Date: Wed, 6 Sep 2017 16:26:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170906204606.f34esvg464ynsrjn@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR2001CA0023.namprd20.prod.outlook.com (10.172.112.161) To BN6PR12MB1314.namprd12.prod.outlook.com (10.168.228.8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84f3b8b0-620c-44c3-82b6-08d4f56de9a1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN6PR12MB1314; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1314;3:OXu/nEsuoQM2gTMHOFgHMpuBCZGM148S+7SgjoD/4bqnvWU112DsclwcecQBr8Fzr8ZmUgyfGncxCiegX2fUkVh4AhZcXKJ22sWl0RluYWAHVAklpSiiceOCm2U/JuNWROmzt1/PgasSU2JbkEiEIW0AemkJaOwKdtGJ13lozvxPzneCosk5EGjfoIeR81r3Je1a3+vw4QHEX01qyqfzmutufrcOv/zv7lnn8lFbyr9b+Nm2jBzVuILWJutOmG79;25:S0xDW+eHFy9eCdcf0FA1fP1ZjOjwxA6yRZm4gdTGfM3SsbGcMeOUZrQ0b04P1ti1Sujx+JcBiUWOeqxAQ68b+h4N/IcNmLpEywJQ+CbbRhJss5XWwGgrEZYMs20QdQ+u9kWqoQoiz+invB+JHT5dZgEXtuMIFOtc7t1/ydssA6oogVMMhfcdO55YNqQKZbuiJlF9kNlAasg2CAnaOP877/WPR/nRd5Mzm3Ml6Y39Mg68Plfsy4d+4iTtezHvzhlJZ2QAmg/iCRsda26dd4VyMiaawOgZvd18c4FF/2E+DkC4aNQm6YSNf8/4/dX+DMz3xf/pQQsD8RDHV+DgEyUj5w==;31:wYh72sGzePOUnIBAfiXln3xDWhmzUhJW5M9xii1VXrJDqEvNBntuuz03ctmFy2HZZGihQX/+eikgRfRkPKmyX5Owp9r31Ga5b07miujLORF0yQ6FzRdh1vpRZuBQqxc1cx4OIUYxiWOukIzb3xovCh+bzOITw7hXF1eMkHW2w657luooIVqlaTtvlfJebKMHJy5uQpM7/r8F4msRMEzQI0pprwUeJeOS13OZsLrUvkg= X-MS-TrafficTypeDiagnostic: BN6PR12MB1314: X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1314;20:SIbIPUFvQZYZkzD4EBaIx5XHwkM9f+DvlCx+20APl0KGEh1vA7BsUdqm9vMfkqn1qzekJK2gef60ktWZyiv4NlKmagytrVIEhlCZUP1zRandd5a8XhWBNnaFA8Bnf+/HGYx4Uchj+vZhk+HI0dU8y7e5+pOO5leEEOK0dnOKhPB/RDMn8bz4Nf1/62Cyw+yKWaMzoY56/d7AesCFagneEQAnf2cMUKq+3pkdDuvbuXbzLSuITmeB5gqZw6fGGi8mxPJwDNUb95nXw2xhLcmQPCJOBwPFKWqxHbTFT1ZFK5fyxMNtDaK5xA4FRwkRAsuhh6solhlkdTyXdPdhpQ/1Q6pKL7vO7thrFDFVVNrI13Ia0FZFQPqXGJ5u+Ih8N3PizG5IyjJBeOupo8ErKrtXApe88CSASRYpvTShodFlfMJ8PXgsQCosHdQQjsLjoy7iJ+0mW4/LxtrM7LAMFPv1IZxub2XGO36R87af6OFE0HIesi6x24F1r5ro50q++t5/;4:aya8XpqY+yEuWWkaXFANlThkoXwyn4cfi9ZXun2LlNN3pyQwCJgNLHxR6RFVbPS31MlSbk9hwE/dEmB50L3Kv5FgUHtbEhhRcwzew+fd47oxmEKlvJEtmv4o+awxfUfSBDO+xZ7lwN7UThvVqj2PoJgURzQf4JeiyMmib8eCa4BiNSP2cHmvcpG5tL9kv8HzmRELaepoIGpwlM3/JH+C+dh5vok/tS0gDlsOA52Hrli8iEmffM1hJbr6OJoFefVCP3T/b+aJ0RDMDw1W1Dhi6oiiwMi/fz2P/G7a/0xSjMc= X-Exchange-Antispam-Report-Test: UriScan:(192374486261705); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123560025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR12MB1314;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR12MB1314; X-Forefront-PRVS: 0422860ED4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(39860400002)(377454003)(24454002)(189002)(199003)(68736007)(230700001)(54906002)(3846002)(2950100002)(50466002)(6116002)(36756003)(83506001)(31686004)(6666003)(86362001)(6636002)(65826007)(33646002)(229853002)(42186005)(76176999)(5660300001)(31696002)(575784001)(53936002)(7416002)(54356999)(6246003)(50986999)(101416001)(90366009)(6486002)(53546010)(106356001)(25786009)(4326008)(77096006)(65806001)(66066001)(72206003)(65956001)(81166006)(105586002)(64126003)(2906002)(47776003)(93886005)(189998001)(478600001)(8676002)(97736004)(4001350100001)(8936002)(81156014)(7736002)(23676002)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1314;H:[10.236.19.127];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMzE0OzIzOlVkVVZlUy9OdlEvV1BvQ2Nhakd4MkRtK0Fi?= =?utf-8?B?NjdiaFB0YWRYcHNqOFJ6ZjhKTnU2T3JiZlFDdExsU21SZUlTMVIyd0NiQ0w2?= =?utf-8?B?S2F0WW11Zm9JbC9BYnRkMmpZVFJYMTA5ckpCM01vODFuNzJYcVZzNytMT05R?= =?utf-8?B?TkNpaUpUYWxvNkU2WHNEQStlL2Q3R2oxclV6azlQSENWZUVsaklqb05pbFpa?= =?utf-8?B?NlR5TW9McitPb04yNGU2VWlSMjhSLzdMbXM1cEs3bUhTQmpEcTlSVjFBZUdr?= =?utf-8?B?VGlub01tUlMySUlFaExsd0I5cnhJYzJvdnJmWXRtYUxoZXV5Tk5GNzZwTU1T?= =?utf-8?B?MXBJUXVVWGZYejBNV1BNVXJ0MlBRUFUwNDBxYW9aU3pZazQralBjZmR0VWJX?= =?utf-8?B?bUtEYm1rYWtPNUI0RlpOUlNuL1lCZUFWK1hSdjZXRENNbmxYZlgrcXhYRmdY?= =?utf-8?B?TGtnNHZUSExFVW0rMm1LN1ZRRjdFOGpzYnpuMzhyWjBKK3Z4WnVGNjVBUDdX?= =?utf-8?B?UGtGOTZiN1VjUTFRbmVkTWw1OWlwY2RwbEMvVWsrK0RucHY5TjNSM1lmSkN3?= =?utf-8?B?bGYvdE5vVTBaZnRnNXZyMUtqU0JJOWVpYWhlekwyZDV6clNDM1ZjUldHM3Uw?= =?utf-8?B?dXN5a3d1YSsrOXhDeStkbGdVdzRNTVZobElvK3p3dkl5MUtsekl6OUtaMm1P?= =?utf-8?B?ZmJuSjQxVDc5blNKMzNPNVE3WlRmdk9CY2dncXRDNU1oT0FqV3pWQWFwbGJj?= =?utf-8?B?Z0VkS0JIY245M1pzdmIvTE1qZGZYVjU5WGlySmtBVWZ5bzk2eHQ3aVdPQ1lZ?= =?utf-8?B?QU9vZmU3VDVQYXhKRkVsNW9qWEpxbVVMNS9PSkJlYlM1Y1ZhbldwVDlpTTBH?= =?utf-8?B?YS9FM1RSNU56SFQ5RVBTSENuOFEraEFrb0xkK1gxa1FKVzVXN1RGZERPQlBK?= =?utf-8?B?dFRGYTIvUjR0V29JK0tHdTU4L2ozWnVSY3ZNT2oyQ242aU8vM0dlU0VObndl?= =?utf-8?B?WFRNL1ZIYkIxS0FaZGRzSGNqVnF0d3NsTzFzd2RPVEd5Sld1SkhickRHR2NM?= =?utf-8?B?a2FxR21RS0xUMjVweUZONHFaZkVJYy9oZzFaSUdVcHFVYmtwVUdOSlZmYUM5?= =?utf-8?B?NjRsR0VTeEd0d2VZZGhlMG8zZmxIQWFLWHdIV2txMTBFelFXbXVXdnlpVUpz?= =?utf-8?B?b2JCMkZlS3J2d254QkVXYjJmUWRHQVE2czZOMW5JWVBKSXF6eTdYT3A2K0Jo?= =?utf-8?B?Z3E3OFU4QlZhQVdNQWRUYTNLd2ZqY0g4MHpDSzVBQkJSM2VmQVRkNjBmVWF6?= =?utf-8?B?K0xNNDY3bWdCS29LYlhPbUNYNHhkVVI4MTdTOTBkVVBTSzBXaUhKYTdYQjc3?= =?utf-8?B?NHh5dTdtdzlYM3hjYlhwMUNZOElYdE9lbWdSWWRtUWtVZFZFcDNIQWEyY3E1?= =?utf-8?B?NkI5Rk14RUpWdGJBMW0vaHZFMk1HQjFtY1FJZmtQMkl4cDB3ZzFKRHZBWkZR?= =?utf-8?B?L0Z2MEU5Uzk2bW5VeUJsYkpaYURhRVN2ZGpQczdibmt1YUVrbFkxeDR0NHNL?= =?utf-8?B?K2M2NVYrdjBNMXVTa2xRSzFmN1UzaEpBV1Q3UHdkeVVUcEJVbDcrekJQaVFn?= =?utf-8?B?eGVGbHZKYzFjZjU5OXhxU2Yyak40end6dk1ZMTRSbzRXSXFCNmZtNkJzNE5k?= =?utf-8?B?NjMxYjdqanl3QnZpN0tPYXNYU0F3ZjJHTEJ5OHNQNGVYbXhZNVM0dWJ1ZmJk?= =?utf-8?B?M3hqd1hhdkhSY0M2VlgzM1AxMHdlM1AwRERyZTBya3JhZTdidm5uNXpoNlpa?= =?utf-8?B?enF0WFR6azRYTlFqOElYamNZVDF3eUEzR01Eb0oyMlpRMUU3NE83QlFnZTU1?= =?utf-8?B?ZzdyZS9BWDN0YTN4QjRiRURWcnNiTm9hK00zMlhEWVAwR1VNV243NFI5UGJ6?= =?utf-8?Q?0YIv5M803PcYWL+JVh8HBRd0l2FnIQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1314;6:CFSJKdV62UustJy7VRienSQogXKXsrsFEqYIXdBOHxkcraTai4c50KLU1h8h6URp9md8HhKGMdyPvFtU7cpixJxGaSCtRYAvTd1xh+nw8rYeufh59Fs7roRZXg/lHSjBR2ICI2BgwtNV3s4BsSsQj8RRFppWAjHwUDszJWuUqAimWd8YrmI/5IoFB4d3ADeZqydpZdKv8SimSdSxC1+WuzjdFJ4TM3Fv0yyljsxJ7jPOv2TUGgriKNeh3bswGY7hEw81vmFkySF+O+ZBanMkkVUC0N+2KU2tAPf/WqSeioQJUf8rREVDpbGYgvAKxvXSzjyORofVhs+MOn+B2giPow==;5:Xv+rI3mSqV5kyItIxiO4vwlHyZD7U93zS3DoE3BxSanr1L4DHJD57EI5oHtlq8q0nia8M9N2eL0P+f+2nft8tAb/yyvu4VGuIOlOTx4PQkwZvMQfnRF19E9JCNBJCVbd5NIQDhm6bn3EqGHX0RwvUw==;24:HD5pH052WxqOa7ySPafJNg588Vhc1WYHUK9tG5Yhra7L56dqh8Tqmw7dUf3EiGaF3BCsmSNRWdSOGscZLKZWiJzblG5A0lMaCxzQp1wC13U=;7:8gmDKO1gEqyvO6JbIzN+ARykON/k7Wg+OOB7tnF/UaVKgxBUw4CnQUSMFNGOyyme1iVelEFNN72U6OO+9nxT5Re4DVB1/Y8j30FGQ9JiCF+D+Ncy+FpU70+VdW2JbQBS0khN5lYwMxsA9BexLex7m122EtJLbY9i0+UXMzvUwCOXguomvaORjelN8xgZLS0jGCZCSXkN+Wqx4mnH90LEZVE+D9VDK/jLH7McPSTAiA4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1314;20:wM7Rku4oYN9mTJJyPQIayHWn4+Zb8POxm8zjAri9B5yfTMx7Pi7qGbaMAwgNy07KcOBPiTbuOwef6XXTrMwVcR7+FYn17VKEuL2rjJMJ++3IfGzcWqFKD8Uyk++h38iizTKJ+dtwq43EKWpi5gpa7B2kVuryauoyRe/a/b88A/ATLB67acDbTQ65ubjvep9/fefN/BvicOgCcfK1/+P/WAUHiNpSlAvyE/qhwymvSRcSH3dXk5DK+5nC+y5O4/3m X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2017 21:26:17.9280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1314 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2017 03:46 PM, Borislav Petkov wrote: > On Wed, Sep 06, 2017 at 03:38:38PM -0500, Brijesh Singh wrote: >> This bit of my struggle -- tip/master is not in sync with cryptodev-2.6 [1]. > > Aaha. > >> In order to expand the CCP driver we need the following commits from the >> cryptodev-2.6 >> >> 57de3aefb73f crypto: ccp - remove ccp_present() check from device initialize >> d0ebbc0c407a crypto: ccp - rename ccp driver initialize files as sp device >> f4d18d656f88 crypto: ccp - Abstract interrupt registeration >> 720419f01832 crypto: ccp - Introduce the AMD Secure Processor device >> 970e8303cb8d crypto: ccp - Use devres interface to allocate PCI/iomap and cleanup >> >> I cherry-picked these patches into tip/master before starting the SEV work. >> >> Since these patches were already reviewed and accepted hence I did not include it >> in my RFC series. I am not sure what is best way to handle it. Should I include >> these patches in the series ? or just mention them in cover letter ? I am looking >> for suggestions on how to best communicate it. thanks > > Right, so I'm assuming those will go upstream this merge window, no? They were included in a pull request (for 4.14) from Herbert, dated Monday.