From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA744273F9 for ; Tue, 7 Jan 2025 23:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736293145; cv=none; b=qROeFz07Jrj9HHtIfOCTOSrf5axRl6qPXxlYJ94nnUWoaMJRDD+5xrubbSsabRqqLo9BLODdL0xVWzmDAUzUMPkTnOny6zVcnrPCAggaF2CJXKiqEluqb6ro2RClOcOY+nbo9wobhr9jsEwnMlZrQA39OcsS60wbHr8vkzzctT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736293145; c=relaxed/simple; bh=DFmn8VSyAUHQzVS5msOVeVe/Mf9jzF9AWH47Vr1havA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jfGtCHUZaVRiKiCJhNhqj8RYBTgArsu4dL8bo/jsQkCxHcdnFKVtK83A6G5GjbBPyvmMOck1SpbnKjz0X0jCT9+BAMa4HtHuKIdN9do64e2GscJeIviE18os5O9QDWFl4zsy1gP2BcvmmD35b6P0kFa3RJKOIPZhjalP7Eoz8No= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Ji2tzGm2; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Ji2tzGm2" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-71e15d9629bso4349672a34.1 for ; Tue, 07 Jan 2025 15:39:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736293142; x=1736897942; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dBAD6yeWOQzt7479x35xKD5+k6y1LOWMDjtiTVM5/j0=; b=Ji2tzGm20AE4bSvh9mLE4EvhLm6jykS/oNtq8ZJoMVxZ/7u/L4UOyjJQvffkxfO5Bh WPW9+P8gIUwg8yJQDRT7L/AssEZrdYdtWVQviRhHbZ6ipPBQXfk2U+WY8XyfiAFFbpBW VXGuR+latkuxfddnx8ptX4OG1LpR1xwYLdtM6J+iMC+ENxYKHxyslnB35Q8Rz5c4nFFt JGrR2PtPBISxPM19Dvn05KdTk50dXRXfv0tN+LmOMsNWBwKrN5i7NOLTe0rjOb93yU0d 3Hpbou1RZvwRv3P2PQjgUeT2duFqwEhXE8ZXHc0CdNJwi7H8IqAvH47s+mLQLvf7hlzT 61Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736293142; x=1736897942; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dBAD6yeWOQzt7479x35xKD5+k6y1LOWMDjtiTVM5/j0=; b=ShW3nteUte5Df+wUYAVWpL2etUt/4YlRk25wQ88rfXvAMjW8legK/muLgumyb4IjfN DGY5PqFtVa+IYFmqQm14rrQ1DYdX+/vbnPVB6w9yyA//501CQ33sUddt7NWJofR+jNt1 SEhu6fxhoHQHT8ka+xE0hpgJ49ZnBRW3AxgOoA9fei3p5m/uQvzJLxNSWcYxcSqycQyM 0WMU+YgO/JCvBWPFz9T/+lHf0P2De9QD0t+WGdEREwDiKReuu4WJ/635pXq0xo0x0RNR dElxs5Viz87DpN+v966ysv0W2GAeKLJBur0oD2fDhVei6WvVWuYdIr2UGnOxgDatdGY/ xpuw== X-Forwarded-Encrypted: i=1; AJvYcCX+vRXsKYeQudIaGOjA0TPjKD/rNY7vCI7qK6+0vy5trJXNM7VDUbm3v3qg2T0YBFfYGU1HgpxnuabEjVI=@vger.kernel.org X-Gm-Message-State: AOJu0YyLAMUJPUU8UOpsazZpqT+Sdxn16LxF8A41lJQEg4k7wP44VTA4 R9tKHpGQXqpT5MSLL4fXFn2Lk+wcYKhPGKbzUlMu69+oivTZpJhilKPB3JB3xL4= X-Gm-Gg: ASbGncskIYPSTijQfWvwC3ueYO56/1BqGtiFo+bHv8Xp9Soz86L8CLx6Y90ncNK5GZY drU4/kTjaRuM0RfjSOORO4HVXeXYPXNBM/pqDf6CDaCwiCwZ8zJ8CrZDvm+iND2UXWIthPQ+dho lVz6V314jz7AsZbb+FR9XghgeJz9LXSyi7VGwt26nGyOIri+WY48LxXNS3CFiclf5yvhvRtzt2T hL6anwtqWq9lPwn6Ji5pv9/S1zWYx0+4Fuo9P79hdR++QYr76TpfUAcc2144gGU1KdCGUFmD37X dwD3hxl1Z5agK9h0Wg== X-Google-Smtp-Source: AGHT+IGaz3KfG3mjB1yfjWpHZMsowJ++X1Kyc9cU0l4p7loNNycdbgi6bR57p7hkV2D7F8W3gevfWQ== X-Received: by 2002:a05:6830:92a:b0:71e:5667:30ce with SMTP id 46e09a7af769-721e2ee4602mr481975a34.28.1736293141856; Tue, 07 Jan 2025 15:39:01 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-71fc976438fsm10631899a34.10.2025.01.07.15.39.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 15:39:00 -0800 (PST) Message-ID: <58ea1899-05be-4743-911b-77a56f08c347@baylibre.com> Date: Tue, 7 Jan 2025 17:38:59 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 03/15] Documentation: ABI: testing: ad7768-1: Add device specific ABI documentation. To: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, marcelo.schmitt1@gmail.com References: From: David Lechner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/7/25 9:24 AM, Jonathan Santos wrote: > Add ABI documentation specific to the ad7768-1 device, detailing > the decimation_rate attribute for better clarity and usability. > > Signed-off-by: Jonathan Santos > --- > .../ABI/testing/sysfs-bus-iio-adc-ad7768-1 | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ad7768-1 > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-adc-ad7768-1 b/Documentation/ABI/testing/sysfs-bus-iio-adc-ad7768-1 > new file mode 100644 > index 000000000000..065247f07cfb > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-iio-adc-ad7768-1 > @@ -0,0 +1,13 @@ > +What: /sys/bus/iio/devices/iio:deviceX/decimation_rate_available > +KernelVersion: > +Contact: linux-iio@vger.kernel.org > +Description: > + Reading returns a range of possible decimation rate values. > + > +What: /sys/bus/iio/devices/iio:deviceX/decimation_rate > +KernelVersion: > +Contact: linux-iio@vger.kernel.org > +Description: > + Sets up the decimation rate for the digital filter. This can > + directly impact in the final sampling frequency. Reading returns > + the decimation rate. Writing sets the decimation rate. If this only affects the filter, I would suggest to add `filter_` to the beginning of the attribute names. Also, an explanation of how to interpret the numbers would be helpful. It looks like a unitless number that acts a sort of a multiplier or divider, but that part isn't so clear to me. Or... Since the decimation rate affects the -3dB point of the filters we could use the standard IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY instead of introducing a new attribute.