From: Yihang Li <liyihang9@h-partners.com>
To: Jason Yan <yanaijie@huawei.com>,
Bart Van Assche <bvanassche@acm.org>,
<martin.petersen@oracle.com>,
<James.Bottomley@HansenPartnership.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <liuyonglong@huawei.com>,
<prime.zeng@hisilicon.com>, Yihang Li <liyihang9@h-partners.com>
Subject: Re: [PATCH 0/4] scsi: hisi_sas: Switch to use tasklet over threaded irq handling
Date: Wed, 27 Aug 2025 10:14:56 +0800 [thread overview]
Message-ID: <58f31c71-1d70-e763-45b4-66b4778ba028@h-partners.com> (raw)
In-Reply-To: <41077713-8119-4898-8307-731a0d8f346e@huawei.com>
Hi, Jason
On 2025/8/26 16:47, Jason Yan wrote:
> 在 2025/8/25 9:42, Yihang Li 写道:
>> Hi Bart,
>>
>> On 2025/8/22 23:17, Bart Van Assche wrote:
>>> On 8/22/25 12:59 AM, Yihang Li wrote:
>>>> We found that when the CPU handling the interrupt thread is occupied by
>>>> other high-priority processes, the interrupt thread will not be scheduled.
>>>> So there is a change to switch the driver to use tasklet over threaded
>>>> interrupt handling.
>>> Tasklets have severe disadvantages and hence their removal has been
>>> proposed several times. See e.g. https://lwn.net/Articles/960041/.
>>> There must be a better solution than switching to tasklets.
>>>
>>
>> Thanks you for your reply. I will consider some other solution.
>> Additionally, do you have any good suggestions?
>
> It seems the official replacement of tasklets is WQ_BH. However there are very few users now. I'm not sure if the stability and performance can meet our requirements.
>
Yes, so I will first attempt to modify it using WQ_BH,
and after thorough testing and verification,
I will report the solution to everyone.
Thanks,
Yihang.
prev parent reply other threads:[~2025-08-27 2:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 7:59 Yihang Li
2025-08-22 7:59 ` [PATCH 1/4] scsi: hisi_sas: Use tasklet to process CQ interrupts Yihang Li
2025-08-22 7:59 ` [PATCH 2/4] scsi: hisi_sas: replace spin_lock/spin_unlock with spin_lock_irqsave/spin_unlock_restore Yihang Li
2025-08-22 7:59 ` [PATCH 3/4] scsi: hisi_sas: Remove cond_resched() in bottom half of interrupt Yihang Li
2025-08-22 7:59 ` [PATCH 4/4] scsi: hisi_sas: Remove unused hisi_sas_sync_poll_cqs() Yihang Li
2025-08-22 15:17 ` [PATCH 0/4] scsi: hisi_sas: Switch to use tasklet over threaded irq handling Bart Van Assche
2025-08-25 1:42 ` Yihang Li
2025-08-25 16:12 ` Bart Van Assche
2025-08-27 2:11 ` Yihang Li
2025-08-27 3:18 ` Bart Van Assche
2025-08-26 8:47 ` Jason Yan
2025-08-26 13:45 ` Bart Van Assche
2025-08-27 2:14 ` Yihang Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58f31c71-1d70-e763-45b4-66b4778ba028@h-partners.com \
--to=liyihang9@h-partners.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=prime.zeng@hisilicon.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®