From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9889A44CF56 for ; Tue, 10 Mar 2026 10:06:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773137189; cv=none; b=Z67XezxZPBK95uTKWW1gKcjmMXFpqKad8j5GPNVuVeYdd5SagBUwZh3UaO1ezGGDl/Tsm4uQ/mW3OJgH/o4p8CsXSW5/Lr7w5Qk5M2IPHUoLAWo0ajUbA1LUre9ysZVZRVSL2EulB6puJUVVcTftsI9m2NiDEJZ5zJJYWccH/cM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773137189; c=relaxed/simple; bh=g2XUM9dvvm8cVk5OWuSpx7/gOYlOEWshlkLBJaa0vAU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YOLTRTysYet2crEmwe1DmPHMRI1m+Ge3sJEQVPFDlakvi2bu14alGnXO/G/EiZFQTqU299m+xT9hhbPbQMet7hSTNOQvOxSFF7W8YdEiEF3YQ0m4+sJ8ZOqR82NFHE+Z/a0cJC1Ag+sJ5vljKnAyg6ZihWhhoSvbbWW+/c6tVDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hxFLJaPz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=blWS/qYp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hxFLJaPz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="blWS/qYp" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A9LPVJ2020564 for ; Tue, 10 Mar 2026 10:06:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zym8eQRUnoxy0/BAjJ8cuqc0CkUIHWRkqrzGNeSb23c=; b=hxFLJaPzisZZN+jE +7Pri14DDd7KUEvIaQZDPIXFcX+wCQndBf/2rnxMD3KjDF2LSRo56TcYutc88uU/ vRgGWaD4jQRkDk3jG+MV1j1IkaYJZp3VdS8bRHr7bSXu6B3yME9iAtPKWgcFTrPC YHCjdpoIoEpVEDbNd+XQ8QpXs/d7MJcLwMQKH7hJabjPmitf2vkM5quy3YlwPx3f NEHENaRFEFR8Aom5OuVVbSZ82XJUu8R6EcvuTeoRmkjdHj9Cw1u9kfyqyX2cNsLY Hvj+bMa4eU1F7DnjQrK5jiyHp48hiSndNP4UqB7+sVMSKIZnTDilIS0OpDBWzNPf Th8iDA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csyhbupvj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 10:06:24 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5033c483b76so870007521cf.1 for ; Tue, 10 Mar 2026 03:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773137184; x=1773741984; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zym8eQRUnoxy0/BAjJ8cuqc0CkUIHWRkqrzGNeSb23c=; b=blWS/qYppNAmudHj5Uj16q4jA1HzAbdaWt2z13KrwkOxRlY+ntAi7v4dOTI8tbCOLg cVUWmiTRJov3m95ENWw78LeKWQfU7rsY0djPphO4T6B3/YSwe+edTJP792M28k/nPOvm LfyC5iqaS0usNyAci2kpB7gv2B6lRR504V2I+AfiaBxa8DZMQEf356+X8yeEVcepXcOO YUWlHdT3q0GB6GlG6azKyu3lcxYBgDgH0yS7YW558HaU2OL1mr1mB4jgdQAi8GEqSkTA OkVLNolfYey4QSbBOt410ehitdd06KJ63TLskNM8LOcvXGYG5z0HPzUwQNiL04WUOA7a eGkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773137184; x=1773741984; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zym8eQRUnoxy0/BAjJ8cuqc0CkUIHWRkqrzGNeSb23c=; b=C9wqml2+gNNH1KkX0n7CD3rayNH9f7nWVNTwKoARgybbO6QbadJBCctMIcE/yhBUyc pcEANxohpf5XGH4aEmTyoDu0RVaNjMvXXjXnG4i55daHn3dGcbWPDVkfPp3Tkb7xWMrX IllIG7BlS96XYGaiiQAkGqiFgX5PguVCaFfekL+nkBq2PHeqA5ZvFKpQrqQzGpbqQbsS 3lxEpDPVveDsHaITyOQSZAkzo+o+Q/8Y4YTxFy5by3ZNareAQwRT26uU6IT6YaEPjdTs 6Eby8CeAIWXalOE7u810fIJ9cSz1IiYk1RWX32LIGIfe5roQ3Fk5mo1HlxbOZGSRaWmt 1Rjw== X-Gm-Message-State: AOJu0YxP7sswk63NLen4BzNQJAx0pvsyIrr8f3KWdY2gVe/Z8iV8N6Dq Tm3MZzcTb9Y1rZzdWqueqsL9FMNp0XfkVMT8CHObgH9iDIqxvmS06CZQ9ubJPA20enVj9zsWVXb ZV6SSYGy/+5pP+E+Iz4ToZvbBJsO0YhEfqS8ZcpHDxcvBWF9fG+iHE2wL/Dl2+e6d7Uw= X-Gm-Gg: ATEYQzxrWD8ozQstsMYKN5Rqoh/Ei+OuxfgWiMRcwsyS8lz1pM3HMvxiRh4mIJ2b8oA wtDsDwa4D63jm9r6Ex/c71itb00cyv6B5HE5kJgepGFsIfoeqa4VF8oPHEUw3EHoFZlnluwbNGV TM2w3QqzKrw72Dov5FuwfdiwdLJSaOYexLR2wSZOmdQdEMXrvis84L9JwE8fRJWFIIVNfLNwA2p Pn7oywR+abRkYsqnvoXxH85j0XkRvQRyzCHvSIQE7e7PN8d4EfNRIQEOim4Xlofd5+nRrJe+C2d njeF+O8o0C6VhDgbVEALtdrgvExu+j/qTkzRCy8iyY7f1Rd95GRsWOAJgBTe/BhFP2NN5JCaQKG z5LGtdgh73GMg6AmTTeDraHiM2HyKkirSp3aLt7PSvomTujG6ANve3zMEIgAzINuGy4vOzN3b+j b+Tas/qxEd X-Received: by 2002:a05:620a:3943:b0:8b2:dabe:de32 with SMTP id af79cd13be357-8cd6d429895mr1705196285a.42.1773137183862; Tue, 10 Mar 2026 03:06:23 -0700 (PDT) X-Received: by 2002:a05:620a:3943:b0:8b2:dabe:de32 with SMTP id af79cd13be357-8cd6d429895mr1705192185a.42.1773137183406; Tue, 10 Mar 2026 03:06:23 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:ae20:597c:99b8:d161? ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad8d973sm32447848f8f.3.2026.03.10.03.06.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 03:06:22 -0700 (PDT) Message-ID: <58f49fb8-75ee-4dea-b7c5-28e89711f9f6@oss.qualcomm.com> Date: Tue, 10 Mar 2026 11:06:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI To: Konrad Dybcio , konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> <20260309230346.3584252-2-daniel.lezcano@oss.qualcomm.com> <7d036c96-e257-460c-a91b-deee0b9c348b@oss.qualcomm.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <7d036c96-e257-460c-a91b-deee0b9c348b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Rcmdyltv c=1 sm=1 tr=0 ts=69afed20 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=7MBKnE05AAAA:20 a=EUspDBNiAAAA:8 a=M45qCTXPNjoLw3xkhRYA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA4NiBTYWx0ZWRfX6Prb8Pk98Org xYrh2JsSiWsliYH2fL2+KNbpuG9RJin8RbGMpFBWd09518ddl0YSCnQJPBqzFDURhYhyvjcLaVH jHslUMcgcR7VXV/IH5owTDWXHsJ9A4fGrdWLW2rQ7ie2JxacW9rLZyIc+lK1N+JhGlpQqoObSqU Q+xNlgN1aK4ByXwU+ezr73HnkSDrDJUTRIJyUYYsnJLtFbA0BxQLFPk72vTOpXU91SjrYnfCGIc +HseQzyj6T7HfIkWn/AqXGbsuxOl8ReG7Io79drZH//ks0H1TevhLRODb9a6HNLCnRLmjg6ab+s XZg9DC3BimOuJmasvLNSVNskCJtxyWUBtlmslqH8KgiQF09xYQkrjfsh4kXhs2C6M8ygiBv4V8v 5GXhv1/5BTqk27CMwHu5TYAJu/FimZ7U/wXW2OT9tqy4f9UxzGHWfJg3NmtUE1CeT6eOaUseLtn VmiQkePLhqKYmorSeIA== X-Proofpoint-GUID: sTmjQTuSRj3EF4l0_Av9N0zsFRm2EwK8 X-Proofpoint-ORIG-GUID: sTmjQTuSRj3EF4l0_Av9N0zsFRm2EwK8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 bulkscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100086 On 3/10/26 10:57, Konrad Dybcio wrote: > On 3/10/26 12:03 AM, Daniel Lezcano wrote: >> The QMI framework proposes a set of services which are defined by an >> integer identifier. The different QMI client lookup for the services >> via this identifier. Moreover, the function qmi_add_lookup() and >> qmi_add_server() must match the service ID but the code in different >> places set the same value but with a different macro name. These >> macros are spreaded across the different subsystems implementing the >> protocols associated with a service. It would make more sense to >> define them in the QMI header for the sake of consistency and clarity. >> >> This change use an unified naming for the services and enumerate the >> ones implemented in the Linux kernel. More services can come later and >> put the service ID in this same header. >> >> Signed-off-by: Daniel Lezcano >> --- >> include/linux/soc/qcom/qmi.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/include/linux/soc/qcom/qmi.h b/include/linux/soc/qcom/qmi.h >> index 291cdc7ef49c..b8d07f2c07e7 100644 >> --- a/include/linux/soc/qcom/qmi.h >> +++ b/include/linux/soc/qcom/qmi.h >> @@ -92,6 +92,18 @@ struct qmi_elem_info { >> #define QMI_ERR_INCOMPATIBLE_STATE_V01 90 >> #define QMI_ERR_NOT_SUPPORTED_V01 94 >> >> +/* >> + * Enumerate the IDs of the QMI services > > In case that's useful: > > https://github.com/linux-msm/qrtr/blob/master/src/lookup.c#L23 Thanks !