From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B57B1DF25E for ; Fri, 13 Dec 2024 11:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734091071; cv=none; b=XqrnrimoIukWUOwJr9YKnQMQgff7yrbsged7UXEGvKVgfEX6PLfAOok/zusnxZH1jMqivjAPBePgnvqpfAs3wwdmurUBzs3vXw66EaNmR8Adfl0xGoYosH7tOfpXAwHcfRM8YG+2a1bEgweeTPDqCXa3QJSwHgzNmKzv9Ihg5N0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734091071; c=relaxed/simple; bh=hWxxhi/Ocb9YuWh9rCtFliyfqv/yGxNZXEi4SC0mxU8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BHVuaxZRHOwPzaP26gXrqlOq0p4qzATCODAzQJ4p9Qz6rFgPODatxsCJUYQl2tLUMV8GxUunc3EUrQMZV+ZvXEouapEJy+EE5ig7cx3EkUkwLIcwF1Hf/y8m+DA8jEM7mWK6D9IzzLocbmOpIyFjPOGih+dx2AP/ijCscZhuWkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U5Ych2/y; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U5Ych2/y" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BD7UDqZ026833 for ; Fri, 13 Dec 2024 11:57:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aV2tOvQFCHEHOQ3Ctr/HQDJboIVm3LzcOhrYk8KNUTw=; b=U5Ych2/yWxlumiaj RDnF3haOepVeZGKt8Ek8P0eOYJx7I5eCYAGfbFB01S7m9KF6w3EOYNB9QVYzPXfa 1QM+Q//DIUJ7Vgkmmp6QkO9aDmTZBQMIKdtipd1EJPQq8g5ffFYd4eKJL0UQD/hc PodHoed8HS8LbDYoaqld2rxtEPMOM+nwCkXoSmwVzzYpsjnw2taCEcqHTHZeZTza jSbf/mDT+IAQ3wVSs5kycduiuFiekJQ66N53JQDi/y4V39Kki+NQ6z1ULlZ074BE a1xjuclsombDccAiSa+a5ZB8LW63cfIXCm3GA5wP/gLej9LhsArk+Bn2ou3UmE8a WxPrKw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43fd40p8j6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 13 Dec 2024 11:57:48 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7b66edf3284so13928485a.2 for ; Fri, 13 Dec 2024 03:57:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734091067; x=1734695867; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aV2tOvQFCHEHOQ3Ctr/HQDJboIVm3LzcOhrYk8KNUTw=; b=g3R0Qf26+OfHYjGYfDttrblEh2izjJC2zCySdH7WAMC/m3SraEQphMEoD4iCMLFLl/ JeXhFJ6BhV/TfgCRCPuG/J+OUQJ2uHO+dfQYwXgZ89j234vmNQeeUDxlXuyPiTV/d4b/ WVIsMaYDqoD57FhVpISt9hWrrtvLzzV+9SpWL2DluTRfGLezRfApiWIvT/PhBZ8/F3wA mqZcRuTuzi5O55yEoxq1+Zau2KQuGPioUjfuPVvCOLrqFgnmv3niMuwbYNt67se/Qsf8 eb/Wo7f9OGT/p5qLkILjFEPDyzJOMIqUDTghYG50HeMJfVhZGetpLLw27SXFlWZqL9T6 eXig== X-Forwarded-Encrypted: i=1; AJvYcCVKjKXwDO8UKKJeZCWfX3OPztuEMOBqaSjQxCGAnBnGSMPmp4h21MN8Icroc0eu6j689knhWc1wZmDl+NU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy61ca+L9tVIcNzdUNetWLrdDllIDdO3KYznCMdaNCdzpAQ5ztw pEKbUNL7TZpXQ9rw8FNNoT4KpjR+o7WwaERwe2NhnLnKV/0YnbKAA0wBHmnJ61f2u8NXI13DXC6 Ay3PmseAmICp05RXaxwzI7opS24HZ7bkvUWxAq6/N6MOdahcI5F5YcmPOOoRJX9Q= X-Gm-Gg: ASbGncsuMf2fH+iHSsolz/r9QITfilQ4MO8jaSb5NAmUdp2Q3lGCIopWTx9gt+HIAg7 ahOdB0gNzJ/ZmfU7ITi48X9Mcx1cIeMBH3fiCuzs15ks6oQGOgt4hpZ/0ZapPwPxfugEw9KVVBZ sEXWU9VcdN3lb72yFVPwz1h7of28TdqLZCuInbt3gpqM7mxCeNPH4LfdS2niKibwxhy6lffCGn0 OqmXLwXqYGZDG9bD9jwsBtFFESmmbULi8uyxnygL5tAkYaLw/2zzfkSKAE3uBI3ocICfQGrDeAT RBN8hV2fFT3n728Sn0Zg3wyTeDb4JJYW7Ree X-Received: by 2002:a05:620a:191c:b0:7b6:c405:b586 with SMTP id af79cd13be357-7b6fbf19210mr116123585a.8.1734091067021; Fri, 13 Dec 2024 03:57:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQprqSgLBubKgdWWbYTqCPgecNMsXyZimyUAw2EWk/tIKfoQvRq4J7ARIOzuIal/zHJt59kA== X-Received: by 2002:a05:620a:191c:b0:7b6:c405:b586 with SMTP id af79cd13be357-7b6fbf19210mr116121885a.8.1734091066667; Fri, 13 Dec 2024 03:57:46 -0800 (PST) Received: from [192.168.58.241] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa6a59f7bf6sm471226166b.93.2024.12.13.03.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2024 03:57:46 -0800 (PST) Message-ID: <58fefb90-a28b-4460-8837-14186d44ec1a@oss.qualcomm.com> Date: Fri, 13 Dec 2024 12:57:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/14] ASoC: qcom: sm8250: force single channel via RX_1 output for qrb4210 To: Alexey Klimov , Konrad Dybcio , broonie@kernel.org, konradybcio@kernel.org, andersson@kernel.org, srinivas.kandagatla@linaro.org Cc: tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dmitry.baryshkov@linaro.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241212004727.2903846-1-alexey.klimov@linaro.org> <20241212004727.2903846-15-alexey.klimov@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 2h1YHYWECBDAhgGmXR73-BQrA82nXyt2 X-Proofpoint-ORIG-GUID: 2h1YHYWECBDAhgGmXR73-BQrA82nXyt2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 mlxlogscore=650 priorityscore=1501 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412130083 On 13.12.2024 12:54 PM, Alexey Klimov wrote: > On Thu Dec 12, 2024 at 5:22 PM GMT, Konrad Dybcio wrote: >> On 12.12.2024 1:47 AM, Alexey Klimov wrote: >>> In case of mono configurations we need to enforce single channel >>> output. This is required for audio playback on QRB4210 RB2 board >>> since it has only one WSA8815 amplifier. >>> Implement data variant for qrb4210-rb2-sndcard with >>> sm8250_qrb4210_fixup_params() that does that. >>> >>> Cc: Srinivas Kandagatla >>> Signed-off-by: Alexey Klimov >>> --- >> >> Would it not be enough to set channels->min = 1? > > Enough for what or to do what exactly? Enough to make the rest of this patch unnecessary Konrad