mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Trilok Soni <quic_tsoni@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Alex Elder <elder@ieee.org>,
	Arnd Bergmann <arnd@arndb.de>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	Sibi Sankar <quic_sibis@quicinc.com>,
	"Rajendra Nayak" <quic_rjendra@quicinc.com>
Subject: Re: [PATCH V25 0/3] misc: Add driver support for Data Capture and Compare unit(DCC)
Date: Tue, 8 Aug 2023 08:31:46 +0530	[thread overview]
Message-ID: <58ff2350-9e07-36a3-e7a6-f882b292bc35@quicinc.com> (raw)
In-Reply-To: <2023080753-decode-outgoing-b6c6@gregkh>



On 8/7/2023 11:14 PM, Greg Kroah-Hartman wrote:
> On Mon, Aug 07, 2023 at 11:03:45PM +0530, Souradeep Chowdhury wrote:
>>
>>
>> On 8/4/2023 7:19 PM, Greg Kroah-Hartman wrote:
>>> On Fri, Aug 04, 2023 at 03:47:26PM +0200, Greg Kroah-Hartman wrote:
>>>> On Thu, Aug 03, 2023 at 07:35:18AM -0700, Trilok Soni wrote:
>>>>> On 8/3/2023 12:06 AM, Souradeep Chowdhury wrote:
>>>>>>
>>>>>>
>>>>>> On 6/28/2023 3:53 PM, Souradeep Chowdhury wrote:
>>>>>
>>>>> ...
>>>>>
>>>>>>>
>>>>>>> https://git.codelinaro.org/clo/le/platform/vendor/qcom-opensource/tools/-/tree/opensource-tools.lnx.1.0.r176-rel/dcc_parser
>>>>>>>
>>>>>>> Changes in v25
>>>>>>>
>>>>>>> * Updated the documentation of the structure dcc_config_entry as per
>>>>>>> the comments in V23
>>>>>>> * Updated the documentation of the dcc Kconfig definition as per
>>>>>>> comment in V24
>>>>>>> * Used u64 where applicable
>>>>>>> * Removed the mutex locks where it is not needed
>>>>>>> * Removed the use of unlikely keyword
>>>>>>> * Renamed "nr_link_list" to "max_link_list"
>>>>>>>
>>>>>>> Souradeep Chowdhury (3):
>>>>>>>      dt-bindings: misc: qcom,dcc: Add the dtschema
>>>>>>>      misc: dcc: Add driver support for Data Capture and Compare unit(DCC)
>>>>>>>      MAINTAINERS: Add the entry for DCC(Data Capture and Compare) driver
>>>>>>>        support
>>>>>>>
>>>>>>>     Documentation/ABI/testing/debugfs-driver-dcc  |   10 +-
>>>>>>>     .../devicetree/bindings/misc/qcom,dcc.yaml    |   44 +
>>>>>>>     MAINTAINERS                                   |    8 +
>>>>>>>     drivers/misc/Kconfig                          |    8 +
>>>>>>>     drivers/misc/Makefile                         |    1 +
>>>>>>>     drivers/misc/qcom-dcc.c                       | 1312 +++++++++++++++++
>>>>>>>     6 files changed, 1378 insertions(+), 5 deletions(-)
>>>>>>>     create mode 100644 Documentation/devicetree/bindings/misc/qcom,dcc.yaml
>>>>>>>     create mode 100644 drivers/misc/qcom-dcc.c
>>>>>>
>>>>>> Gentle Ping
>>>>>
>>>>> Thank you for the reminder Souradeep. Greg and others, please see if we need
>>>>> any changes here or it can be picked up?
>>>>
>>>> It would help if the code would actually build:
>>>>
>>>> drivers/misc/qcom-dcc.c: In function ‘ready_read’:
>>>> drivers/misc/qcom-dcc.c:853:13: error: unused variable ‘ret’ [-Werror=unused-variable]
>>>>     853 |         int ret = 0;
>>>>         |             ^~~
>>>>
>>>> {sigh}
>>>>
>>>> How in the world was this ever tested?
>>>
>>> Ok, next time I want to see some QCOM engineers to sign off on this that
>>> it was actually tested and they can back it up that this is ready to be
>>> merged.  When the code doesn't even build, that is a huge red flag that
>>> this whole thing is being rushed as it obviously was never tested in the
>>> form that was submitted for inclusion.
>>>
>>> You all know better than this.
>>
>> My apologies on missing out on this, it is a W=1 level compilation warning
>> that got suppressed on a normal kernel build.
> 
> No, not at all, it showed up on my "normal kernel build", I do not have
> "W=1" set at all.
> 
> If you did a simple "make allmodconfig" I am pretty sure it would have
> tripped this.
> 
> How exactly was this tested?

My toolchain interprets this as a W=1 level warning rather than an 
error. So I am able to build the kernel with it. Probably because I
am using an older version. Will correct this in the next version.

> 
> thanks,
> 
> greg k-h

      reply	other threads:[~2023-08-08  3:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28 10:23 Souradeep Chowdhury
2023-06-28 10:23 ` [PATCH V25 1/3] dt-bindings: misc: qcom,dcc: Add the dtschema Souradeep Chowdhury
2023-06-28 11:18   ` Rob Herring
2023-06-28 15:51     ` Rob Herring
2023-06-28 10:23 ` [PATCH V25 2/3] misc: dcc: Add driver support for Data Capture and Compare unit(DCC) Souradeep Chowdhury
2023-06-28 10:23 ` [PATCH V25 3/3] MAINTAINERS: Add the entry for DCC(Data Capture and Compare) driver support Souradeep Chowdhury
2023-07-18  5:03 ` [PATCH V25 0/3] misc: Add driver support for Data Capture and Compare unit(DCC) Souradeep Chowdhury
2023-07-18  5:34   ` Greg Kroah-Hartman
2023-08-03  7:06 ` Souradeep Chowdhury
2023-08-03 14:35   ` Trilok Soni
2023-08-04 13:47     ` Greg Kroah-Hartman
2023-08-04 13:49       ` Greg Kroah-Hartman
2023-08-07 17:33         ` Souradeep Chowdhury
2023-08-07 17:44           ` Greg Kroah-Hartman
2023-08-08  3:01             ` Souradeep Chowdhury [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58ff2350-9e07-36a3-e7a6-f882b292bc35@quicinc.com \
    --to=quic_schowdhu@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=elder@ieee.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=quic_tsoni@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®