From: "Neftin, Sasha" <sasha.neftin@intel.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"Fuxbrumer, Devora" <devora.fuxbrumer@intel.com>,
"Ruinskiy, Dima" <dima.ruinskiy@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Neftin, Sasha" <sasha.neftin@intel.com>
Subject: Re: [PATCH net] net: e1000e: Recover at least in-memory copy of NVM checksum
Date: Mon, 31 Jan 2022 20:10:26 +0200 [thread overview]
Message-ID: <59052a6a-ddbe-fde5-2eab-ce90d958697c@intel.com> (raw)
In-Reply-To: <20220131164105.GA29636@alpha.franken.de>
On 1/31/2022 18:41, Thomas Bogendoerfer wrote:
> On Mon, Jan 31, 2022 at 12:51:07PM +0200, Neftin, Sasha wrote:
>> Hello Thomas,
>> For security reasons starting from the TGL platform SPI controller will be
>> locked for SW access. I've double-checked with our HW architect, not from
>> SPT, from TGP. So, first, we can change the mac type e1000_pch_cnp to
>> e1000_pch_tgp (as fix for initial patch)
>
> ok, that would fix the mentioned bug. Are you sending a patch for that ?
Sure. I will send patch for this and inform you
>
>> Do we want (second) to allow HW initialization with the "wrong" NVM
>> checksum? It could cause unexpected (HW) behavior in the future. Even if you
>> will "recover" check in shadow RAM - there is no guarantee that NVM is good.
>
> sure. Out of curiosity why is the NVM fixup there in the first place ?
It is legacy implementation (many years ago). I believe the 'main idea'
was to allow SW to fix checksum when somehow it was computed wrongly.
(probably recover checksum calculation bug in NVM release process)
>
> Thomas.
>
Sasha
prev parent reply other threads:[~2022-01-31 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 15:08 Thomas Bogendoerfer
2022-01-31 10:51 ` Neftin, Sasha
2022-01-31 16:41 ` Thomas Bogendoerfer
2022-01-31 18:10 ` Neftin, Sasha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59052a6a-ddbe-fde5-2eab-ce90d958697c@intel.com \
--to=sasha.neftin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=devora.fuxbrumer@intel.com \
--cc=dima.ruinskiy@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®