From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753728AbcD1JjX (ORCPT ); Thu, 28 Apr 2016 05:39:23 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:52152 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752650AbcD1JjU (ORCPT ); Thu, 28 Apr 2016 05:39:20 -0400 From: Arnd Bergmann To: linuxppc-dev@lists.ozlabs.org Cc: Rich Felker , linux-arch@vger.kernel.org, a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, deller@gmx.de, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-m68k@vger.kernel.org, geert@linux-m68k.org, Alexandre Belloni Subject: Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly Date: Thu, 28 Apr 2016 11:38:47 +0200 Message-ID: <5905519.cjzepiYx4I@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <2582931.5Q3899gsIm@wuerfel> References: <1461796470-1291527-1-git-send-email-arnd@arndb.de> <20160427232122.GW21636@brightrain.aerifal.cx> <2582931.5Q3899gsIm@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:aS7aDKvYpO5Dy9D5ruzPswq8rGNLcr58SV1rX1rVkhxhxU7ghy2 QKq0ucdqEe+ZNeSD3/klldK7tsI0X5ace/1BSiBGqpnpsefN+5vbdbNWNvL2ncE3sD2Slw1 nyR0uE50+KwKU8kB11Jep6UHs9XUF04suoYjddrvmBgJIxcpEaqBADHaePgm6BKY7/iVQNu /YOGGQ89OjFDL+FLq8xmQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:WSZuJMQr42w=:oVhjD/Rzku71r0ILw/elSD MotkTZWu4ySow+Y6YDEsOEtdgN/jlcnDat1nW7/q8bw/lJ0EvnmSG01v1L+5WAq0S0K03iQOt 2dpOqYxJTMBodSY74ilf808C4IOSYBZKMgKgKVbTwt8Z+m9zi3C6W+QxeiNJRRsqet9RlD1l/ McR61u6zC7WtdK3HgxvDsMb8Zw7Y81aHfXvm6dT/7ZkPQz7aV4uRqMMnXG25774Hr3ahtmzXu tuDJCiNBqyBdtoyAW6Q4Hm6BjDJRiDT7DlCE7RARK+s2erAs0aM7gJN97m/MGkeYojqMkNKjU 4O5L6irHs2LTGHcmfKcmkYv5ZsiO6Njd33rxXQk1Tn+08qk9aPyzuKMTCdQ2SOtCzROTZJXua fjoj+08UbjbChTPaUbEdoZGuoIo76MTAcqlvCfkiPf3KszsBgZ6iyBS6jVRxkbVSQ/9p1dXtf xhSnNpiRhay/4kIUGsbm0t8lkbjczciYBqAMcRDgUCbH9z1vkaEA6OgRLHBsl+CFV5/G19rrF T3Sl6VJDzhMym9KYPAmXmKOAqzwtTsb9LOAdze2/OiDtKbGNO9cMd7FkZW0qbg5ETaS4V/hJx YssyCwlzWtf5T+BUHQRi3aPjED5qnYei41h4cNzpuMDNKgibNa+LcYFbbaqG/05LfgkMdqib1 0OKi1GNsk1NwC6N+AWJUBqxdG2bakVL37XKfLNrrqjL3XH24hvQ3SlICUkUIBXljJYlvBX1G0 0owTKo2Rc7Q4Qpg5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 28 April 2016 11:08:41 Arnd Bergmann wrote: > I only see two of them anyway (dreamcast and sh03), so that should > be easy enough to do. For instance in arch/sh/boards/mach-sh03/rtc.c, > the sh03_time_init() function should register a platform driver, > whose probe function calls devm_rtc_device_register() to register > with the rtc subsystem. Then you move the entire file to drivers/rtc/ > and change the callers of sh03_time_init() to create the device > manually (for the classic board file) or drop it (for DT). Just FYI: Another look at the sh03_rtc_settimeofday function shows that it's always been wrong: unlike the set_mmss() function it calls, it should set all the time fields, not just minutes and seconds. Arnd