From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA9F429AAF7 for ; Mon, 13 Oct 2025 16:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760374696; cv=none; b=alApfYYtPLYkptNPHxI58qzUGSkelR5DBuqINzlJSPGA0rCujDJ5GLYUQktsgmhJytY6kdJQqRWuDJWispYa/X+chT9CFCMyKe9c9FAM+IwXop8D+s5apS1UdW8octB8zBUJFlh3iXxOy1fTAySAXY52F+3EE3/WEsFe0fRsBss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760374696; c=relaxed/simple; bh=aVbLx3zzuiItcIq6jkvMD/Zgek8sd/MbjhMghYBE0P4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TnM4EH7TeztpJJ1E0XQH761qbg2WsJ7jxtfhdANHNPZRmnpgjZIMP5/0gJancP5vygGECldomX0jnah5wIf2xP2Ov6WLv5N0gPOh/7sO9OryUU0nNyzzfKb4DUDe4jH8xUP+vkIgrnVYmvvdtnPgpSa0eLYzW8MHoiWRjFa0nl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M74mFQ9H; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M74mFQ9H" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5797c8612b4so5420410e87.2 for ; Mon, 13 Oct 2025 09:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760374693; x=1760979493; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yugt4TFzKOWVtrp9PcwweappLEqjwwN8AAVbBJj3x48=; b=M74mFQ9HvKukuAyHkZgSoarVInq8g6SVHkIHPYSCFvcdFOtBbcbcTV9eKbDReyG/pp KdIx6qukevvbll49LnzS9pFeCJSWi+xCmLRCDcwb9prvjP4bSnd4UDwzB5srbExk1lxL x6Ink1cLNayjEKBYzdYAvrdxEESaNMvkmRQgDFN5GY4B1rf+KiaiI7A+kHVonyFWCVez +Fpk4WA7G+wwikLP4z49RnQZhQXIcTlo/oQWxlwL3mrXM/6O7MIKLIo5tdZ51Y6vk48v md0bC4aHTnBmdFu6yKm5I9WdA3qqt9bcLHJCcFXERn3shL8P7hWNvhx1xuE8BsHxIom4 z1mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760374693; x=1760979493; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yugt4TFzKOWVtrp9PcwweappLEqjwwN8AAVbBJj3x48=; b=e94ANCyjd4h1OavRt9OSDCt7PHfp/O2txVQV0+Ly2Qa8uUX498MWRa9JBTciy145nb h+zLZzs/4QeNoqjwlQmTq3ayGgEKXnsfTz7pKAC82oBL7D47RO560dcLiPM8grLIb9zn 1PVL9fUBgv7nMmmh1LD2runMBduPvSDHEPEp3kc/Drzz5X54btFMexFW+yTwGPmHL/ho T3hnUVGNpyv+ClV5C3Xj2c5DaakecLs08bEdckn0DW1cCr0BRpP1xwvObVT6DO3zwbAh CjulPhrTN7ARoXWo2pq4NuEqVbnp62mc+/pO2jLSKXINY9D0TmexyGXtFRj5TIvSyUgz 6UmA== X-Forwarded-Encrypted: i=1; AJvYcCU+kYvUd6PKzNAQdpnOfunE+d99E/1O9u4axZvQP11L6454uKxCkycA+fPLCnsRIwyyMKw9FXJnrZyPX/A=@vger.kernel.org X-Gm-Message-State: AOJu0YwAy508WyHBC1f/yuuJRXLiVSgMF0hSUIwo8WA9vL63MQ2w/umj 6C1ekqon2R7neBbEE+cFUrgYAZ1yR0pQaG88YszYPl2Lu5Bp0/bYx68S X-Gm-Gg: ASbGnct1iPctpSz5CL93F0QdqbxVuIkJ9pkq3zgAlRtTz1frTjyWDXJ9hUxlTViWLit ciGLaYI6LoGYSWnEGlbkVc2oaO2ycnDm3sHqr0y/HXFWg5a1F5WcV25BlpoA0ZyGpnsRTI9nvRT B7FvDfMAcUm/MxsIijMRw/kbaa6Lf5nqGU05bJkZBSZP8ccd4TM9MXVL+hveSV7K8BTm518AGqm jU79PQ0IRHmr7Ht2ijRk1VEkSIqWIEtXNWCsqOzdXvUZjKFZWIbdhSWtIi8fW9SDh1XuwXt9Txy JLD/iOd9GPMFryq1/XU+MfGWIK//B23HmFiGpJWUTil2XNw2IExjPC2SrDcVZBR2Mbc6nKXTZai 4LhoYzTNAz9NthSlOzIq7akVangJqRfB+NMGQm3NTfSGioVvwqybPr0l4x7DvVEGAPhMafuIyV6 jN6UyQ7GmWHHW0N34P X-Google-Smtp-Source: AGHT+IEh5FEGdLJk3FY3nXjUAjtDIVpFAFgTlMg4hJ6GlsiA7ZQHpqXBQCJHQ9JSVuB42SxmUqwjGg== X-Received: by 2002:a05:6512:39c3:b0:577:494e:ca63 with SMTP id 2adb3069b0e04-5906d896d59mr5638965e87.12.1760374692389; Mon, 13 Oct 2025 09:58:12 -0700 (PDT) Received: from [192.168.2.19] (109-252-159-193.dynamic.spd-mgts.ru. [109.252.159.193]) by smtp.googlemail.com with ESMTPSA id 2adb3069b0e04-5909413ec6csm3376197e87.48.2025.10.13.09.58.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Oct 2025 09:58:11 -0700 (PDT) Message-ID: <590984a2-633d-4e68-9601-f379bdc2b8fd@gmail.com> Date: Mon, 13 Oct 2025 19:58:10 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] PM / devfreq: tegra30: use min to simplify actmon_cpu_to_emc_rate To: Thorsten Blum , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding , Jonathan Hunter Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251013131825.31400-2-thorsten.blum@linux.dev> From: Dmitry Osipenko Content-Language: en-US In-Reply-To: <20251013131825.31400-2-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 13.10.2025 16:18, Thorsten Blum пишет: > Use min() to improve the readability of actmon_cpu_to_emc_rate() and > remove any unnecessary curly braces. > > Signed-off-by: Thorsten Blum > --- > drivers/devfreq/tegra30-devfreq.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 4a4f0106ab9d..2c9813bd697e 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -326,14 +327,9 @@ static unsigned long actmon_cpu_to_emc_rate(struct tegra_devfreq *tegra, > unsigned int i; > const struct tegra_actmon_emc_ratio *ratio = actmon_emc_ratios; > > - for (i = 0; i < ARRAY_SIZE(actmon_emc_ratios); i++, ratio++) { > - if (cpu_freq >= ratio->cpu_freq) { > - if (ratio->emc_freq >= tegra->max_freq) > - return tegra->max_freq; > - else > - return ratio->emc_freq; > - } > - } > + for (i = 0; i < ARRAY_SIZE(actmon_emc_ratios); i++, ratio++) > + if (cpu_freq >= ratio->cpu_freq) > + return min(ratio->emc_freq, tegra->max_freq); > > return 0; > } Reviewed-by: Dmitry Osipenko