From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDC4B57C9F for ; Tue, 3 Feb 2026 20:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770150731; cv=none; b=U4uJXsxG/MtOIzFi9Zp3xl7PGGBHzVB0ujC4QMg33E2u3Ns6P1fzjwYMQTmi2FK5tooLVC+4cCsioBPdxyQGgMz6XOC31zEoOv38iJaO4UMO2bB9g312k27gZg6GRzO9+9aMeVOLY+xHm3/6vfC600LIXLVkd4JFv0omSohe8gs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770150731; c=relaxed/simple; bh=oRC6tKvvEj9AaBHGot8WNopEmaDChGLIc8MKjI+lHxA=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=U5A8MhcV9kmWQVwpWocYesEWvFSBLNjMi4VmWfSfDBn0LbtQkooLS3Qh/MwHvwmSFNiuFrhkyyHYJahSSBrMjaOi1s76ZvA+XX6yCXB7J28tI6iKuNqd2XqDG2SlTf9v2yC5/msZ0N44J3+XClPBuBxLDeFed8bT6ckQ4NHbg6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CQqPxYS+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=L0i7bd/l; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CQqPxYS+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="L0i7bd/l" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770150727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7L1FzLWR80XL9pfS0ZqYqfha235I3U5glTbWqm/on4Y=; b=CQqPxYS+QLZMMJoheiQxA3RnrTMmyC+rJuGlhcDdWBMY1KUwL7UY6sjh5bpCKzGbcvgjIs LHNUf7dZUMtFr0BZ7DjgaK8I2sJYKiqCS5jaWCJeMteXrkkduAWjl2JDJ2emr6uMlR9eVR I9u5V3vq9PY0eiDTTd4RUKv7tBRx6cE= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-kLcDnNC7Meil9VVbEHgWOw-1; Tue, 03 Feb 2026 15:32:06 -0500 X-MC-Unique: kLcDnNC7Meil9VVbEHgWOw-1 X-Mimecast-MFC-AGG-ID: kLcDnNC7Meil9VVbEHgWOw_1770150726 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5033c483b74so211417731cf.2 for ; Tue, 03 Feb 2026 12:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770150726; x=1770755526; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=7L1FzLWR80XL9pfS0ZqYqfha235I3U5glTbWqm/on4Y=; b=L0i7bd/lXYNx7f1XzRy5E1OqisxhFSzER9oWh7/LZ0Ohn9n1yGSILrftB5kY55tlaP bdBkANBe25fCqMfFyclNiNItRRRK/c3OByaWgL/fjhknl6f+GFvsMPZs0IxpdBUcLVgq wrMZVDJLTVfxPVKttSWOSNQLPJnd/bakHNRP6/H9VYc7nl8o7rUoj0B+lx1qGP4Fd3XH +AQOIwZCItuHUS8pwCIlW0A3tKNgoEe8p6wqv1b4DjopYNzqDFE3l2KtMkHnz3ARp8ws ow03PN07NbLY/SbGU0xW0aytnBL3poLE5sV8I74xCW/sJ7m/+1lSBMQUi+DYDldaFfgY fftg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770150726; x=1770755526; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7L1FzLWR80XL9pfS0ZqYqfha235I3U5glTbWqm/on4Y=; b=vk9mMOLc3bH8ufV0VY31QF1TV24lecZC1bnE53s0urXHPrcSRGrlA+a0APxJVdZ94X 0FySbxRTJxbrwxCx+u/6y5kFUyUz6d4Sq5sO6WDWmuaIO7qUBOF+2poP2Tn+2tA7gftT 4ju6WjPQMcQtvqO/MrJxD+DdD4iXpXrQzFAaQQaYYohxkh8w7L2BU4p6XPg5RbR8HAcZ AHToZpcWzuPeRMFr+sL/HXwGKfMoa6Rap8s+8cKoawZxFsjHTNdA2E/pH2Z9XJojFC/t +Y4VYAlP8H7YyxNx0WK6mJE8StYaHuOmcXv704Px4rwSGTADrrqa2pXrhHOF1mTMs+TH UUEg== X-Forwarded-Encrypted: i=1; AJvYcCUIAXvaVa1sDJzkqbFpQNdsMCwJMcuUAQFEZ56pEF0PGxjJuFXqncNZUjXCTxGdCFAqzc3JNuNcHLZuEdI=@vger.kernel.org X-Gm-Message-State: AOJu0YwyNoDVKoJhgFbQquLxot6y1sl3jqEkpOkIliRJbHbJDi3L/cAm kYfTjnY/C8ould3pRK9V2PB3Bw6duFQmn3pWe16833lGcRbpw8U4XdqP9LFyTns/Dfsj6eL+RUB xt1Dhuj2UDP1sDHskkjJMs8Jmzr68pHM77/vJL2KHEPXg9Fv7DmxOz7joVYW/eIkAtQ== X-Gm-Gg: AZuq6aIyhPP57PLBgd3CHV/ToHIUn/c2PUxWqllYbCDv+UYFQfY1wSWzwZZQNBUff/d xGV5S34enrpzLbzEtDFKnD8i2/PZiiDMh7sQOINFfXuZVD0zwSTStzIJR7GjV/ec8qD99msMsu0 lp5WBjVZy0UBta/F5JmKOiKVft1+Rw9i5IPPdBZ2Fr75+GyvtuMA/urQIN5q+dOnBg/P+SFPvLf SulSianFtM4soXna1DSU1xzP3l57CeXzrw2gn6yg8nJRChguLaTlEDhYvtzk55J6M1Wh9H4GdR8 CEJ0CVVlL1VqEsWOZYHWcDkpMryeP/Lvhw+VuoJmSvbe1MbpDwhH0heC7sRA/+cPao6vBHNshjR +L1UGikbapLOJi/t1NLoa+mk5rG4e+wy91gu+XYh85qrXIWgyRDkQzT88 X-Received: by 2002:a05:622a:1809:b0:4ee:ce3:6c9d with SMTP id d75a77b69052e-5061c0cb0b2mr9458281cf.19.1770150726177; Tue, 03 Feb 2026 12:32:06 -0800 (PST) X-Received: by 2002:a05:622a:1809:b0:4ee:ce3:6c9d with SMTP id d75a77b69052e-5061c0cb0b2mr9457911cf.19.1770150725770; Tue, 03 Feb 2026 12:32:05 -0800 (PST) Received: from ?IPV6:2601:188:c102:b180:1f8b:71d0:77b1:1f6e? ([2601:188:c102:b180:1f8b:71d0:77b1:1f6e]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5061c1f7764sm3057731cf.23.2026.02.03.12.32.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 12:32:05 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <590a36e6-8d11-411a-8fcd-d93eef96f0e9@redhat.com> Date: Tue, 3 Feb 2026 15:32:04 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] audit: Avoid excessive dput/dget in audit_context setup and reset paths To: Al Viro Cc: Paul Moore , Eric Paris , Christian Brauner , linux-kernel@vger.kernel.org, audit@vger.kernel.org, Richard Guy Briggs , Ricardo Robaina References: <20260203194433.1738162-1-longman@redhat.com> <20260203200505.GH3183987@ZenIV> Content-Language: en-US In-Reply-To: <20260203200505.GH3183987@ZenIV> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/3/26 3:05 PM, Al Viro wrote: > On Tue, Feb 03, 2026 at 02:44:33PM -0500, Waiman Long wrote: > >> diff --git a/kernel/audit.h b/kernel/audit.h >> index 7c401729e21b..03f3539b10e7 100644 >> --- a/kernel/audit.h >> +++ b/kernel/audit.h >> @@ -133,6 +133,13 @@ struct audit_context { >> int name_count; /* total records in names_list */ >> struct list_head names_list; /* struct audit_names->list anchor */ >> char *filterkey; /* key for rule that triggered record */ >> + /* >> + * pwd_reset is set if audit_free_names() has been called from >> + * audit_reset_context() to reset pwd, but pwd is still holding dentry >> + * and mount references to be used in later audit action without >> + * the need to reacqure the references again. > That's a delicate way to say "we have mounts stuck busy inexplicably for userland"... > > Generally a chdir(2) away from something immediately followed by umount(2) > is _not_ expected to leave you with -EBUSY when nobody else has been doing > anything with the mount in question. That is actually a concern that I have at the back of my mind. I can modify the patch to cache only the dentry and do get/put the mount every time which is much cheaper as it is a percpu counter.  In that way, a chdir(2) followed by a umount(2) shouldn't cause a -EBUSY. Right? Cheers, Longman