From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>,
gregkh@linuxfoundation.org
Cc: f3sch.git@outlook.com, guozihua@huawei.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: rtl8192e: removes blank line
Date: Mon, 19 Sep 2022 20:41:23 +0200 [thread overview]
Message-ID: <590b49c9-5940-c7e6-0a23-9a82cd06fe62@gmail.com> (raw)
In-Reply-To: <20220919135812.8307-1-aruna.hewapathirane@gmail.com>
On 9/19/22 15:58, Aruna Hewapathirane wrote:
> This patch fixes a checkpatch CHECK issue
> CHECK: Please don't use multiple blank lines
>
> Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_tx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> index d5275319a486..f651947f6b44 100644
> --- a/drivers/staging/rtl8192e/rtllib_tx.c
> +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> tcb_desc->bTxDisableRateFallBack = 1;
> }
>
> -
> tcb_desc->RATRIndex = 7;
> tcb_desc->bTxUseDriverAssingedRate = 1;
> tcb_desc->bdhcp = 1;
Please avoid the 2/2 in the subject. This is only for patch series.
Create a version 2 of this patch with change history.
Removing blank lines is OK but do this for the entire document.
Add the file name to the subject to make it more unique.
Bye Philipp
next prev parent reply other threads:[~2022-09-19 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 13:58 Aruna Hewapathirane
2022-09-19 18:41 ` Philipp Hortmann [this message]
2022-09-19 19:19 ` Aruna Hewapathirane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590b49c9-5940-c7e6-0a23-9a82cd06fe62@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=aruna.hewapathirane@gmail.com \
--cc=f3sch.git@outlook.com \
--cc=gregkh@linuxfoundation.org \
--cc=guozihua@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®