From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A20B83254BD for ; Tue, 17 Mar 2026 19:56:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773777413; cv=none; b=CB9eO9ZWkAfmrLxjPYX94NZnpUe0fEc02DiYPautOoaYC+XDfhCDGTLncF29hhN9KMpsETwqzo01nAm+baxDit3a9WHTAT+w46bfakUFmKeTtWH8wPaBrbksBmh5c6IFROIlopPqbN9lRYlZJFbKK9kSIIG4LjK2ODcwztP0T7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773777413; c=relaxed/simple; bh=RZFowPYUESiibPxWRP4NMC4TEnD6R7vXnlpLW8RE78c=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=cpbWw9cXd1bD45tuhAKWnwKz2OrY25rTJmtyTlBrkCFV9egmnkV/NpFWY6BRF76K2k69MPKnMlVvA75HziFodXp+BvuKux0sap4IjAI5Zm5n9Dh3xSiDbx4VP8va8Psl0acm/BmDMTtQvFCxZsW9MCHGAUpxaCa6Xs7e9d5MSdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TuqUmtpT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VXRMtEAt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TuqUmtpT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VXRMtEAt" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62HIJ4vI932160 for ; Tue, 17 Mar 2026 19:56:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IeS4hxC8319lSQFxxoFaZtPyHqXWAr9xldzigTn77kI=; b=TuqUmtpT3LJ0teaQ Z39Okd6PgIrK4fL58yh5eCtwG8Kc7hFymr00Gl6p0RVnTC0+2e/wbm8xLchhYqcd kqEa3apWooVDtcBOT2NiHHYCk28hRhd7w1BSzEeoFjBWJ67XYI6ynI5hEYNBIvAC xGF3FJ9agy4YxeD9D5WSx9nAhFR11L1Pdmet85eYnqN44ieJlGT4u2BaomwQKDHK WO9/gAxYhQRVSNYDKv37v4WqCrciJ7menEYmZg4AZ6dCO/OcUb2uldqAAJ70GOA5 35WwHdRYnL0F+6b7HiH+1o49w54cOCRe7cJothSWNXBTIvsFv08xwiIBSR/9YG8H ifxAog== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy9jr148v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 19:56:51 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd7a25c5a9so750847885a.2 for ; Tue, 17 Mar 2026 12:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773777411; x=1774382211; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=IeS4hxC8319lSQFxxoFaZtPyHqXWAr9xldzigTn77kI=; b=VXRMtEAtzlO7vDRvpOwZ/O7X/jd4pjwDNWIXaEdjbZTAtsxq/p+/+PZL5RlCyEuD9/ o4o1JR2UaO6juJ2hFGh8KXZU4U1lX6FVgbhjgt8qX3KPoIDgrlnvqK8j8Lk2Bv0Qu3sZ Oa5BUgrvcQ8iCuzjGKKCNBLaaZjETKTUrOrCE0ODW3JR2XJ5tUWwS1ZtDOwLyvwdFAYz Cspkm5xE7VT4qr6n2xZb/R4XilIFBNDPaO1jzu5DOJIRnwZ9fkDDB/E57/3zRulyzreW D/4YdS4eYDnxh4LnhFd4Qpk7MkXsGE97AEc6bqR8Kb9dzXf4jpDCh8827viHQkF52yAb KpLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773777411; x=1774382211; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IeS4hxC8319lSQFxxoFaZtPyHqXWAr9xldzigTn77kI=; b=bZlT/PkU3Oq6qgbsdS2TcarLfHKkBUIfTNrLyKITPZVMgJcCqqxtZycFFP0E+QBd5n WNg8H3ouHofnQZnrnh8dO3SLM21Co/ZzMgzl+EUXtp4/UcYdMpc5K3Bcm+IPd7r589HY TVL8UAhySP2c8ye+0YHpcuQ+b4VMI+Ub0rI4t6E5az3N3RamJwc43Uih7IPyR4w5Emam Nu5396ELZ0uNGcF88nPrPTjuXsHYCcw9pDa3esMyykyeaYJLtZEHGIybbdFEZvVSrvPk 4ylAdtwb8LoY08qtqktqRpq6nYYEAWHLxKMUFrlRu2NW0IqLWd4Ssnntg8qYLlPB+s5d 0NpA== X-Forwarded-Encrypted: i=1; AJvYcCWO4EERCxItEX0lEeshpX8VFf24dI7s0nbb9jUghqltWg3D2VN8SH2Czx4idZjOGGkLcHtr0LPEgm87XKk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn65MHBBxv2JBbdfXnywyMysJ4NqhjF2OMFHccyQIq/hViBRnr dZTSAqg4onn0HxJTT3WPvoXeNuQh1ywLux9fYb0mOugPGfExgejhR/d96Rlo6y3hQ2DHeVjJha1 7qp1H/k6N1ECMDc52lY8eztFdad3REQpbQpw3GMdNMmqC0J+VpEL7HwTBZv1SYCJrzUA= X-Gm-Gg: ATEYQzx1Bxoepbh55us3wADCOf0xYRtbGhu4jvdJ2rbHSdw66KvNdjMGoWgpWDiRe2o RCxQQ4LmD9N2/faA32wFATQAlv50PTnNq9uMAcfQfs/6p91Hy2s8Ib6Jq3BeZzlrHoS5ArOaSST U9CmgqwETENMH0CnUvcO8EufVCFx5QoYvo4vwxGKRIRhVigDiYCVfWgJYhn6kbWi6gABBfH7u3J HBITzaEcLYki08Xnc51K1l/0hFp87+I/+Q3YDEpSOZalOFOVB1QboHRT1apwx3V9Jqdb3lLsHBs 3zEGIEbOgdF3svk+QgmdUEpSgEr8y/FgOU47nFKjHQHz8P1/kE+sje5SaCAc8Lb6gfuyQxD5a8N V6f548wY7JkhK6nzenIQX8b+i+fAMsDBnBSMZFFVQ7i4VgWOJoZKbydHWOFFi2Fo39Rygf98GnA Ufl9E35UNXHQ/LdpUlp6q2/Js9R2srEfvSgHMmIkSYwN/3Hz26DiiOalOA+tmoVqm5aS4iPEgjQ A34NC516PyK/5up X-Received: by 2002:a05:620a:288d:b0:8c7:1118:c514 with SMTP id af79cd13be357-8cfad25fb39mr134034985a.17.1773777410803; Tue, 17 Mar 2026 12:56:50 -0700 (PDT) X-Received: by 2002:a05:620a:288d:b0:8c7:1118:c514 with SMTP id af79cd13be357-8cfad25fb39mr134032185a.17.1773777410308; Tue, 17 Mar 2026 12:56:50 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f173c126sm43585966b.60.2026.03.17.12.56.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 12:56:48 -0700 (PDT) Message-ID: <590df779-96a2-4dc2-97b0-0f8753bd7eda@oss.qualcomm.com> Date: Tue, 17 Mar 2026 20:56:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans de Goede Subject: Re: [PATCH v11] media: Add t4ka3 camera sensor driver To: Sakari Ailus Cc: Kate Hsuan , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede References: <20260316085704.352669-1-hpa@redhat.com> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: cXNruEpNapq7mSoEiq1sgCnOEKMIEBUm X-Proofpoint-ORIG-GUID: cXNruEpNapq7mSoEiq1sgCnOEKMIEBUm X-Authority-Analysis: v=2.4 cv=NdjrFmD4 c=1 sm=1 tr=0 ts=69b9b203 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=H8hvct5z2yXf_VyKGFsA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDE3NiBTYWx0ZWRfX9zLVAb1b4sy4 G5eIdnks1aLGVfzq6OXyS/5uJQ90Fgx1vuWTMB57Oce2KH3NTAv21JEkx+HI/QiYjtFm0tIoGkh b+CgV2MTGFBlDPhVmj1if4ecIdwjRbeC0CAPpSEV0TYAHr3jDlagUFc7rNNyMmouKVyyvuXQva1 LOT68jo5uZXpV4UhZoZAHzuDU9LalfA1NNhaXKK6ZyjKLY1dimvKIHm9vWmmMz5i4KSZKs+af51 DXCyX3lfUedsQn/HMeTKgCx/ATMi30dWDDTbujEysuxSqJHO5gdTB26bAgao4cBO6KsEWofrZUM j5LDxcOOqRwvL0Q4YVAy7kT5i3ZjEXL5EgfhaO5sJ6CNVX5/OyUN+okfeo/RFAwbpIolMQ2zjbp hluJI4D+0xGgiooj75a7+SbLY7Stcnv/nxQIfHj6lt5rtzGTT4OR1GcD5wYfsSEpAS/jTJ7sNIX V4Jw/7H32w4A93L+e+Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_04,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 impostorscore=0 malwarescore=0 suspectscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170176 Hi, On 17-Mar-26 18:58, Sakari Ailus wrote: ... >>>> + >>>> + /* Only apply changes to the controls if the device is powered up */ >>>> + if (!pm_runtime_get_if_in_use(sensor->sd.dev)) { >>>> + t4ka3_set_bayer_order(sensor, fmt); >>> >>> Does this call belong here? >> >> Yes, if the hflip/vflip controls change then fmt->code needs to be >> updated to the now changed bayer-order. t4ka3_set_bayer_order() >> uses the cached ctrl->val values so it is cheap enough to >> always do this instead of checking if the changed ctrl is >> vflip or hflip. >> >> In case the sensor is actually streaming and we don't hit this path, >> the t4ka3_t_vflip()helper will return -EBUSY since changing >> the active fmt while streaming is not a good idea. > > This should also apply to non-active state (albeit implementation requires > implementing get_fmt locally). This will get "fixed" with the metadata > series eventually with generic raw formats. Ok, so what you are saying is that given the special need to set fmt->code based on the flip ctrl values, this driver should not use v4l2_subdev_get_fmt directly, but instead it should provide its own subdev_get_fmt() which wraps v4l2_subdev_get_fmt() overriding fmt->code based on the flip settings before returning it ? Do I have that right ? Regards, Hans