From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B672C433FF for ; Tue, 6 Aug 2019 05:26:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 602BA20665 for ; Tue, 6 Aug 2019 05:26:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731764AbfHFF0a (ORCPT ); Tue, 6 Aug 2019 01:26:30 -0400 Received: from gate.crashing.org ([63.228.1.57]:49622 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbfHFF0a (ORCPT ); Tue, 6 Aug 2019 01:26:30 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x765Q3Pp016845; Tue, 6 Aug 2019 00:26:04 -0500 Message-ID: <590ea33755f29ffd8549a4681b9ad9f041fc506a.camel@kernel.crashing.org> Subject: Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers From: Benjamin Herrenschmidt To: Sagi Grimberg , Keith Busch Cc: Damien Le Moal , linux-kernel@vger.kernel.org, Paul Pawlowski , Jens Axboe , Minwoo Im , linux-nvme@lists.infradead.org, Keith Busch , Christoph Hellwig Date: Tue, 06 Aug 2019 15:26:03 +1000 In-Reply-To: <40a6acc2-beae-3e36-ca20-af5801038a1e@grimberg.me> References: <20190730153044.GA13948@localhost.localdomain> <2030a028664a9af9e96fffca3ab352faf1f739e5.camel@kernel.crashing.org> <6290507e1b2830b1729fc858cd5c20b85d092728.camel@kernel.crashing.org> <20190805134907.GC18647@localhost.localdomain> <40a6acc2-beae-3e36-ca20-af5801038a1e@grimberg.me> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-08-05 at 11:27 -0700, Sagi Grimberg wrote: > > > Ping ? I had another look today and I don't feel like mucking > > > around > > > with all the AQ size logic, AEN magic tag etc... just for that > > > sake of > > > that Apple gunk. I'm happy to have it give up IO tags, it doesn't > > > seem > > > to make much of a difference in practice anyway. > > > > > > But if you feel strongly about it, then I'll implement the > > > "proper" way > > > sometimes this week, adding a way to shrink the AQ down to > > > something > > > like 3 (one admin request, one async event (AEN), and the empty > > > slot) > > > by making a bunch of the constants involved variables instead. > > > > I don't feel too strongly about it. I think your patch is fine, so > > > > Acked-by: Keith Busch > > Should we pick this up for 5.3-rc? Well, if you are talking about just this patch, it's not needed unless you also merge the rest of the Apple T2 support patches, which some people I'm sure would like but I think Christoph is a bit cold feet about (I don't care either way). If you are talking about the whole series, give me a day or two to respin with the added check that Keith requested (I believe his ack is for a respin with the check so setting the IO queue too small doesn't kill the driver). Cheers, Ben.