From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9020C83000 for ; Wed, 29 Apr 2020 15:37:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75C3B2073E for ; Wed, 29 Apr 2020 15:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588174648; bh=OC/uuBry5MdIo9PpQACpMz2esvnupqKlJxtQqhDFs7I=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=Oc50gkJhahBflfO7RE1FmcDj0w9ngXBNGFKDQRLxX+WQ0YcmYVKdGj0OxEj+uBLOP oAawz9OexzvnWZfl0H5ljsTZtVWoja+WUmge7rl7HXwqLHYN73FS85edUaS8sUyr1Z aEXL3QopuVruU6QbZBrGz9dMEjGkt0t2G0yXT+Vk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbgD2Ph1 (ORCPT ); Wed, 29 Apr 2020 11:37:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:56902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726456AbgD2Ph1 (ORCPT ); Wed, 29 Apr 2020 11:37:27 -0400 Received: from tleilax.poochiereds.net (68-20-15-154.lightspeed.rlghnc.sbcglobal.net [68.20.15.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C4B5206F0; Wed, 29 Apr 2020 15:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588174647; bh=OC/uuBry5MdIo9PpQACpMz2esvnupqKlJxtQqhDFs7I=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=hC/poJiU62MLjpG2Eb7UzqyClM21ktkHjXXUTqANwMhgAZ6imhdwolsLl1CoYYafR RVkWZyH0JNJmhEvjL2wOxfe0kPAJ85NTi1en9Kghb+R2miMtWserT85WcD1Riis999 zxUzOy04iwTXsSChHZfXUZswXEc6saoeCpBTwIL4= Message-ID: <591b050483a0326bbcaf075254a69bfefc77550f.camel@kernel.org> Subject: Re: [PATCH] fs/ceph:fix speical error code in ceph_try_get_caps() From: Jeff Layton To: Wu Bo , sage@redhat.com, idryomov@gmail.com Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, liuzhiqiang26@huawei.com, linfeilong@huawei.com Date: Wed, 29 Apr 2020 11:37:25 -0400 In-Reply-To: <1588125715-188363-1-git-send-email-wubo40@huawei.com> References: <1588125715-188363-1-git-send-email-wubo40@huawei.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.1 (3.36.1-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-04-29 at 10:01 +0800, Wu Bo wrote: > There are 3 speical error codes: -EAGAIN/-EFBIG/-ESTALE. > After call try_get_cap_refs function, judge the same > error code -EAGAIN twice. So corrected the error code of judgment > from -EAGAIN to -ESTAE. > > Signed-off-by: Wu Bo > --- > fs/ceph/caps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c > index 185db76..1a8e20e 100644 > --- a/fs/ceph/caps.c > +++ b/fs/ceph/caps.c > @@ -2749,7 +2749,7 @@ int ceph_try_get_caps(struct inode *inode, int need, int want, > > ret = try_get_cap_refs(inode, need, want, 0, flags, got); > /* three special error codes */ > - if (ret == -EAGAIN || ret == -EFBIG || ret == -EAGAIN) > + if (ret == -EAGAIN || ret == -EFBIG || ret == -ESTALE) > ret = 0; > return ret; > } Good catch! Merged into testing branch. -- Jeff Layton