From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933613AbcIFJBZ (ORCPT ); Tue, 6 Sep 2016 05:01:25 -0400 Received: from mail-by2nam03on0058.outbound.protection.outlook.com ([104.47.42.58]:63942 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932370AbcIFJBS (ORCPT ); Tue, 6 Sep 2016 05:01:18 -0400 X-Greylist: delayed 1991 seconds by postgrey-1.27 at vger.kernel.org; Tue, 06 Sep 2016 05:01:17 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/amd/powerplay/fiji: mark symbols static where possible To: Baoyou Xie , , , , , , , References: <1473142588-28453-1-git-send-email-baoyou.xie@linaro.org> CC: , , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <591bf6f2-d9a1-dc31-82f1-a3ecfd15e6ba@amd.com> Date: Tue, 6 Sep 2016 10:27:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473142588-28453-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:cdef:727e:e4d4:7ce3] X-ClientProxiedBy: HE1PR03CA0003.eurprd03.prod.outlook.com (10.163.170.141) To DM5PR12MB1306.namprd12.prod.outlook.com (10.168.237.149) X-MS-Office365-Filtering-Correlation-Id: 2d53cd0f-e5d2-4a36-a251-08d3d62fb82f X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;2:0N8/VoxARjjnRzE5yGHHB5hstCaiWmE0zeL/8gCZuS+mpt7IlAm8Due5E2D2DGvRli7FHWDi42cOZuXGzH7uedITTvXYMh5ZoL4aXhykn1stfsfs1HRWwgLXaPEqVZDQ9IWcSHET9rvnUR15hZ2RqDcAVHftmPPmj5eifbyOLfZmB+xZy/ZOe/7A9sfVqCSa;3:eYon794cZvi9a25r5E1QwPIZCerQfqO4NcDgKd8QRO6IdnMfa6guFdDFXH3I6QERDCPk/xXfI9nRcm86USqd7GHg8bLSF5jIr0yXeUNI/VGx69XSOlcLPwJukvPq1NaM;25:2NS+Xgu1GXqmUaVFm6k5GdoZHiI8ZiJQ5stkXKaDct3YlQuIuJ/BzONPWLVlM97f/XAchwCAMqD2MvlWiVsruccI9hr/l1yyJqFNYE8QMKP/mQVdfUeiV/rF6G1I2Wp3ut4iUBtZDbrwNapxhDfAhThYodvmkH25RiKJiH4mz5C/OWnsYThAwUFfkO4YprkeF4YUY25Ri4zD61eFbrnIm+icisS0JQn6gjre+01Tfo2EUg5IYxVyZvJGcFs3nGojPgmP+zmtaLAKzwE+m0xdwMudTlKsAvVO8tUBTJbCbwKl7OqFAXoBU53scAYdW/mCYnnyyPWpUQhqddf5TYuyzZqkOiqlKk1XkS3U9uws3A+Y2J2qmBWu/XgABvOp370b+bdjBsmqISQYKas9guM5ZAnNBXD2jrGPcVF7ttCpmiU= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1306; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;31:g4srf48iGP7WjmKaXWN9oCSSL2pvqQHjk/32Fyw/38ndnAgAhXEX5M1X7GULiDbvAWTotca5vqKDDj5o0x34zTPvFyzrkbrIuBleV2zhM5CR7Qca0n4riXTmawinAvBEO9cfo9buWYmcxIaUPKbSy5unIrxBIIMmrXXQdES4lspi6tBvWbcALEa9cjXkMfuKowU6Mp+U2N3NWiAiZcy8gWgRFK7jM40eXV5WFgWRWec=;20:4dGUisYF/dXUl/OTzkrBMdb3uS6w72zKvvPoJ0l6tZNej/FWFw1v+XULKSNE1YKJ9YLxDnS/sAihmE0hjfb4Cq4VzE+ekDoxpDGYRAWjgm5sBC18krDAX3Ky9XuacuD4XzPVeV3vh/CiIggT6gZd2MmcHu4ODnVONoJv2TQ+uiUJ3KGbypwSc7s6WwwFxY+fCl6HwSeu5GbVCMq41sYmur9jNE8HekcYNzdMOt7Q45NFTBVWnDFxP+4MR3Subvcl7iAiaXEpGmoRIbi7ekpqqk/Cu5zqA/JKC0v6Ya8EXQk+RqAHHR1wxo+yFUO5S8Y5wwKqmh9dNYu/AUfjJ8vA4OhAAm/Ot6Hz/tiQzzivZbDxMLGSrVFz26N3/+k2iHRSS7zTXq+iROMiPwZuaSXx2jaqKUewnx+Z0AP7PryL2Cy/wC426FA5axK4jarMbaSjiAPY6pkhtl2Qi5aZsZEX21NJ/ELwWa46ltvLLLh2WyibbhSgOwZFGDW9pL68EQ2G X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:DM5PR12MB1306;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1306; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;4:3Gc8i5Eee1incowmpD05R/qYB/9xJ35l7s74bf9jeydYVA2uxwaZ+/7phstyXjnzaS0ZtjzOoOHEYy3ptNdzrNS4O4O6rtrRZsgnCsX7eKJymac04ogTUgPu6q3HnwFQHovozj30hAElPyMmKneYf996Qj3w5jRcuJWM/grK1GGTzioneonZAgOOU/BSEcu8axUUe4oHkm3RW4t7WL09bBVUlfJmkXViwuCRITYhJFG35lozlm705moTkfDrulpgosmkzXWclhnDOIOf3Frnva+zP5CdLTvAwyYrA8opxlXy2gVIJZ+ZoVC2vg3Ly2wkD1CUcyziqs8CFnc/HmiOcq7ZG88QgvZzzB52bc38C/X4sYmc0KTLPJfgW8RIql07gUCZ1oxrO/X3hct0ONDx6WAMj2E97sGeEImzywW+tYQZ4UTrey/g2cE9NVFuuAMk X-Forefront-PRVS: 0057EE387C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(64126003)(23756003)(50466002)(83506001)(189998001)(54356999)(76176999)(97736004)(5001770100001)(106356001)(50986999)(101416001)(105586002)(19580405001)(42186005)(19580395003)(2870700001)(33646002)(4326007)(31696002)(86362001)(2906002)(4001350100001)(31686004)(2201001)(77096005)(36756003)(68736007)(92566002)(47776003)(65806001)(65956001)(305945005)(2950100001)(586003)(1706002)(81166006)(5660300001)(81156014)(8676002)(7736002)(6116002)(7846002)(65826007)(3826002)(2101003)(19627235001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1306;H:[IPv6:2a02:908:1251:7981:cdef:727e:e4d4:7ce3];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;DM5PR12MB1306;23:F7f+54LV74DZ9OAhBJ4+rSg/i5W7N6DtofTveT?= =?iso-8859-15?Q?xSqgUXfkFjt9DqM+eR7a2HLHg8V0izK4TgOYPJTq5ClRXe8QCy3YEZOai?= =?iso-8859-15?Q?gGidAk1S2y6elt/B5Q27nUJy1Hix2fub7/+stWOJkY+KJ7LSNo9yU2bj/?= =?iso-8859-15?Q?Ql1nEEDHTfJNRPqZGqXNaB+PI5gHeyJmWvbglrZKWIxTb//KzQM9sIknE?= =?iso-8859-15?Q?6+y3BVJjwuIO1IbhSZIYR7JpdHg6O+er91k/8Rxrl6TfJX1vNIbVqRw8Z?= =?iso-8859-15?Q?fGmT5HVL07lEkKhnkgjEuF3GlZ1BKOQGDgPIF6yyAXV430vKVLrD3t4kX?= =?iso-8859-15?Q?5/Ei6BOEmBs9v2Hrzj1uy+jD9vjJgJmBnQSnghWBHTl8JrxdgxqcFx5gN?= =?iso-8859-15?Q?yLCsOfjMI0k4w/nd+MYLWxUBcFVVAwlGCszpLL50OwjgIr0psuTPc0wpj?= =?iso-8859-15?Q?UR6t82l0GZ/85glgL6Y6efGULpPm2xaPaiagoahLO3JohP68fnYnq/kHB?= =?iso-8859-15?Q?imB9AcNkYPNT00XKNx7qDOzSH34iIRSWlfee8QefngTl4Id66jQPDMtnQ?= =?iso-8859-15?Q?MLNK5juBE8TmprN0Zk0yCtsyEC324brw1uDAtR7K4fgucLgDb37Zy22me?= =?iso-8859-15?Q?GxsJK/Id1Z4cSRyuXq9FbM0QChmI+YwtPu2KtT1FwivXOiFCku6Kor/Ef?= =?iso-8859-15?Q?ftYD4DgE9u2UiDUXrnWFhBLPI9Xq50tv8SAcul6BdsNhc9YAL1N4B6K9C?= =?iso-8859-15?Q?3EPq6EGMTD96RE+EHuT4nFyl6FiBIS6Q70nAwv9hwGQ6Ko861b0qClxy7?= =?iso-8859-15?Q?fPGT9H7qyYxGtv/u1N5yv+nu8PclhLG1E7mDqwobT6JKI2F69gVUZkXGx?= =?iso-8859-15?Q?ErynGZd81vogTP/bB8iuHqAuUwliyIHQsaWm4a0NRS7G8V8U5S6PRho45?= =?iso-8859-15?Q?vDjROTwaQEZDhhQlYdXFdXiVWeY/xgQzSNqXWdZ+pUFMd29xgJEfYYhpi?= =?iso-8859-15?Q?zQ7+ucDbtlg/Yg48609uDilwFzy9/28JRFeB60nnwuP2qRxirWnzY8wye?= =?iso-8859-15?Q?A7xRsmV49d2DkG+EHO0MY+4Pr/oPgyozqLI8V3Cb78gBKKkO7fUfclkkV?= =?iso-8859-15?Q?kcQR8t+RoQqqnXyiAfDSMIFsDZo/ozPvfPqqdmOHwqEQtipytQac0E225?= =?iso-8859-15?Q?Z2MbZFh6ipkGA7gWGz7lBlY7PHDO79YA2HW0XPJcJ34PCTViomb217rFu?= =?iso-8859-15?Q?AlWxEWNStoUXbpk8NDVaoKHuwYVm+0XrdL7XLaDatrM3zwH1HJj1GkMRt?= =?iso-8859-15?Q?p0kanbAi8kNezK0yxPrr8p7wYaIZh04ii+KSrSLXeXBANWtcO5K+/4t72?= =?iso-8859-15?Q?VJrpdBKHXw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;6:hGkTV9bgyeAWuIX562D5fojTruonfkX8LOUrW9BYL60anGU/EWJqgCFQAaVVPsCC+vmrNEttwVabATrdo+9h3GvwdmuIrjsj5yrcyQ0c0JSpopbihr49w2raQW6B6vlEOjItuwk8U00m1y12Mk2kzSelpqAUIZ5dcKF+SRuV5VY3nxcIpVrGyKM85sVtDGCSgW0+0R5DB1vaqXmcdg6NsnoDW/M5NNzNXda8+8o0CnNoW6AOhurOOx+3DMv9vVWgOrpvj04Rb5hXRYrNty/duKGx/68HQ2FLACuT77LZZuHtfmuE+tuUnYLCG2N3YDvewmIlGiUyEwQjNYnoEz8fwA==;5:1NBOwXu4Ilpu9emuM1w79lfqItlCbkSXGjVO//caMlCJ9z2RH96hczt7mW1VDjhAJhQaH/nfWmDKIcR9LA4kLEe4Bcj5VjYvm9YPS77ZjGWU+8eUk0RJmnbjw+XvsbOsiforbPr5aggOBv2elBMdwg==;24:aD71S/btWRD5Oc6L7aVzEac5RWcYOpRtvb3i5sWUGhdDaOStYQXndv14YC/g26+F20DHaFXMh/b2wthtM/DVPxAyEvZTjE8KneDfLpWh38Q=;7:HCpeXme0D6S7bXxorBF+exvUuxNDfZzL2ro9FOLmOEcPdUMx4OaTNM+PkbODGDEVrvko6ruGD36udmU13ZG9zqBegdCNuq+R0sm4FTRN5WBwYdIBJ8Nq8ozK2xHbwDKvspspEAE6RWNV43Wv+7J3I7sBQs03wpuXQ1yFGGK9CKPeKJvjriO3GBNBDvxSSXLbZfZThuBPCW7hfP5SPzIrG8T7oe4eujrXX9Bv0VfhtRmROybXZpN+FKBjefpd35FJ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;20:9CTrbe9cFR00xqyGo7CwFcV3s/QqFxaDQFizr7gdoa4RFRpkw297FzMhQem4fHCqMey9XGRHAlYf58sa1AURLZTqeCmMrIhb3/X8JwKaubUkcVo2Qj6Wusd9UB1kG88xBB7T7UStDJAeqhfFsNPd6Qo5mzFQHqaTQGGVaHIvnJ/CTmYyrtdX1rouBArXmtssWmphy0nGKOKMckn+KvwgLcuS+miJ3f8+FA30Zv6uxfS7xVN6FZ13wo7meHcZvF/A X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2016 08:28:00.1223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1306 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 06.09.2016 um 08:16 schrieb Baoyou Xie: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/fiji_hwmgr.c:1633:9: warning: no previous prototype > for 'fiji_get_voltage_index' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/fiji_hwmgr.c:5412:5: warning: no previous prototype > for 'fiji_check_states_equal' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/fiji_thermal.c:424:5: warning: no previous prototype > for 'tf_fiji_thermal_setup_fan_table' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie Reviewed-by: Christian König > --- > drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c | 33 +++++++++++++--------- > drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c | 6 ++-- > 2 files changed, 22 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c > index 120a9e2..a4726c4 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c > @@ -113,7 +113,7 @@ static const uint8_t fiji_clock_stretch_amount_conversion[2][6] = > > static const unsigned long PhwFiji_Magic = (unsigned long)(PHM_VIslands_Magic); > > -struct fiji_power_state *cast_phw_fiji_power_state( > +static struct fiji_power_state *cast_phw_fiji_power_state( > struct pp_hw_power_state *hw_ps) > { > PP_ASSERT_WITH_CODE((PhwFiji_Magic == hw_ps->magic), > @@ -123,7 +123,8 @@ struct fiji_power_state *cast_phw_fiji_power_state( > return (struct fiji_power_state *)hw_ps; > } > > -const struct fiji_power_state *cast_const_phw_fiji_power_state( > +static const struct > +fiji_power_state *cast_const_phw_fiji_power_state( > const struct pp_hw_power_state *hw_ps) > { > PP_ASSERT_WITH_CODE((PhwFiji_Magic == hw_ps->magic), > @@ -1630,7 +1631,7 @@ static int fiji_setup_default_dpm_tables(struct pp_hwmgr *hwmgr) > * @param voltage - voltage to look for > * @return 0 on success > */ > -uint8_t fiji_get_voltage_index( > +static uint8_t fiji_get_voltage_index( > struct phm_ppt_v1_voltage_lookup_table *lookup_table, uint16_t voltage) > { > uint8_t count = (uint8_t) (lookup_table->count); > @@ -1694,7 +1695,7 @@ static int fiji_populate_cac_table(struct pp_hwmgr *hwmgr, > * @return always 0 > */ > > -int fiji_populate_smc_voltage_tables(struct pp_hwmgr *hwmgr, > +static int fiji_populate_smc_voltage_tables(struct pp_hwmgr *hwmgr, > struct SMU73_Discrete_DpmTable *table) > { > int result; > @@ -2305,7 +2306,7 @@ static int fiji_populate_all_memory_levels(struct pp_hwmgr *hwmgr) > * @param mclk the MCLK value to be used in the decision if MVDD should be high or low. > * @param voltage the SMC VOLTAGE structure to be populated > */ > -int fiji_populate_mvdd_value(struct pp_hwmgr *hwmgr, > +static int fiji_populate_mvdd_value(struct pp_hwmgr *hwmgr, > uint32_t mclk, SMIO_Pattern *smio_pat) > { > const struct fiji_hwmgr *data = (struct fiji_hwmgr *)(hwmgr->backend); > @@ -4626,7 +4627,7 @@ static int fiji_generate_dpm_level_enable_mask( > return 0; > } > > -int fiji_enable_disable_uvd_dpm(struct pp_hwmgr *hwmgr, bool enable) > +static int fiji_enable_disable_uvd_dpm(struct pp_hwmgr *hwmgr, bool enable) > { > return smum_send_msg_to_smc(hwmgr->smumgr, enable ? > (PPSMC_Msg)PPSMC_MSG_UVDDPM_Enable : > @@ -4640,14 +4641,14 @@ int fiji_enable_disable_vce_dpm(struct pp_hwmgr *hwmgr, bool enable) > PPSMC_MSG_VCEDPM_Disable); > } > > -int fiji_enable_disable_samu_dpm(struct pp_hwmgr *hwmgr, bool enable) > +static int fiji_enable_disable_samu_dpm(struct pp_hwmgr *hwmgr, bool enable) > { > return smum_send_msg_to_smc(hwmgr->smumgr, enable? > PPSMC_MSG_SAMUDPM_Enable : > PPSMC_MSG_SAMUDPM_Disable); > } > > -int fiji_enable_disable_acp_dpm(struct pp_hwmgr *hwmgr, bool enable) > +static int fiji_enable_disable_acp_dpm(struct pp_hwmgr *hwmgr, bool enable) > { > return smum_send_msg_to_smc(hwmgr->smumgr, enable? > PPSMC_MSG_ACPDPM_Enable : > @@ -4884,7 +4885,7 @@ static void fiji_apply_dal_minimum_voltage_request(struct pp_hwmgr *hwmgr) > return; > } > > -int fiji_upload_dpm_level_enable_mask(struct pp_hwmgr *hwmgr) > +static int fiji_upload_dpm_level_enable_mask(struct pp_hwmgr *hwmgr) > { > int result; > struct fiji_hwmgr *data = (struct fiji_hwmgr *)(hwmgr->backend); > @@ -5160,7 +5161,7 @@ static int fiji_program_display_gap(struct pp_hwmgr *hwmgr) > return 0; > } > > -int fiji_display_configuration_changed_task(struct pp_hwmgr *hwmgr) > +static int fiji_display_configuration_changed_task(struct pp_hwmgr *hwmgr) > { > return fiji_program_display_gap(hwmgr); > } > @@ -5191,7 +5192,7 @@ static int fiji_set_max_fan_rpm_output(struct pp_hwmgr *hwmgr, > PPSMC_MSG_SetFanRpmMax, us_max_fan_rpm); > } > > -int fiji_dpm_set_interrupt_state(void *private_data, > +static int fiji_dpm_set_interrupt_state(void *private_data, > unsigned src_id, unsigned type, > int enabled) > { > @@ -5239,7 +5240,7 @@ int fiji_dpm_set_interrupt_state(void *private_data, > return 0; > } > > -int fiji_register_internal_thermal_interrupt(struct pp_hwmgr *hwmgr, > +static int fiji_register_internal_thermal_interrupt(struct pp_hwmgr *hwmgr, > const void *thermal_interrupt_info) > { > int result; > @@ -5409,7 +5410,10 @@ static inline bool fiji_are_power_levels_equal(const struct fiji_performance_lev > (pl1->pcie_lane == pl2->pcie_lane)); > } > > -int fiji_check_states_equal(struct pp_hwmgr *hwmgr, const struct pp_hw_power_state *pstate1, const struct pp_hw_power_state *pstate2, bool *equal) > +static int > +fiji_check_states_equal(struct pp_hwmgr *hwmgr, > + const struct pp_hw_power_state *pstate1, > + const struct pp_hw_power_state *pstate2, bool *equal) > { > const struct fiji_power_state *psa = cast_const_phw_fiji_power_state(pstate1); > const struct fiji_power_state *psb = cast_const_phw_fiji_power_state(pstate2); > @@ -5441,7 +5445,8 @@ int fiji_check_states_equal(struct pp_hwmgr *hwmgr, const struct pp_hw_power_sta > return 0; > } > > -bool fiji_check_smc_update_required_for_display_configuration(struct pp_hwmgr *hwmgr) > +static bool > +fiji_check_smc_update_required_for_display_configuration(struct pp_hwmgr *hwmgr) > { > struct fiji_hwmgr *data = (struct fiji_hwmgr *)(hwmgr->backend); > bool is_update_required = false; > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c > index 92976b6..7f431e7 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_thermal.c > @@ -152,7 +152,7 @@ int fiji_fan_ctrl_set_default_mode(struct pp_hwmgr *hwmgr) > return 0; > } > > -int fiji_fan_ctrl_start_smc_fan_control(struct pp_hwmgr *hwmgr) > +static int fiji_fan_ctrl_start_smc_fan_control(struct pp_hwmgr *hwmgr) > { > int result; > > @@ -421,7 +421,7 @@ int fiji_thermal_stop_thermal_controller(struct pp_hwmgr *hwmgr) > * @param Result the last failure code > * @return result from set temperature range routine > */ > -int tf_fiji_thermal_setup_fan_table(struct pp_hwmgr *hwmgr, > +static int tf_fiji_thermal_setup_fan_table(struct pp_hwmgr *hwmgr, > void *input, void *output, void *storage, int result) > { > struct fiji_hwmgr *data = (struct fiji_hwmgr *)(hwmgr->backend); > @@ -533,7 +533,7 @@ int tf_fiji_thermal_setup_fan_table(struct pp_hwmgr *hwmgr, > * @param Result the last failure code > * @return result from set temperature range routine > */ > -int tf_fiji_thermal_start_smc_fan_control(struct pp_hwmgr *hwmgr, > +static int tf_fiji_thermal_start_smc_fan_control(struct pp_hwmgr *hwmgr, > void *input, void *output, void *storage, int result) > { > /* If the fantable setup has failed we could have disabled