From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35C0B23D7E6 for ; Fri, 3 Apr 2026 07:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775203119; cv=none; b=BWlcKIvg6Wdw78E99c/WYnCb1HSNAyL8HlkWNSiVdIbruiaWZlzoSky5NAQxeA8IAgc5tp5uw0NQgZ96ffrW2IyAp2a6u3BRa1ni8oCggPykAL/vCiXpMUyoprsEYIdWA+280z3VCyyGxcusqq8CAEsI4IDJY61lR3WSR6zqxck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775203119; c=relaxed/simple; bh=iyAB7gII/1CNHhLdPYcLIvBYUxpBRetpu0BGjIDOoAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rY+PNRhgJUvtCb/wDshwKi4aNOqNSQEhDi0rBYUPPt45EWr3el5EuPVOBU2WG+LsExA0+KOA8dEKwF8DMoGAuCQ7W9tuJ5lx/h2h5rwRlIQ6882Pd4n7c6x55tsi11+73WHtUqFwLrmbEzc0e9VOBrgbkQQsuVP2ko0sKNp0HoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jiyB4Zb8; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jiyB4Zb8" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-38be5e86918so15627001fa.3 for ; Fri, 03 Apr 2026 00:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775203115; x=1775807915; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MGCHyYl1z+dat38USyLCtY9Jhy0Oc9fCrN4Rc2ieXuw=; b=jiyB4Zb8Enoee+9+qMsNydnmbuum9bv1n4E8XTCwFiRJaan80utZQxF0gOI+JdMTmG yG3Vv9UOpjuT0e6ed/QBel/6PjQ+48j6FGywPRzN8hV7xMKffyinegdxC9Af4/aCC32O Uk2IxWqkTIYDOVo7jltrgpDqmTzqrqG6XIM/1mTsHY2u5zBw8OVt2eNREcTJRmViyJGS xOsUaomVeFRvMqTvVcayD5nr6PDxlFHZb2W6//ZKBn50FBJ5sLk7FxM7tQNMeCL4SoTR OfsHaV0KhI79SWfS1zrxWrT/K3CxI4JcYXtgIXC+hLD797p3OInYjoxTh/iwTSngBj1Q 3kFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775203115; x=1775807915; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MGCHyYl1z+dat38USyLCtY9Jhy0Oc9fCrN4Rc2ieXuw=; b=WHvXFmB4QuEpVacvLSmwoqIabwl6xECCJFWfEOFV+fkGvncbYld0IhHh/Y8P+zlnn3 kNo16ZdaqK5yvCFCo6A2UhncW3g5YHvVAQmTZUvur+cN2Vhp+SUxYffsLSLXYp6Mt0q6 5HWd04QxSlqbSF/ljUT0Zl3V0NL8cuVo3JPnThudLkNpNnNWL9pKLHK7ymX2/UJVdLGI KZ7ax3DxyMvLVBm82qNMvsLP3cE/MhECoE+dMaWVSvv7RH7fVGlo0Sg/6Qvb/hEiP6pB uCanU5aiiXbakb6zEjbThUxnP5QoF4sI2OM+aIOG7oA87kQk0k7qdAHQV+Ws7xVZQFcL ay/w== X-Forwarded-Encrypted: i=1; AJvYcCVex28qlD0tdwYvga3N14GaSddD5XiVK5SNSLr0qOClmw68eQprTuBwPBqOipRAVdnEEWTvw9e0l6Ily7s=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2ChcTaAZ8uGxN/eHkjfLDf918gyf0EPT2iJJce7Gg5fRkVejH YcvDUTQqEQp3b62ihsjmWiTp9/k2Jv0Ox9angfLLyClBFtn+8w86dZd9 X-Gm-Gg: AeBDieuzHztLiBlzyjwOaFxaadk/FPWuaVPwRh8mhBasQhIFdXdmgF0DxpRbYo5D/Ls tFQdGN+BCzNJeaiZGpZJpqbrqQN7WTNVQkN/DMtA3S8xNs6EH0lhf2VE0qDBeda5R0GOKPS7tNb J0lVBixVjJjApRCaLv8pdBMuoFUwAQrojo3ceQhUZy/fqaxec5sAVQVmwX/Kjh8vlNccsTAI6CF UrhDdsKf6H/vdR6tiJ/eQxt8t+ekTnf/fFB2I8kuEDnm+7Gy8jNDQ+/yi4Q/OyPLT0ieeowHirQ laGb2RW4FBLo+07XxzQBXQ7FeZg5FRVzKUg5jOOxL/LGd2r7+wxILZaGDhyC9J6yyTezXrtkU+T nO+hMSRiEb/wmrBVE3r++7qaZjsJpi9cN8+U07fuoHIXnP09nyds6+pKULUgc7votcB8JupiOb7 meZsSYhFocGqdJ/kY76U/OqnaogbpZ851Xy5Qgz4ay5GImduz5/AH2uo026Mb0qXE0WhbTrcBTN CQowZw= X-Received: by 2002:a05:651c:41c9:b0:38a:2917:8546 with SMTP id 38308e7fff4ca-38d91d4871amr6012871fa.30.1775203115008; Fri, 03 Apr 2026 00:58:35 -0700 (PDT) Received: from ?IPV6:2a00:1fa0:4251:186d:5db5:ce7:dcb1:3a02? ([2a00:1fa0:4251:186d:5db5:ce7:dcb1:3a02]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38cd20088a8sm10758341fa.18.2026.04.03.00.58.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2026 00:58:34 -0700 (PDT) Message-ID: <591cb5e6-26aa-4ed0-9298-5fc4c9742071@gmail.com> Date: Fri, 3 Apr 2026 10:58:32 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] MIPS: validate DT bootargs before appending them To: Pengpeng Hou , Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260403161001.1-mips-dt-bootargs-pengpeng@iscas.ac.cn> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: <20260403161001.1-mips-dt-bootargs-pengpeng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/3/26 8:41 AM, Pengpeng Hou wrote: > bootcmdline_scan_chosen() fetches the raw flat-DT bootargs property and > passes it straight to bootcmdline_append(). That helper later feeds the > same pointer into strlcat(), which computes strlen(src) before copying. > Flat DT properties are external boot input, and this path does not > prove that bootargs is NUL-terminated within its declared bounds. > > Reject unterminated bootargs properties before appending them to the > kernel command line. > > Signed-off-by: Pengpeng Hou > --- > arch/mips/kernel/setup.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > index f9b228e33f3b..dd7915110820 100644 > --- a/arch/mips/kernel/setup.c > +++ b/arch/mips/kernel/setup.c [...] > @@ -541,6 +542,9 @@ static int __init bootcmdline_scan_chosen(unsigned long node, const char *uname, > > p = of_get_flat_dt_prop(node, "bootargs", &l); > if (p != NULL && l > 0) { > + if (!memchr(p, '\0', l)) Maybe strnlen()? [...] MBR, Sergey