From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933386AbcIELtn (ORCPT ); Mon, 5 Sep 2016 07:49:43 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:60941 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932176AbcIELtm (ORCPT ); Mon, 5 Sep 2016 07:49:42 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: gregkh@linuxfoundation.org, wsa+renesas@sang-engineering.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] staging: ks7010: mark symbols static where possible Date: Mon, 05 Sep 2016 13:49:51 +0200 Message-ID: <5921441.mANbND8V8Z@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1472971119-4560-1-git-send-email-baoyou.xie@linaro.org> References: <1472971119-4560-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:53hFsIVMGZqlrgw1hdgjx0bKDFs5HXWs6Yg5mTV5H2hi44glvWK 4s55NeJAkgAsm+pDA8N7WEFA80kpFqxzr/Q3+LJ35Yx6k4/Re11Mb0kqGKa+ZHcpbuhfExc XK6ZBygSH65ilvJqzEOMB3Qj461sSek7+DCJKvMfpiJcJnWxkKgj/urCy4xxQBdEgMcyaQK Hxtn6Ig8C7TJnl5eSreIA== X-UI-Out-Filterresults: notjunk:1;V01:K0:PAueF667nGo=:W0WdyUWEVRVdnX/JiywCBh 7DTF8cqHrgCM39qTHvM9k3MxHpWruS+49bZ8nBpgcN2g6wBufP409pWxNNUs5llrnaNdsJe3D 3IKOz4KYc7GYFE5fPgGHNGBQ6iahu9fOe8V3J585bD7L5G5uPEz8DONZ35SRznLi9l6ciJ2P5 /+SZtiHrG7PXc8WD4P8EDpW/+co5QJ/H2DyVpE3IvhBP305zg21HU+wnT7DNRz2c+elu+AWs4 XgNqk0iCNzWg+scWHWLVlIQW2ouWZKZnIkLVqRofbec7A0sFpn4CaQleqZmtvAqVAXORe5aAp 7T84blxAOyHUJO/WrTvdZ+M6rC7CZw/033JzI/aB/LS6OU11/P7aY6NSgMInUD4NIwhHQDDP2 anPpPz8p6BuzVWnCZZjHJD0o7GBsuxfnQjyUasWAKWNcchqUy1poR4SR1p5KjGfKMzdw8/Ny7 Jqt79Gvu8YzWNdrSMjo/HU6O1GblsPdZGEevsCo46vSaQ/5HK/NWnZxm+fqSsxoU9xaF1CiYF vJoAecpVflrhZBawPoWE8UpO0fvuS6jkfbelZ69wekKOmpJ5ae2aJLePu2FpuaMrYJcRzMKcM roytKBQiFE4gdWZZZ2d5szR7o4QCamM5hevwoZ6Cm9jOfk+F0TwzxnFZ3jP7w9OTdc3D7ErE5 OxKqNbhRLi6VkVAVOdUsP0ORsSgnvXqo7sTt/9mguOyAtlckv8CltPsbbXdhWXEAmS3fEa75o D/JBmyi23T8nfzDp Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, September 4, 2016 2:38:39 PM CEST Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/staging/ks7010/ks_hostif.c:72:6: warning: no previous prototype for 'ks_wlan_hw_wakeup_task' [-Wmissing-prototypes] > drivers/staging/ks7010/ks_hostif.c:1508:6: warning: no previous prototype for 'hostif_infrastructure_set2_request' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann