From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD467C04A95 for ; Sun, 25 Sep 2022 19:26:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232357AbiIYT0n (ORCPT ); Sun, 25 Sep 2022 15:26:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230509AbiIYT0k (ORCPT ); Sun, 25 Sep 2022 15:26:40 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5682026AC4 for ; Sun, 25 Sep 2022 12:26:38 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id y3so10167998ejc.1 for ; Sun, 25 Sep 2022 12:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=wv1NWdkn3I9gA/Yg/AumQzS52TikNGwDppVEZ+Nt1Wk=; b=ee+oMk5QJHGldCNyCjWqsb2Mn9sj6dahTB50enQsh0/c5xjIiWEPbfihPBQwdQ6FdQ 6cIflYdMZCUGIHDeicJI/x4yKrbL3L2rG6SmZAxkpBx5Clk58Cf8B0RDzL2A9H6pAG/z d8slV4OuQe7GjXBNaxwGZPqE9a4LIUPAFDCYLvgYzJh9Pg3WFxMGSZF6kUWQKJutE+sy C5BtvEJL45Op08j/AMTL1soTBJ3abdns7ScaZJw4t3NaZP0gNPRIWjWVNS2aN3EsAxDU JdoSpQPR0ZDmZbVkAMPc36Voo0gDRJqvaY3+zskEdeq8JyYmyummclEH4i0ps13A5/pQ swXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=wv1NWdkn3I9gA/Yg/AumQzS52TikNGwDppVEZ+Nt1Wk=; b=TDxU0904UUgbLg3PptOpqfqEeKbyqQ4zuy7psY0z7x72KWquj8NA2gasgyFAKMHiEX 0vFL9w0lih0lWjiVPQ/BWky1bqtnUIMwjJQZYLUEp6RZaZNVNB0f9HhznCLW/31dTdEp 8FPXLA8nxSYnPJr1CDKFau31cv2rCXeO4YruWon2PuPkdfggbLqVoX8UAl8s0I2ws1G7 PAtlMMumZLE2ZwfEawxemZoohyq9Wne3nujcCvY71qKsJE2ZmJwSGEcfHcTq/cTcYXCL 6qoJTHWhQF3wiVBL1lcAas/oZmQowcNRQJCr6MOQkZ6oxwHxCueqjSbYGsxBdbiEvXdP 8AMw== X-Gm-Message-State: ACrzQf0izarfSp7TGgxIBDggKKVA9d8mWZPBpYSLhF1S5eoRoWBGHN2l Atd2yfyKMGo6m93ehuO/8LkcUyVwHu8= X-Google-Smtp-Source: AMsMyM6XPVke5u+Ie/NleaWu7V80J+TKvM5qZRIh92byCyFET/dhcJGoKVXKDW8+QNL6HKfiDfYljA== X-Received: by 2002:a17:907:a079:b0:77d:a363:64b6 with SMTP id ia25-20020a170907a07900b0077da36364b6mr14931389ejc.451.1664133996784; Sun, 25 Sep 2022 12:26:36 -0700 (PDT) Received: from [192.168.1.100] (p57ba2cf5.dip0.t-ipconnect.de. [87.186.44.245]) by smtp.gmail.com with ESMTPSA id w23-20020a170906185700b0073d71792c8dsm7242796eje.180.2022.09.25.12.26.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Sep 2022 12:26:36 -0700 (PDT) Message-ID: <59255558-06ed-d82f-3e72-f1ccf03ba96d@gmail.com> Date: Sun, 25 Sep 2022 21:26:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] staging: rtl8192e: Rename Tx_Retry_Count_Reg Content-Language: en-US To: Dragan Cvetic , gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220924225126.10527-1-dragan.m.cvetic@gmail.com> From: Philipp Hortmann In-Reply-To: <20220924225126.10527-1-dragan.m.cvetic@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/25/22 00:51, Dragan Cvetic wrote: > Rename: Current_Tx_Rate_Reg to CURRENT_TX_RATE_REG, Initial_Tx_Rate_Reg to > INITIAL_TX_RATE_REG and Tx_Retry_Count_Reg to TX_RETRY_COUNT_REG to avoid > CamelCase which is not accepted by checkpatch.pl. > > Signed-off-by: Dragan Cvetic > --- > drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 11 +++-------- > drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 6 +++--- > 2 files changed, 6 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c > index 3ee52147960e..9fefa1a7ae75 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c > @@ -2499,14 +2499,9 @@ static void _rtl92e_dm_check_txrateandretrycount(struct net_device *dev) > struct r8192_priv *priv = rtllib_priv(dev); > struct rtllib_device *ieee = priv->rtllib; > > - ieee->softmac_stats.CurrentShowTxate = rtl92e_readb(dev, > - Current_Tx_Rate_Reg); > - > - ieee->softmac_stats.last_packet_rate = rtl92e_readb(dev, > - Initial_Tx_Rate_Reg); > - > - ieee->softmac_stats.txretrycount = rtl92e_readl(dev, > - Tx_Retry_Count_Reg); > + ieee->softmac_stats.CurrentShowTxate = rtl92e_readb(dev, CURRENT_TX_RATE_REG); > + ieee->softmac_stats.last_packet_rate = rtl92e_readb(dev, INITIAL_TX_RATE_REG); > + ieee->softmac_stats.txretrycount = rtl92e_readl(dev, TX_RETRY_COUNT_REG); > } > > static void _rtl92e_dm_send_rssi_to_fw(struct net_device *dev) > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h > index ea1b14bbcdcd..51e295d389a8 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h > @@ -42,9 +42,9 @@ > #define TX_POWER_ATHEROAP_THRESH_HIGH 78 > #define TX_POWER_ATHEROAP_THRESH_LOW 72 > > -#define Current_Tx_Rate_Reg 0x1e0 > -#define Initial_Tx_Rate_Reg 0x1e1 > -#define Tx_Retry_Count_Reg 0x1ac > +#define CURRENT_TX_RATE_REG 0x1e0 > +#define INITIAL_TX_RATE_REG 0x1e1 > +#define TX_RETRY_COUNT_REG 0x1ac > #define RegC38_TH 20 > > #define DM_Type_ByDriver 1 Tested-by: Philipp Hortmann