From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964977AbbJ3MpS (ORCPT ); Fri, 30 Oct 2015 08:45:18 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:59297 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756629AbbJ3MpQ (ORCPT ); Fri, 30 Oct 2015 08:45:16 -0400 From: Arnd Bergmann To: Hannes Reinecke Cc: Tina Ruchandani , linux-scsi@vger.kernel.org, "James E.J. Bottomley" , y2038@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Date: Fri, 30 Oct 2015 13:45:08 +0100 Message-ID: <5927653.jpoZ2K5FqB@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56335B69.4010502@suse.de> References: <20151030083040.GA31741@tina-laptop> <56335B69.4010502@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ZILpmjF6fbbMq0F2e7OY6Nhcw1o5zMjXmObVk7OUIIFGKw2WTOe Fb8wL7pc+XhHxZrVvbbIuKJJzkwMUCBWdmJwZiuhMQH44C3SMha2gQ7oJ4plT5Eg3wj+72T 7GuI891mdkioES6pQSKVdO97EosMxcF+y0fMZotB5Fz1XJpUlhz+roa8krCAyAB8fBSOT7I WHbMofw+GtL5od/w5s18g== X-UI-Out-Filterresults: notjunk:1;V01:K0:EXOCk35FsSQ=:xBX6s1x1Xenxo8q/Ylzxuo +K6KevjttMMzgVPdrqvQKSQS7XgqWIM2FD2c8X/LGEDjbbfpE3QFWcXdZXHZsMjhbyVZImv+G 7jgMGzBD9kM+SKPqavVG2Rv/u1TzN/M6fJaGprBk3Pj8EqgyFQ+5RbyOZOq/GWLL3LLxOaQ3a ZlmK1IGoRR2t5cl0D/S5UfvxACLIutH/RM174OnC0qwLSWjfc0udVgjHzQdR77VqF5PlKNIXc +o1hpmcDznPhuhkiVS/PKhpf7SZfy+qiNlmiqGrXGW5ODIFCUzmzWMGUAEna86SHcn4zPcCpE BZA39qgmGPmlviXk3PrxFpQ0O5C47dB6cleVF8FG37McIvAIzh3eGDHCiaxd0cqNXcJl7sK0C 9BM1vHKxAzgsh2auVdh4y5dRBDPxNSPJ+3qUUmEMnZaNnKVPARblPki/GRHEiWdo1u8io7U6Z uGOIaH8XnfFwdtigYVcZuSWgfzQ60atfSvWVHw+N3a5YFYVBfNLsuUjZVVBKrQvQhnOYqcfLS cLETMNjfbfYmErrgcoEG4/0A8z0MN5zsROAat2vqf4CjLcybb66gAIvM9gVxeLKuotBRo4BHU XrMC7tAFmppIKibml+gKoUO4CAY0C63qd+6FM6eEaqSu6xA8AoQhgN2B4SaTW6SVO0upi7LZC Mv6n5DrDqaSSn5adfBNMUxYACrKTkFKyIjUzL/lEIYUh2dUeKdNiZaBrAy9DxmmK5GnV4ebGi DDEfXk+hB0XMW2np Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 30 October 2015 12:58:33 Hannes Reinecke wrote: > > @@ -1076,7 +1069,7 @@ static int stex_ss_handshake(struct st_hba *hba) > > h->req_cnt = cpu_to_le16(hba->rq_count+1); > > h->status_sz = cpu_to_le16(sizeof(struct status_msg)); > > h->status_cnt = cpu_to_le16(hba->sts_count+1); > > - stex_gettime(&h->hosttime); > > + h->hosttime = cpu_to_le64(ktime_get_real_seconds()); > > h->partner_type = HMU_PARTNER_TYPE; > > h->extra_offset = h->extra_size = 0; > > scratch_size = (hba->sts_count+1)*sizeof(u32); > > > Just remove 'hosttime' altogether. It serves no purpose whatsoever. > > Are you sure? It is defined in a struct that is shared with the HBA as part of hba->dma_mem, so unless you have access to the firmware, it's hard to guess what it might be used for inside of the firmware. Arnd