From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751815AbdHCOCi (ORCPT ); Thu, 3 Aug 2017 10:02:38 -0400 Received: from m15-37.126.com ([220.181.15.37]:59854 "EHLO m15-37.126.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbdHCOCh (ORCPT ); Thu, 3 Aug 2017 10:02:37 -0400 X-Originating-IP: [153.3.28.15] Date: Thu, 3 Aug 2017 22:01:40 +0800 (CST) From: sohu0106 To: linux-fbdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org Subject: driver/video/fbdev/aty/atyfb_base.c: atyfb_ioctl() stack infoleak X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160729(86883.8884) Copyright (c) 2002-2017 www.mailtech.cn 126com Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Message-ID: <592b793c.aa4f.15da866df61.Coremail.sohu0106@126.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: JcqowEA5GUPELINZO4JmAQ--.58415W X-CM-SenderInfo: pvrk3iqrqwqiyswou0bp/1tbi3AwpHlag3kDnVwABs+ X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v73E2iKn018552 driver/video/fbdev/aty/atyfb_base.c In atyfb_ioctl() structure atyclk is copied to userland with padding bytes after "vclk_post_div" field unitialized. It leads to leaking of contents of kernel stack memory. 3  drivers/video/fbdev/aty/atyfb_base.c  @@ -1857,6 +1857,9 @@ static int atyfb_ioctl(struct fb_info *info, u_int cmd, u_long arg)   if (M64_HAS(INTEGRATED)) {   struct atyclk clk;   union aty_pll *pll = &par->pll;  +  + memset( &clk, 0, sizeof(struct atyclk) );  +   u32 dsp_config = pll->ct.dsp_config;   u32 dsp_on_off = pll->ct.dsp_on_off;   clk.ref_clk_per = par->ref_clk_per;