From: Mark Salyzyn <salyzyn@android.com>
To: Pavel Machek <pavel@ucw.cz>, "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Todd Poynor <toddpoynor@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>
Subject: Re: PM / Suspend: Print wall time at suspend entry and exit
Date: Mon, 5 Jun 2017 14:47:21 -0700 [thread overview]
Message-ID: <5931f9cb-016f-4163-4908-6825cf84b9d3@android.com> (raw)
In-Reply-To: <20170605211835.GB9035@amd>
On 06/05/2017 02:18 PM, Pavel Machek wrote:
> Hi!
>
>> On Mon, Jun 5, 2017 at 9:31 PM, Mark Salyzyn <salyzyn@android.com> wrote:
>>> Permits power state and battery life diagnosis.
>> Which is possible even without this patch and we have tools for that
>> (analyze_suspend.py, anyone?).
>>
>> Honestly, I don't see why this change is necessary or even useful.
> I ran dmesg after resume and now I...
>
> [1019729.486249] ACPI : EC: EC stopped
> [1019729.486255] PM: Saving platform NVS memory
> [1019729.486276] Disabling non-boot CPUs ...
> [1019729.490423] smpboot: CPU 1 is now offline
> [1019729.531015] smpboot: CPU 2 is now offline
> [1019729.577742] Broke affinity for irq 16
> [1019729.577747] Broke affinity for irq 17
> [1019729.577751] Broke affinity for irq 19
> [1019729.577756] Broke affinity for irq 23
> [1019729.578771] smpboot: CPU 3 is now offline
> [1019729.604987] ACPI: Low-level resume complete
> [1019729.605052] ACPI : EC: EC started
> [1019729.605054] PM: Restoring platform NVS memory
> [1019729.605352] Suspended for 3196.166 seconds
> [1019729.605376] Enabling non-boot CPUs ...
> [1019729.631246] x86: Booting SMP configuration:
> [1019729.631249] smpboot: Booting Node 0 Processor 1 APIC 0x1
> [1019729.631496] Initializing CPU#1
> [1019729.631514] Disabled fast string operations
> [1019729.636643] cache: parent cpu1 should not be sleeping
> [1019729.637286] CPU1 is up
>
> Aha. I missed the "suspended for 3196" message before. So I believe
> you are right; there's already enough information in the kernel logs.
>
> Pavel
We do not get the Suspended for messages on failure to suspend
(interrupt wakeup), but that is a weak argument ;-/ since it is
discoverable from context and we can count the aborted suspends
switching the tools. The Suspended for messages are in ms which is not
accurate enough for Android user space logs (in ns) long term continuous
tracking of monotonic vs realtime and makes no accounting for ntp
adjustments. Currently, post mortem data only on Android, we have no
other way to align monotonic kernel logs with user space logs without this.
Sincerely -- Mark Salyzyn
next prev parent reply other threads:[~2017-06-05 21:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 19:31 Mark Salyzyn
2017-06-05 19:31 ` PM / Hibernation: Print wall time at hibernation " Mark Salyzyn
2017-06-05 20:07 ` PM / Suspend: Print wall time at suspend " Pavel Machek
2017-06-05 20:58 ` Rafael J. Wysocki
2017-06-05 21:18 ` Pavel Machek
2017-06-05 21:47 ` Mark Salyzyn [this message]
2017-06-05 22:10 ` Mark Salyzyn
2017-06-05 22:40 ` Pavel Machek
2017-06-06 18:05 ` Mark Salyzyn
2017-07-13 8:54 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5931f9cb-016f-4163-4908-6825cf84b9d3@android.com \
--to=salyzyn@android.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®