From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF713DD517 for ; Mon, 30 Mar 2026 17:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774891600; cv=none; b=XsrZugzK+z077MqZMxZ6nKjb4AhybI3rqBPZkXhf+wVvNOKTevK9jq3SkQQCqA0ZlmCt/rYM5iW59GqLO3atJVtmti8fopDn/3NX3DWpn2NMBk8VEHTugpLVTmaGzfKu9nSyeV7B86ZRIdl/jy2EmzaQ3wH8bQvsP8Jl8t93xHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774891600; c=relaxed/simple; bh=Azf9t9LLMEluFtDRi2U0rirw+r6OKxYM1c6Otzc4+3I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WcRivO8a3uz0olVz2Hk9kzZP308qnYnyX9SaD3QR2QG2SF4yeIbG2cpv7ood6TpON2V4OyWmawisz9f0mLJgvRPNwwlNHf43ZQPANa445jJ6ftpsgkLaki63oUgT4ZyvAm65WEu30PTWBNdIq2cWq5S8OMA0hZ8ccChyGgLVoBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=dJ5NwMQL; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="dJ5NwMQL" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48541edecf9so58763225e9.1 for ; Mon, 30 Mar 2026 10:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774891598; x=1775496398; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lQ4Qre2xZc/I28s/3C4XOR6vzlzaxw3SBjpFEsksT/M=; b=dJ5NwMQLCDgAHLqvn9AgDiV0smkwBPhxKR2Up1vD4+6716E+VuPSGokFWnc39axQjk nHwg6SHynspLYetd2ZA80sKOSeF5/ktUz3fO75PsPeCTADPZlRWO07NeA/8x8ULGbi4h bu0fth5kXCSdv0rBVbiUU76ufjxjH1azGNktjBh90C1tI68LZaFRamBCtn2RxMwuLYPm LfUMyz2olPaMSQpPf6+cWSBx6w2Tj8NBBWZM7dLJzcSTT2ZVZN9PhERsDLBMEUToZ9E3 5Sa6lB04IawiI9RUVDEmkBce0USd2h6eMOjT/9Br6rWvnkx0NFYKEbsnzpjiy4qGof+V zZUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774891598; x=1775496398; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lQ4Qre2xZc/I28s/3C4XOR6vzlzaxw3SBjpFEsksT/M=; b=U0KaC59dc7xGZOBwENFfULSjQkNb1tEk3qO9uIh0FS0Kj0jVatWqk4NVg3q3AZGbPi zeLV9MVN44+14VrcJVfhB+lBGIgjW4eDmCp3B/1Rj8F4lELoKJWMfv0QYzqO6TrDkXgb 4dfCFP4lfULhBJHOnx0abBD+1hK//NxXt9dUgwkk5hI1Nuz4yaOZ1Ludri5H8pY2I+9n M5MS6rA50V1FBa4AIY4OZZPQ/avMa9gtAzIF1XAlfThWdW1FFW6PVPuj7L+JXaROFNCi cUCsn5O8UDdwKXYSRzatp5niv0CjO/+xGBWWJvijHmuawTYwuwD7FyM33uDbJAhkMqIj luvg== X-Forwarded-Encrypted: i=1; AJvYcCVWpVkh2CnemT1qITkuGCvBhd4C5ibGWG31qLqIiGV5tKvtXNhntK99cXSHCHEum9q2+cNgbSreeN9fQnc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxkz396ac79jqBUsMMwyPUCbJ1bwaJwdEmrHWMVKyUVqB2WLeEj 7278P55A/mBRmU92AQdJUmPoKfn2RId++Svh9zkibdVKKQsMynE89mm/gCfMqKgu3MU= X-Gm-Gg: ATEYQzyuiV1QZeQi/GuF2fS6LTpwoSRrHW2vFHQUl63JfpFIBfdWJzxqkVNfQ7x9KU7 U+OW6XY1ambpXnKa7z+OtB9sYzNFjsxVYdDGZFAezkXbJgPK72xpTfNeV+IPFMtdsCeLlFzVqjY 5/X8y8pTkBDWwmuoI60a3uMrAQWgG5UyeYrBeZ/aX+4K4TnIcPm0aSiGFX8lshqx4iyZfDkxhJN 9JeX6EORakwotf5aec3wA+QGK1pyz8iGE8MO0LUum6NrR+YmwHlwP2m37NUtiuX9U/3fMOXytxz iWKigB+Pqubds2SXlTetQaOImKfmdn71Ta778rrjmUaVY7PAh3ThYoNhT591gqFJNAdzzWZ49vq JKVpjRGLgxx34wFRNmoItcUZvJO8uGEXDQ+qwda6T017woOGNmfng9/dD0+vqyj9GrmL/E0Eqcf UvHNJTVAR7BfFAkx4LKQy1vumlld0KL1Nyt6EbUmD27L4IfaLyB+R+ret4vws/mAo2AQ== X-Received: by 2002:a05:600c:8b88:b0:485:2c61:9459 with SMTP id 5b1f17b1804b1-48727d83bc5mr222279745e9.8.1774891597796; Mon, 30 Mar 2026 10:26:37 -0700 (PDT) Received: from ?IPV6:2001:a61:1373:4b01:cc61:7bc9:bea5:a415? ([2001:a61:1373:4b01:cc61:7bc9:bea5:a415]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21eb95fsm22449089f8f.12.2026.03.30.10.26.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 10:26:37 -0700 (PDT) Message-ID: <59336d5a-28b5-4f34-b598-3d7beafbaf3b@suse.com> Date: Mon, 30 Mar 2026 19:26:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: misc: usbio: Fix URB memory leak on submit failure To: Felix Gu , Israel Cepeda , Hans de Goede , Sakari Ailus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260330-usbio-v1-1-7141b6dc612a@gmail.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20260330-usbio-v1-1-7141b6dc612a@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30.03.26 17:47, Felix Gu wrote: > When usb_submit_urb() fails in usbio_probe(), the previously allocated > URB is never freed, causing a memory leak. > > Add usb_free_urb() call to properly release the URB on the error path. Hi, the driver uses goto to unwind. Could you use the existing code with an additional label defined? Regards Oliver