mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Andreas Kemnade <andreas@kemnade.info>,
	"hns@goldelico.com" <hns@goldelico.com>,
	Fabian Frederick <fabf@skynet.be>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH RESEND] omap_hdq: fix usecount handling
Date: Tue, 19 Jan 2016 19:38:28 +0300	[thread overview]
Message-ID: <59381453221508@web14g.yandex.ru> (raw)
In-Reply-To: <1452948530-10639-1-git-send-email-andreas@kemnade.info>

Hi Andreas

>From w1 perspective this doesn't break things :)
Greg, please pull it into your tree if no one objects.

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

16.01.2016, 15:48, "Andreas Kemnade" <andreas@kemnade.info>:
> hdq_usecount was set to zero after a successful read, so
> omap_hdq_put could not properly free resources which leads
> e.g. to increasing usecounts in lsmod output
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  drivers/w1/masters/omap_hdq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index 0e2f43b..a2eec97 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
>
>          hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
>                                ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
> - hdq_data->hdq_usecount = 0;
>
>          /* Write followed by a read, release the module */
>          if (hdq_data->init_trans) {
> --
> 2.1.4

  parent reply	other threads:[~2016-01-19 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-16 12:48 Andreas Kemnade
2016-01-19 11:56 ` Vignesh R
2016-01-19 16:38 ` Evgeniy Polyakov [this message]
2016-01-19 18:13   ` gregkh
2016-02-07 19:22     ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59381453221508@web14g.yandex.ru \
    --to=zbr@ioremap.net \
    --cc=andreas@kemnade.info \
    --cc=fabf@skynet.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=hns@goldelico.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome