From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF1B2D6E74 for ; Sun, 16 Nov 2025 17:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763315412; cv=none; b=It24wP3B6ZUtOmfFrFhQ1d1DckKQVnMP823dTd6NsccdsAwhmJzoch6VHU0c6f7Y7PcGlfV+XGJirunmgNBXX1Tpky1lyWLajimwPvLbtY6XsINFGMOP3FjDP+FOHcfMUjIMmXEHtOe1VRe3dRD8ilpS7qw6itajDCGDuG6IzyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763315412; c=relaxed/simple; bh=QP7jspNMzyTvkGv06BWTHIjJjU1oOmLPoesgjcHxeRo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dG4Iek/gHa4iT4N/qY9p+ToMjuf9CTMhaWimyIQT1Wkv0DBQ37OyRIoA4cKjGRObmDxiPCRMP7yT+8IN40d9ba+mNay2CBmIUshriEzGgAq0YX2gVDmhgqs4LD/joC+w+scCXgFX8SGStNBFk+Eaz28j6rRY82bMWtdBH25hYBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cEGwZjgH; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cEGwZjgH" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b7355f6ef12so568509766b.3 for ; Sun, 16 Nov 2025 09:50:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763315409; x=1763920209; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QP7jspNMzyTvkGv06BWTHIjJjU1oOmLPoesgjcHxeRo=; b=cEGwZjgHJrnW5n6GJ5zi0t6emQHqYc2EN7FzgHa7VOIpWYCgV/XkSKH6f+myoOgy7a QKABIKtnd6EQXdlnZBZgTKndkhn/wRUg5ZhbMJyB4toXaWi4wbwdi+aly3cKfyFbxozo rQ4iCzm0F4K0OedHm9IQtIxvzfEIoVzhT89QCX3Qf7CLRdKLDnYxZwt7DEdSC8pXqEHb OixieAAeRrcUj6aoLu6eXr5aGropaZU8HLNcDhNPxIyn4R2YMYfJpI18B26kvkgCQ/Z+ GqQXAf8Dr7R+bm4+T2nXllCUa6RcK/Mre7VZ7vdM6E8lPyv9vRzJJYD9GLoBO/LDPvaE AcHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763315409; x=1763920209; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QP7jspNMzyTvkGv06BWTHIjJjU1oOmLPoesgjcHxeRo=; b=kEzeGQeF2dtq2O3S98PFPGFONaJ2xF9d5mwZD2zQ36A9hmLwUKi6OjbwPSe+giEAeg ar737cHakiKr3raYiM62CNtnu4Sf3Ss7l1LiOI/VP6JqZWoq+Xv6AGM4KsSrMhR0QSJL B3rFEvbBv7+pw6Z9p4AuVzQ324TTQOW6NA3cneA6YgKb2mpKh9nA1YHBAoi3jk1ligFx 6MyklV6CImT6DMyC62AtLtbWeiR7re2MuF242Nb2QuGftY1fdUs8u5Dq6KyrF8n/rQV+ jP6rolCpSF5KCqeQ6twZtls6r/n5w7BxfAGSFtyRF6hkM/C+A/Gp1KsyBiRo0tsyV5/W FzbA== X-Forwarded-Encrypted: i=1; AJvYcCXIphwkicOct/VWGUgR/l6UC39ulge6gTXy8QWs4kfqAjShhnydmrE3cLWOZscx4r/5sig/HRiodii8chE=@vger.kernel.org X-Gm-Message-State: AOJu0YzFQCrKDCJg4llnZqZr0nw0/cP67dtFCg5TV1mi0aMaCSWb7EGv vhgqrZw0Q7MNCFhr3rxBrI2fPPXiF5jWNVUKFB8OLRZLwLkKsVY8++Fm X-Gm-Gg: ASbGncs4t9hXwnsqQkYoH97qMQn6dW/dLeAkcOxgb9eaLXI8+r+EzS39imK0kZ0Wxsr 7Ho1XPdVDwNaoJcYwOHZkaJeFzy0siPANZrOiXLAENb7fbznf8Qty8MvMbLl60dyDIvuKdIJfLr a+nCPSMIURaxD8Opz3ZrDlO4/SIIlHiEWOXx/KL4nY+TA/sP7hAPfxXmBHZGqOgQ44EjX5vEW8C n9Ac+xqyASDbZT9rM2DiDWZorHYfSDOXwhZG3c5JnNwNkY4OtIdd/5Ha+pykDFbPtsp7dnX324B HRIVOGysM5+Mm52NaDp2RJ9kiJjYpmjRGNT0IaWsUnzrBRFjQDEQm0XAxb71RrHsOiSVYSw0hes tqasMYq0jTvWksNdrbCxQ6Qss7byh0xgvjk12HOjSbuQTqELuRw0fbIFFqj52+rY5iCBuhRaM0Z uIySHWmSfbKRmF8dNPLIhGFJa0TN3cmBIui7DduoY8fUIfq+nm7im24nN27HJp4efMvnEfe3pFg tWLfQ== X-Google-Smtp-Source: AGHT+IHnJ3o0lU2xLaeiHwgSeukdwtR1KGCz5g9vsnkLKv/heK41BVWAROvmPtIvPoJ/A4s01hmsSQ== X-Received: by 2002:a17:907:1b1d:b0:b3c:3c8e:189d with SMTP id a640c23a62f3a-b7367b8dd38mr1112936266b.32.1763315408563; Sun, 16 Nov 2025 09:50:08 -0800 (PST) Received: from jernej-laptop.localnet (178-79-73-218.dynamic.telemach.net. [178.79.73.218]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fed9e9fsm879409766b.69.2025.11.16.09.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 09:50:08 -0800 (PST) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Marc Kleine-Budde Cc: Vincent Mailhol , Chen-Yu Tsai , Samuel Holland , Gerhard Bertelsmann , Maxime Ripard , kernel@pengutronix.de, linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Thomas =?UTF-8?B?TcO8aGxiYWNoZXI=?= Subject: Re: [PATCH can] can: sun4i_can: sun4i_can_interrupt(): fix max irq loop handling Date: Sun, 16 Nov 2025 18:46:51 +0100 Message-ID: <5938604.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20251116-mysterious-delightful-spaniel-18d220-mkl@pengutronix.de> References: <20251116-sun4i-fix-loop-v1-1-3d76d3f81950@pengutronix.de> <2804881.mvXUDI8C0e@jernej-laptop> <20251116-mysterious-delightful-spaniel-18d220-mkl@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi! Dne nedelja, 16. november 2025 ob 17:26:07 Srednjeevropski standardni =C4= =8Das je Marc Kleine-Budde napisal(a): > On 16.11.2025 17:20:37, Jernej =C5=A0krabec wrote: > > Dne nedelja, 16. november 2025 ob 16:55:26 Srednjeevropski standardni = =C4=8Das je Marc Kleine-Budde napisal(a): > > > Reading the interrupt register `SUN4I_REG_INT_ADDR` causes all of its= bits > > > to be reset. If we ever reach the condition of handling more than > > > `SUN4I_CAN_MAX_IRQ` IRQs, we will have read the register and reset al= l its > > > bits but without actually handling the interrupt inside of the loop b= ody. > > > > > > This may, among other issues, cause us to never `netif_wake_queue()` = again > > > after a transmission interrupt. > > > > > > Fixes: 0738eff14d81 ("can: Allwinner A10/A20 CAN Controller support -= Kernel module") > > > Cc: stable@vger.kernel.org > > > Co-developed-by: Thomas M=C3=BChlbacher > > > Signed-off-by: Thomas M=C3=BChlbacher > > > Signed-off-by: Marc Kleine-Budde > > > --- > > > I've ported the fix from the sja1000 driver to the sun4i_can, which b= ased > > > on the sja1000 driver. > > > > Acked-by: Jernej Skrabec >=20 > Thank you very much! I have seen a lot of feedback from you about the > sun4i driver. Would you like to become the maintainer of the driver? As a Allwinner (sunxi) maintainer, it is somehow implied that I help with reviewing such drivers, right? However, while I never used sun4i_can driver, I know CAN protocol well as I work with SJA1000 compatible controllers at work, so I can help with maintaining it. Best regards, Jernej