From: Vineet Gupta <vgupta@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Vineet Gupta <vgupta@kernel.org>,
linux-snps-arc@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] arc: iounmap() arg is volatile
Date: Sun, 9 Oct 2022 21:44:07 -0700 [thread overview]
Message-ID: <593925a6-66d3-42bf-19d3-2f54917892ce@kernel.org> (raw)
In-Reply-To: <20221010022846.20101-1-rdunlap@infradead.org>
On 10/9/22 19:28, Randy Dunlap wrote:
> Add 'volatile' to iounmap()'s argument to prevent build warnings.
> This make it the same as other major architectures.
>
> Placates these warnings: (12 such warnings)
>
> ../drivers/video/fbdev/riva/fbdev.c: In function 'rivafb_probe':
> ../drivers/video/fbdev/riva/fbdev.c:2067:42: error: passing argument 1 of 'iounmap' discards 'volatile' qualifier from pointer target type [-Werror=discarded-qualifiers]
> 2067 | iounmap(default_par->riva.PRAMIN);
>
> Fixes: 1162b0701b14b ("ARC: I/O and DMA Mappings")
> Signed-off-by: Randy Dunlap<rdunlap@infradead.org>
> Cc: Vineet Gupta<vgupta@kernel.org>
> Cc:linux-snps-arc@lists.infradead.org
> Cc: Arnd Bergmann<arnd@arndb.de>
Thx for the fix. On for-curr.
-Vineet
prev parent reply other threads:[~2022-10-10 4:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 2:28 Randy Dunlap
2022-10-10 4:44 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593925a6-66d3-42bf-19d3-2f54917892ce@kernel.org \
--to=vgupta@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®