mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
To: "idryomov@gmail.com" <idryomov@gmail.com>,
	Xiubo Li <xiubli@redhat.com>,
	"linux@treblig.org" <linux@treblig.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re:  [PATCH] ceph: osd_client deadcode
Date: Mon, 24 Feb 2025 19:55:29 +0000	[thread overview]
Message-ID: <5939f53e1f928e20d67b8e6fa06d6ce9a0b8a9ae.camel@ibm.com> (raw)
In-Reply-To: <20250222013530.171376-1-linux@treblig.org>

On Sat, 2025-02-22 at 01:35 +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> osd_req_op_extent_osd_data_pagelist() was added in 2013 as part of
> commit a4ce40a9a7c1 ("libceph: combine initializing and setting osd data")
> but never used.
> 
> The last use of osd_req_op_cls_request_data_pagelist() was removed in
> 2017's
> commit ecd4a68a26a2 ("rbd: switch rbd_obj_method_sync() to
> ceph_osdc_call()")
> 
> Remove them.
> 

If we don't use these methods, then it makes sense to remove it. We can take
them back in the case of real necessity in this functionality.

Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>

Thanks,
Slava.


      reply	other threads:[~2025-02-24 19:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-22  1:35 linux
2025-02-24 19:55 ` Viacheslav Dubeyko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5939f53e1f928e20d67b8e6fa06d6ce9a0b8a9ae.camel@ibm.com \
    --to=slava.dubeyko@ibm.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=xiubli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®