From: Mark yao <mark.yao@rock-chips.com>
To: Archit Taneja <architt@codeaurora.org>,
David Airlie <airlied@linux.ie>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx
Date: Fri, 9 Jun 2017 12:03:31 +0800 [thread overview]
Message-ID: <593A1E13.70501@rock-chips.com> (raw)
In-Reply-To: <1496976343-30005-1-git-send-email-mark.yao@rock-chips.com>
Ignore this patch, Jose has a better patch to solve rk3399 hdmi phy
configure.
Hi Jose
Sorry for missing your patch about hdmi 2.0 vendor phy fixup:
https://patchwork.kernel.org/patch/9702229
It works fine on rk3399/rk3288, can you resend a standard patch to upstream?
Thanks
On 2017年06月09日 10:45, Mark Yao wrote:
> So dw-hdmi vendor driver can reuse hdmi_phy_configure_dwc_hdmi_3d_tx
> to configure their hardware.
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++-
> include/drm/bridge/dw_hdmi.h | 3 +++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 4e1f54a..c1ceec7 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1097,7 +1097,7 @@ static int dw_hdmi_phy_power_on(struct dw_hdmi *hdmi)
> * information the DWC MHL PHY has the same register layout and is thus also
> * supported by this function.
> */
> -static int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi,
> +int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi,
> const struct dw_hdmi_plat_data *pdata,
> unsigned long mpixelclock)
> {
> @@ -1146,6 +1146,7 @@ static int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi,
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(hdmi_phy_configure_dwc_hdmi_3d_tx);
>
> static int hdmi_phy_configure(struct dw_hdmi *hdmi)
> {
> diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h
> index ed599be..7eb67e6 100644
> --- a/include/drm/bridge/dw_hdmi.h
> +++ b/include/drm/bridge/dw_hdmi.h
> @@ -150,6 +150,9 @@ int dw_hdmi_probe(struct platform_device *pdev,
> int dw_hdmi_bind(struct platform_device *pdev, struct drm_encoder *encoder,
> const struct dw_hdmi_plat_data *plat_data);
>
> +int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi,
> + const struct dw_hdmi_plat_data *pdata,
> + unsigned long mpixelclock);
> void dw_hdmi_setup_rx_sense(struct device *dev, bool hpd, bool rx_sense);
>
> void dw_hdmi_set_sample_rate(struct dw_hdmi *hdmi, unsigned int rate);
--
Mark Yao
next prev parent reply other threads:[~2017-06-09 4:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 2:41 [PATCH v2 0/4] Add RK3399 HDMI Support Mark Yao
2017-06-09 2:45 ` [PATCH 1/4] drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx Mark Yao
2017-06-09 4:03 ` Mark yao [this message]
2017-06-09 8:37 ` Jose Abreu
2017-06-09 3:05 ` [PATCH v2 2/4] drm/rockchip: dw_hdmi: add RK3399 HDMI support Mark Yao
2017-06-09 3:18 ` [PATCH v2 3/4] drm/rockchip: dw_hdmi: introduce the VPLL clock setting Mark Yao
2017-06-09 3:18 ` [PATCH v2 4/4] drm/rockchip: dw_hdmi: introduce the pclk for grf Mark Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593A1E13.70501@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=Jose.Abreu@synopsys.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome