From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D58C433DF for ; Tue, 30 Jun 2020 14:34:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85B6A20672 for ; Tue, 30 Jun 2020 14:34:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388947AbgF3OeD (ORCPT ); Tue, 30 Jun 2020 10:34:03 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:34220 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726576AbgF3OeC (ORCPT ); Tue, 30 Jun 2020 10:34:02 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 7ACC42A4ED6 Subject: Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge To: Sam Ravnborg Cc: linux-kernel@vger.kernel.org, Collabora Kernel ML , Chun-Kuang Hu , Jernej Skrabec , drinkcat@chromium.org, Jonas Karlman , David Airlie , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Neil Armstrong , Andrzej Hajda , linux-mediatek@lists.infradead.org, Laurent Pinchart , hsinyi@chromium.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org References: <20200615203108.786083-1-enric.balletbo@collabora.com> <20200620213302.GC74146@ravnborg.org> From: Enric Balletbo i Serra Message-ID: <593a4666-d6aa-7d16-f3a0-ba3713047d84@collabora.com> Date: Tue, 30 Jun 2020 16:33:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200620213302.GC74146@ravnborg.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, Chun-Kuan, On 20/6/20 23:33, Sam Ravnborg wrote: > Hi Enric > > On Mon, Jun 15, 2020 at 10:31:01PM +0200, Enric Balletbo i Serra wrote: >> (This resend is to fix some trivial conflicts due the merge window) >> >> The PS8640 dsi-to-eDP bridge driver is using the panel bridge API, >> however, not all the components in the chain have been ported to the >> drm_bridge API. Actually, when a panel is attached the default panel's mode >> is used, but in some cases we can't get display up if mode getting from >> eDP control EDID is not chosen. >> >> This series address that problem, first implements the .get_edid() >> callback in the PS8640 driver (which is not used until the conversion is >> done) and then, converts the Mediatek DSI driver to use the drm_bridge >> API. >> >> As far as I know, we're the only users of the mediatek dsi driver in >> mainline, so should be safe to switch to the new chain of drm_bridge API >> unconditionally. >> >> The patches has been tested on a Acer Chromebook R13 (Elm) running a >> Chrome OS userspace and checking that the valid EDID mode reported by >> the bridge is selected. >> >> Changes in v4: >> - Remove double call to drm_encoder_init(). (Chun-Kuang Hu) >> - Cleanup the encoder in mtk_dsi_unbind(). (Chun-Kuang Hu) >> >> Changes in v3: >> - Replace s/bridge/next bridge/ for comment. (Laurent Pinchart) >> - Add the bridge.type. (Laurent Pinchart) >> - Use next_bridge field to store the panel bridge. (Laurent Pinchart) >> - Add the bridge.type field. (Laurent Pinchart) >> - This patch requires https://lkml.org/lkml/2020/4/16/2080 to work >> properly. >> - Move the bridge.type line to the patch that adds drm_bridge support. (Laurent Pinchart) >> >> Changes in v2: >> - Do not set connector_type for panel here. (Sam Ravnborg) >> >> Enric Balletbo i Serra (7): >> drm/bridge: ps8640: Get the EDID from eDP control >> drm/bridge_connector: Set default status connected for eDP connectors >> drm/mediatek: mtk_dsi: Rename bridge to next_bridge >> drm/mediatek: mtk_dsi: Convert to bridge driver >> drm/mediatek: mtk_dsi: Use simple encoder >> drm/mediatek: mtk_dsi: Use the drm_panel_bridge API >> drm/mediatek: mtk_dsi: Create connector for bridges > > Patch seems ready to apply. Will they be applied to a mediatek tree > or to drm-misc-next? > Or shall we take the first two patches via drm-misc-next, and the > remaning via a mediatek tree? (I hope not) > I think the only concern is from Chun-Kuan regarding patch 7/7 "drm/mediatek: mtk_dsi: Create connector for bridges" whether we should support the old API or not, but the discussion stalled. Thanks, Enric > Sam > > >> >> drivers/gpu/drm/bridge/parade-ps8640.c | 12 ++ >> drivers/gpu/drm/drm_bridge_connector.c | 1 + >> drivers/gpu/drm/mediatek/mtk_dsi.c | 269 ++++++++----------------- >> 3 files changed, 97 insertions(+), 185 deletions(-) >> >> -- >> 2.27.0 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel >