From: Yuanfang Zhang <quic_yuanfang@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: <kernel@quicinc.com>, <linux-kernel@vger.kernel.org>,
<coresight@lists.linaro.org>,
<linux-arm-kernel@lists.infradead.org>, <kernel@oss.qualcomm.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/5] dt-bindings: arm: Add Coresight device Trace NOC definition
Date: Wed, 26 Feb 2025 18:52:11 +0800 [thread overview]
Message-ID: <593e1777-a033-4922-93c4-c056e6b9bf4c@quicinc.com> (raw)
In-Reply-To: <edfd6c6a-65d2-42f1-8225-0808359dd375@kernel.org>
On 2/22/2025 6:47 PM, Krzysztof Kozlowski wrote:
> On 21/02/2025 08:40, Yuanfang Zhang wrote:
>> Adds new coresight-tnoc.yaml file describing the bindings required
>> to define Trace NOC in the device trees.
>>
>> Signed-off-by: Yuanfang Zhang <quic_yuanfang@quicinc.com>
>
>
> So you just sent the same v1, ignoring previous review. That's not how
> it works.
>
sorry for this incorrect process. because i just update --to-cc list and no other
change, i forced the version to V1, hoped it would work like resend,
but the result was not as expected.
> Provide proper changelog, implement ENTIRE feedback and do no ask
> maintainers do point the same issues TWICE.
>
> NAK
>
> <form letter>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
>
> Thank you.
> </form letter>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2025-02-26 10:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 7:40 [PATCH 0/5] coresight: Add Coresight Trace NOC driver Yuanfang Zhang
2025-02-21 7:40 ` [PATCH 1/5] dt-bindings: arm: Add Coresight device Trace NOC definition Yuanfang Zhang
2025-02-21 23:53 ` Rob Herring
2025-02-28 7:20 ` Yuanfang Zhang
2025-02-22 10:47 ` Krzysztof Kozlowski
2025-02-26 10:52 ` Yuanfang Zhang [this message]
2025-02-26 11:07 ` Krzysztof Kozlowski
2025-02-28 7:29 ` Yuanfang Zhang
2025-02-21 7:40 ` [PATCH 2/5] coresight: add coresight Trace NOC driver Yuanfang Zhang
2025-02-22 10:54 ` Krzysztof Kozlowski
2025-02-26 10:44 ` Yuanfang Zhang
2025-02-21 7:40 ` [PATCH 3/5] coresight-tnoc: add nodes to configure flush Yuanfang Zhang
2025-02-21 7:40 ` [PATCH 4/5] coresight-tnoc: add node to configure flag type Yuanfang Zhang
2025-02-22 10:55 ` Krzysztof Kozlowski
2025-02-28 7:44 ` Yuanfang Zhang
2025-02-21 7:40 ` [PATCH 5/5] coresight-tnoc: add nodes to configure freq packet Yuanfang Zhang
-- strict thread matches above, loose matches on Subject: below --
2025-02-20 9:41 [PATCH 0/5] coresight: Add Coresight Trace NOC driver Yuanfang Zhang
2025-02-20 9:41 ` [PATCH 1/5] dt-bindings: arm: Add Coresight device Trace NOC definition Yuanfang Zhang
2025-02-20 12:25 ` Krzysztof Kozlowski
2025-02-26 11:01 ` Yuanfang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593e1777-a033-4922-93c4-c056e6b9bf4c@quicinc.com \
--to=quic_yuanfang@quicinc.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=kernel@oss.qualcomm.com \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®