From: shaozhengchao <shaozhengchao@huawei.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<jhs@mojatatu.com>, <jiri@resnulli.us>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net-next] net: sched: red: remove unused input parameter in red_get_flags()
Date: Mon, 29 Aug 2022 09:26:47 +0800 [thread overview]
Message-ID: <59402dc4-ee21-940e-ea24-0bffdbed8d48@huawei.com> (raw)
In-Reply-To: <Ywpmky1B0oh+KQgU@pop-os.localdomain>
On 2022/8/28 2:46, Cong Wang wrote:
> On Sat, Aug 27, 2022 at 12:35:45PM +0800, Zhengchao Shao wrote:
>> The input parameter supported_mask is unused in red_get_flags().
>> Remove it.
>>
>
> It looks like this is incomplete code unification of the following
> commit:
>
> commit 14bc175d9c885c86239de3d730eea85ad67bfe7b
> Author: Petr Machata <petrm@mellanox.com>
> Date: Fri Mar 13 01:10:56 2020 +0200
>
> net: sched: Allow extending set of supported RED flags
>
> How about completing it? ;)
>
> Thanks.
Hi Wang：
Thank you for your reply. Your suggestion is good. I will try to
complete it later.
Zhengchao Shao
prev parent reply other threads:[~2022-08-29 1:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 4:35 Zhengchao Shao
2022-08-27 18:46 ` Cong Wang
2022-08-29 1:26 ` shaozhengchao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59402dc4-ee21-940e-ea24-0bffdbed8d48@huawei.com \
--to=shaozhengchao@huawei.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®