From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D8AF3E715A for ; Thu, 18 Jun 2026 10:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781778119; cv=none; b=Hc8+BVDa+eb8LFIvPg3lV9ibKi/AXjeKuDWi/9bhV6J5aUbQ1+fRvIG9qxs27bAsgImTcwbnupzmpySBIBbe9xv0lbzahI2RryqR6+sd+o0WFc22BKbu93dP70716peCUx5R4WOP9Gd0ahgiHcnGkp+x2KJE5NEQ9r1/0dzD7x4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781778119; c=relaxed/simple; bh=9a5003MjZGw/1MmHACvoJ7ldPOZzbWMfDVJ1FnfmyPg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fidZfnKKbqptG8baflVSZLUAKjCWWIHEihc+KrfoKUppHyUJQG55izIMVItadickTQz8WA/VijSjEd7b7jJdSClMqnOiNjaUt2B9ptnIBge00zcIUzaI1UxtgD+ox0ad4ngWb1JEJE60Cxlf9wPJAoIQldrolivy8Mw+VLfCOqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ap1htXgQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RQnngxgl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ap1htXgQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RQnngxgl" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65I8Dd9v3399949 for ; Thu, 18 Jun 2026 10:21:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yguuY96oSyrx72CHQn/bAXUqMvwHJj3BB8K1pDGSEVU=; b=Ap1htXgQBZSykc1o CPuO4BCOfka68GanqAzqZy1M4/zgSSo+6TeZH3LdjSCcrxoxGYYmwwB3ZSwYj+uj QZoEIMWJPu/lN6+Rtai/zV424VraOAIKzGbwLATpm0YN8/kLooCeMW8cR6PkzSTB h3BIC8/GH707ASO0tDYgpC3uDyOdfjZMhIp0EbqG5Ni9FogquCFIIDpih5KsqI83 eJe/b3oP3TNSa3YguQewsaBSVz0WFy0Z8D+9x17iRkENq8mTXM3/tHGjEo5e8ZPF 0kTNZ40WtBNP2o0h9rmwr/T6Z2hPxGRJdg/mGbOHH/VHSKhHQ4WgKrhxLXXcjETU abeRSQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ev0vk2xj0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Jun 2026 10:21:51 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84540d59430so430959b3a.0 for ; Thu, 18 Jun 2026 03:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781778111; x=1782382911; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yguuY96oSyrx72CHQn/bAXUqMvwHJj3BB8K1pDGSEVU=; b=RQnngxglmeHt651IzuV7yQe9MKRhUW4jfqjTcWN/kLUtWZe2rg6vNzsRaie9mkF70W gu5cP3VORTlj+/z+UwrpIGdAb2AcvZCjWcFnPXB1e9flG/X2IRM5F5WPwKo4LwuE41iB EWI6xgb5/u28MZC6AJl75eUiGHW85tg8snH3T5dDy7sfxdjvDytXhdenniKWm6y42gOM apkG8AX5L99E9+qQRngtBB6xULIvYL7mUrgagDcKy+w/CPv/ykEEYH9RO1LkD0vdtzZ/ 9fWFcc5JcAIwvAqIVOyNu612mzkaBkPxSMl1b75IMY0WnsfGQrbFc5MPcjjyCgqlBz4h QZ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781778111; x=1782382911; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yguuY96oSyrx72CHQn/bAXUqMvwHJj3BB8K1pDGSEVU=; b=G2Q4tGdGWbJCA8YVujszyfNQq5QJ74RpW25j7SyZSO9mdI+Upk/v9zjZTdTmSkHTTr XYdKex1TyDmNebiSGbO70lmB4LJGJoF2PEMgK9LoTKJ5Gfbyg6yRA/RY4BoPGIhLm6Q7 T3fh1swvz81rLLr9k4Ll/56JN1Ybs/Z32MgvmMKf8Msd/b7xSf/nTCX6TeF4FO4v7u9T XgOn0aKMI9ywRzShVDbPwF3pBGYX+7LzOyMJLprkm8hDq07KaqukKupKwnozNSgC+xyK +7JAszrRgc/jDcWNHxQsMwBRBeLrtTeEqCiXXtELvOxq6L4ScIaVT24Qx86G+T10LPvX fKNA== X-Forwarded-Encrypted: i=1; AFNElJ/gRF7aR79wseYbAojrFsWeF62b0PsFfYLZn/GXZwL46sJrWsE3R6qirw3DFgy3uMRls1bEQigpVeSYaJc=@vger.kernel.org X-Gm-Message-State: AOJu0YyxgBz/VJNLWJb28X9i5K7B/wwBhktCQyhBNpNkzNjcJ4hc6Ln1 RHpdNz979nkjE3yNWZ+6gZpfUqWSVJ2Gj19RkmsZHBP5f647qKQ4jkePCRX+FiLF7KvmVHT+5gr /mGfrSvaetBwVB2FeXuJdBoHq7LzgIpVVX5UfKenWTfeVuReeirha14AIEwx7cJwwxgyMrQvjGa I= X-Gm-Gg: AfdE7cmwfHcItJ7eIngVdbgDfV0P23Oc1tcAnEJmuQVBYB04P4A/egcAUXNGNtU84Zy SwmDVsumbp86q2VVGofsuoxxIKIyHFmdvRr+yTwXlz5eN5cJUnPpgL8CCZ+O5Tedyzg28iykv+D /k9LC2gkSnCu3HRuk8J3kXRK8UCiY9NfIMi4go4aprCrWS5Z0omPb91u5FYnE0Qoukv2mzX24Ua P0EwqIWBF6Rd10hOcC4uI49iNKvh6uE/SqO41nwx97D7xkBwqolLEPbsTgisnrcoeY+typvK4ID se1gY+GSLw31FX61D9AfitBgs/VjEMfSmjJa9ztOm1AjU05YvyuFDMwGmHdZy4ZXRZqe4SOOPWx B6exF6Ie3FvTsO8guWabdwmlmyAf+twDYf3xazZay X-Received: by 2002:a05:6a00:b41:b0:845:42b9:60a9 with SMTP id d2e1a72fcca58-84542b96779mr1977665b3a.38.1781778110592; Thu, 18 Jun 2026 03:21:50 -0700 (PDT) X-Received: by 2002:a05:6a00:b41:b0:845:42b9:60a9 with SMTP id d2e1a72fcca58-84542b96779mr1977632b3a.38.1781778110132; Thu, 18 Jun 2026 03:21:50 -0700 (PDT) Received: from [10.218.7.34] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434b055095sm22715971b3a.57.2026.06.18.03.21.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 03:21:49 -0700 (PDT) Message-ID: <5941078e-2376-46a4-b9e2-9686de1ca991@oss.qualcomm.com> Date: Thu, 18 Jun 2026 15:51:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: qcom: lemans-pmics: Add ADC support for PMM8654au To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayyagari Ushasreevalli , Kamal Wadhwa References: <20260430-adc5_gen3_dt-v1-0-ab2bb40fd490@oss.qualcomm.com> <20260430-adc5_gen3_dt-v1-2-ab2bb40fd490@oss.qualcomm.com> <57f3407f-3371-4db7-87cc-218f7360ce3f@oss.qualcomm.com> Content-Language: en-US From: Jishnu Prakash In-Reply-To: <57f3407f-3371-4db7-87cc-218f7360ce3f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: SLCypsc2LIeW-2o0p18dxCd9NQCHNMlN X-Authority-Analysis: v=2.4 cv=DNy/JSNb c=1 sm=1 tr=0 ts=6a33c6bf cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=-7KxEBqrqmoxkvx5lt4A:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: SLCypsc2LIeW-2o0p18dxCd9NQCHNMlN X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDA5NiBTYWx0ZWRfX/vNzXL5Aktqn s2ZONki4/sCoJfGJLicRw2DR8SGoW2v85wahaJxwIvvbif2F5XsNzvnVfCZrkbg/eUX6i79Ymp1 rxEofcBK6BtsJOUbkxBZyGFqQn1G+NY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDA5NiBTYWx0ZWRfX4458MojV4l4W xRZ4zTW2FsKkytckWJYEX2jjcDAmbiNnghTklhgEYqvATHrdHDZ8MwKShHWM+icoXRlcJskLved RO2PClJeiy379ZSlbAWatTIGaPUkdCBSOmodwt3tIf4nqxaC3o+KqtDT0CeOgpgg3phRMNMBlxr 23TZ9vvWv+mX23sqgHPMiNVWZOH4sgRyk/aLCWep8NU58D8k6pcmycFl/auyNDFuAl5iFhhubUF m8Wy1Pyh1O1Et7/JYST+5B5+EGoXREDCDaUnP4815zPOtUt60rbFogpBufgYR2VOZaNoWa/GOmg 5hHzFF86EHI+WDiATNJtPz1gymQ1XFTSIJMjPSj3bFSpFtH7WyjRdDbgo6j9f1x1yz3zL1mlWH3 yO35xcyWxLwBUyCiTyG1vHiPPcvoKEsUkK6a/yyOoGdr9sLojf+07HLZRAw//9sR/ctRoHugPqY rc4qvZx4WSMVXj4jY4A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-18_01,2026-06-17_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180096 Hi Konrad, On 6/15/2026 9:26 PM, Konrad Dybcio wrote: > On 4/30/26 10:58 AM, Jishnu Prakash wrote: >> From: Ayyagari Ushasreevalli >> >> Add ADC nodes for the four PMM8654au PMICs (pmm8654au_0 through >> pmm8654au_3) on the Lemans platform. >> >> Each ADC node exposes the following ADC channels: >> - DIE_TEMP: PMIC die temperature channel >> - VPH_PWR: Battery/supply voltage channel >> >> Also add the io-channels and io-channel-names properties under >> the temp-alarm nodes so that they can get temperature reading >> from the ADC die_temp channels. >> >> Signed-off-by: Ayyagari Ushasreevalli >> Signed-off-by: Jishnu Prakash >> --- >> arch/arm64/boot/dts/qcom/lemans-pmics.dtsi | 93 ++++++++++++++++++++++++++++++ >> 1 file changed, 93 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi >> index 341119fc8244..6caec3e4df4b 100644 >> --- a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi >> +++ b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi >> @@ -5,6 +5,7 @@ >> >> #include >> #include >> +#include "qcom-adc5-gen3.h" >> >> / { >> thermal-zones { >> @@ -110,6 +111,8 @@ pmm8654au_0_temp_alarm: temp-alarm@a00 { >> reg = <0xa00>; >> interrupts-extended = <&spmi_bus 0x0 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; >> #thermal-sensor-cells = <0>; >> + io-channels = <&pmm8654au_0_adc ADC5_GEN3_DIE_TEMP(0)>; >> + io-channel-names = "thermal"; >> }; >> >> pmm8654au_0_pon: pon@1200 { >> @@ -141,6 +144,27 @@ pmm8654au_0_rtc: rtc@6100 { >> interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>; >> }; >> >> + pmm8654au_0_adc: adc@8000 { >> + compatible = "qcom,spmi-adc5-gen3"; >> + reg = <0x8000>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + interrupts = <0x0 0x80 0x1 IRQ_TYPE_EDGE_RISING>; >> + #io-channel-cells = <1>; >> + >> + channel@3 { >> + reg = ; >> + label = "pmm8654au_0_die_temp"; > > Are these labels namespaced, i.e. can the label be just "pm8654au_die_temp" > or "die_temp"? >From what I see, there's no functional issue with updating the label to either of the names you suggested. We made it this way at first as we thought it would be useful to have the exact PMIC instance name in the label of each channel. Do you want any changes in the labels? If yes, which convention do you prefer? Thanks, Jishnu > > Konrad