From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428278AbdDYIMT (ORCPT ); Tue, 25 Apr 2017 04:12:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55398 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1176424AbdDYIIl (ORCPT ); Tue, 25 Apr 2017 04:08:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 936FD61342 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org Subject: Re: [PATCH] phy: qcom-qmp: fix noderef.cocci warnings To: Kishon Vijay Abraham I References: <201704062348.e3H0T60V%fengguang.wu@intel.com> <20170406155859.GA313@lkp-wsm-ep1> Cc: kbuild test robot , kbuild-all@01.org, Stephen Boyd , Wei Yongjun , "linux-kernel@vger.kernel.org" From: Vivek Gautam Message-ID: <5942f3d9-cd6b-d06c-c1f4-990566fb3a9d@codeaurora.org> Date: Tue, 25 Apr 2017 13:38:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170406155859.GA313@lkp-wsm-ep1> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, On 04/06/2017 09:28 PM, kbuild test robot wrote: > drivers/phy/phy-qcom-qmp.c:847:37-43: ERROR: application of sizeof to pointer > > sizeof when applied to a pointer typed expression gives the size of > the pointer > > Generated by: scripts/coccinelle/misc/noderef.cocci > > CC: Vivek Gautam > Signed-off-by: Fengguang Wu > --- Reviewed-by: Vivek Gautam This patch got missed. Please consider pulling it in along with one more patch [1] from Wei Yongjun. [1] https://lkml.org/lkml/2017/4/24/1080 Best Regards Vivek > > phy-qcom-qmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/phy/phy-qcom-qmp.c > +++ b/drivers/phy/phy-qcom-qmp.c > @@ -844,7 +844,7 @@ static int qcom_qmp_phy_vreg_init(struct > int num = qmp->cfg->num_vregs; > int i; > > - qmp->vregs = devm_kcalloc(dev, num, sizeof(qmp->vregs), GFP_KERNEL); > + qmp->vregs = devm_kcalloc(dev, num, sizeof(*qmp->vregs), GFP_KERNEL); > if (!qmp->vregs) > return -ENOMEM; > -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project