From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Colin Foster" <colin.foster@in-advantage.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Jeff LaBundy" <jeff@labundy.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: mfd: Correct indentation and style in DTS example
Date: Tue, 25 Mar 2025 12:28:31 +0100 [thread overview]
Message-ID: <5946b0aa-ffdd-4269-b8f4-d1db1aa88493@linaro.org> (raw)
In-Reply-To: <CAMuHMdXkePsSX62+OyT8aTdqFfaNy9dGRM73Q5AuQ_pHTBi8Kg@mail.gmail.com>
On 24/03/2025 14:31, Geert Uytterhoeven wrote:
>> - pwmleds {
>> - compatible = "pwm-leds";
>> -
>> - led-1 {
>> - pwms = <&iqs620a_pwm 0 1000000>;
>> - max-brightness = <255>;
>> + iqs620a_pwm: pwm {
>> + compatible = "azoteq,iqs620a-pwm";
>> + #pwm-cells = <2>;
>> };
>> + };
>> };
>>
>> - |
>
> The removal of the pwmleds node belongs in patch [1/2].
> The rest LGTM.
True, I lost it in the context. Thanks.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-03-25 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 12:52 [PATCH 1/2] dt-bindings: mfd: Drop unrelated nodes from " Krzysztof Kozlowski
2025-03-24 12:52 ` [PATCH 2/2] dt-bindings: mfd: Correct indentation and style in " Krzysztof Kozlowski
2025-03-24 13:31 ` Geert Uytterhoeven
2025-03-25 11:28 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5946b0aa-ffdd-4269-b8f4-d1db1aa88493@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=colin.foster@in-advantage.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=j.neuschaefer@gmx.net \
--cc=jeff@labundy.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®