mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Herbert <Marc.Herbert@intel.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Thiago Macieira <thiago.macieira@intel.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Guenter Roeck <groeck@google.com>,
	Wayne Boyer <wayne.boyer@intel.com>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] Remove silentoldconfig from "make help"; fix kconfig/conf's help
Date: Fri, 26 Jan 2018 15:00:44 -0800	[thread overview]
Message-ID: <594ca2cb-5a21-2bba-4132-73d42f3a909a@intel.com> (raw)
In-Reply-To: <CAK7LNAQA8gB1iijS5uoVFdVc-UoyyAQN+N8GvXpw9aR7Jp8dyA@mail.gmail.com>

Masahiro,

On 17/01/2018 20:31, Masahiro Yamada wrote: 

> Sorry for my late reply.

I think we're even now :-)

>> I'd like to keep that sentence because it's there to explain the legacy and
>> confusing "--silentoldconfig" name which unfortunately still sticks out in
>> the *current* conf.c interface.
>>
>> +       printf("  --silentoldconfig       Similar to oldconfig but generates configuration in\n"
>> +              "                          include/{generated/,config/} (oldconfig used to be more verbose)\n");
>>
>> The purpose of this sentence is to warn people that: "silentoldconfig is
>> just archeology, so you can safely ignore it" and save them time.
>>
>> The alternative I considered was to entirely remove "silentconfig" not just
>> from the Makefile's help but from the conf.c help too.
 
> 
> Another possibility might be to rename 'silentoldconfig'.
> instead of explaining the background in the help message.
> [...]
> It is difficult to suggest a clear name,
> but 'syncconfig' is the one I came up with.
> 
> Please suggest if you have a better idea.

Look like a good idea and name to me but... for a different, bigger
and later commit.

> Commit fb16d8912db5268f29706010ecafff74b971c58d
> renamed oldnoconfig to olddefconfig...

... but it didn't remove any "now internal API" from "make help". Instead it
changed the name of an external and preserved "API".

> If we worry about the compatibility just in case,
> we can keep 'silentoldconfig' as an alias as well.

Yes - but later?

In the meantime I found another instance of silentoldconfig in
Documentation/admin-guide/; posting v3 with that removed too.
I'm also adding some deprecation comments in the source.

-- 
Marc

  reply	other threads:[~2018-01-26 23:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19  1:26 Marc Herbert
2018-01-04 17:21 ` Masahiro Yamada
2018-01-05 22:21   ` Marc Herbert
2018-01-10  7:17     ` Masahiro Yamada
2018-01-12 22:49       ` Marc Herbert
2018-01-18  4:31         ` Masahiro Yamada
2018-01-26 23:00           ` Marc Herbert [this message]
2018-01-28  1:28             ` Masahiro Yamada
2018-01-18  1:41 ` [PATCH v2] " Marc Herbert
2018-01-26 22:59 ` [PATCH v3] Remove silentoldconfig from help and docs; " Marc Herbert
2018-01-28  1:40   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=594ca2cb-5a21-2bba-4132-73d42f3a909a@intel.com \
    --to=marc.herbert@intel.com \
    --cc=groeck@google.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=sam@ravnborg.org \
    --cc=thiago.macieira@intel.com \
    --cc=wayne.boyer@intel.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®