From: "Jan Beulich" <JBeulich@suse.com>
To: "Juergen Gross" <jgross@suse.com>
Cc: <xen-devel@lists.xenproject.org>, <boris.ostrovsky@oracle.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory initially
Date: Mon, 03 Jul 2017 10:11:14 -0600 [thread overview]
Message-ID: <595A88C202000078001680C2@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20170703154037.17851-1-jgross@suse.com>
>>> On 03.07.17 at 17:40, <jgross@suse.com> wrote:
> --- a/drivers/xen/xen-balloon.c
> +++ b/drivers/xen/xen-balloon.c
> @@ -59,6 +59,8 @@ static void watch_target(struct xenbus_watch *watch,
> {
> unsigned long long new_target;
> int err;
> + static bool watch_fired;
> + static unsigned long target_diff;
It would seem to me that the types of target_diff and new_target
should match in width, but differ in signedness.
Jan
next prev parent reply other threads:[~2017-07-03 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 15:40 Juergen Gross
2017-07-03 16:11 ` Jan Beulich [this message]
[not found] ` <595A88C202000078001680C2@suse.com>
2017-07-03 16:16 ` [Xen-devel] " Juergen Gross
2017-07-03 18:44 ` Igor Druzhinin
2017-07-04 5:42 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595A88C202000078001680C2@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®