From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbdGEPv6 convert rfc822-to-8bit (ORCPT ); Wed, 5 Jul 2017 11:51:58 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:46112 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbdGEPv5 (ORCPT ); Wed, 5 Jul 2017 11:51:57 -0400 Message-Id: <595D273A0200007800168CFF@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.2 Date: Wed, 05 Jul 2017 09:51:54 -0600 From: "Jan Beulich" To: "Juergen Gross" Cc: , , Subject: Re: [Xen-devel] [PATCH v2] xen/balloon: don't online new memory initially References: <20170705153806.23488-1-jgross@suse.com> In-Reply-To: <20170705153806.23488-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 05.07.17 at 17:38, wrote: > @@ -94,22 +103,15 @@ static struct notifier_block xenstore_notifier = { > .notifier_call = balloon_init_watcher, > }; > > -static int __init balloon_init(void) > +void __init xen_balloon_init(void) > { > - if (!xen_domain()) > - return -ENODEV; > - > - pr_info("Initialising balloon driver\n"); > - > register_balloon(&balloon_dev); > > register_xen_selfballooning(&balloon_dev); > > register_xenstore_notifier(&xenstore_notifier); > - > - return 0; > } > -subsys_initcall(balloon_init); > +EXPORT_SYMBOL_GPL(xen_balloon_init); I'm sorry for not having paid attention at v1, but __init functions should not be exported (I would hope for you to actually see a warning with CONFIG_DEBUG_SECTION_MISMATCH=y). Jan