From: Krzysztof Kozlowski <krzk@kernel.org>
To: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, alexandre.belloni@bootlin.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH 2/8] ARM: dts: rockchip: Add i2s0 node for RV1126
Date: Sat, 24 Aug 2024 08:21:08 +0200 [thread overview]
Message-ID: <595a4009-ba70-44c1-b5a1-7a692624e196@kernel.org> (raw)
In-Reply-To: <20240823153528.3863993-3-karthikeyan@linumiz.com>
On 23/08/2024 17:35, Karthikeyan Krishnasamy wrote:
> Add i2s0 node and possible pinctrl for Rockchip RV1126
>
> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
> ---
> .../arm/boot/dts/rockchip/rv1126-pinctrl.dtsi | 102 ++++++++++++++++++
> arch/arm/boot/dts/rockchip/rv1126.dtsi | 26 +++++
> 2 files changed, 128 insertions(+)
...
> + i2s0m1_sdo1_sdi3: i2s0m1-sdo1_sdi3 {
> + rockchip,pins =
> + /* i2s0_sdo1_sdi3_m1 */
> + <3 RK_PB3 3 &pcfg_pull_none>;
> + };
> + i2s0m1_sdo2_sdi2: i2s0m1-sdo2_sdi2 {
> + rockchip,pins =
> + /* i2s0_sdo2_sdi2_m1 */
> + <3 RK_PB4 3 &pcfg_pull_none>;
Weird alignment...
> + };
> + i2s0m1_sdo3_sdi1: i2s0m1-sdo3_sdi1 {
No underscores in node names,
> + rockchip,pins =
> + /* i2s0_sdo3_sdi1_m1 */
> + <3 RK_PB5 3 &pcfg_pull_none>;
> + };
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-24 6:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 15:35 [PATCH 0/8] Add support Relfor Saib board which is based on Rockchip RV1109 SoC Karthikeyan Krishnasamy
2024-08-23 15:35 ` [PATCH 1/8] ARM: dts: rockchip: Add i2c3 node for RV1126 Karthikeyan Krishnasamy
2024-08-23 15:35 ` [PATCH 2/8] ARM: dts: rockchip: Add i2s0 " Karthikeyan Krishnasamy
2024-08-24 6:21 ` Krzysztof Kozlowski [this message]
2024-08-23 15:35 ` [PATCH 3/8] ARM: dts: rockchip: Add pwm " Karthikeyan Krishnasamy
2024-08-23 15:35 ` [PATCH 4/8] ARM: dts: rockchip: Add watchdog " Karthikeyan Krishnasamy
2024-08-23 15:35 ` [PATCH 5/8] Documentation: bindings: rtc: add clock-cells property Karthikeyan Krishnasamy
2024-08-23 16:24 ` Conor Dooley
2024-08-24 1:58 ` Alexandre Belloni
2024-08-23 15:35 ` [PATCH 6/8] dt-bindings: vendor-prefixes: Add Relfor labs Karthikeyan Krishnasamy
2024-08-23 16:22 ` Conor Dooley
2024-08-23 15:35 ` [PATCH 7/8] dt-bindings: arm: rockchip: Add Relfor Saib Karthikeyan Krishnasamy
2024-08-23 16:21 ` Conor Dooley
2024-08-24 12:48 ` karthikeyan
2024-08-26 8:33 ` Krzysztof Kozlowski
2024-08-28 9:23 ` karthikeyan
2024-08-23 15:35 ` [PATCH 8/8] ARM: dts: rockchip: Add Relfor Saib board Karthikeyan Krishnasamy
2024-08-24 7:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595a4009-ba70-44c1-b5a1-7a692624e196@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=karthikeyan@linumiz.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®