From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Manivannan Sadhasivam <mani@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Asutosh Das <quic_asutoshd@quicinc.com>,
Bart Van Assche <bvanassche@acm.org>,
Stanley Chu <stanley.chu@mediatek.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Can Guo <quic_cang@quicinc.com>,
Nitin Rawat <quic_nitirawa@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC/RFT 1/5] ufs: ufs-qcom: Fix UFS base region name in MCQ case
Date: Tue, 8 Jul 2025 17:26:40 +0200 [thread overview]
Message-ID: <595c73aa-17e1-4d00-9cbe-abfff813546d@oss.qualcomm.com> (raw)
In-Reply-To: <xujhcaw2nj7mzb4cspjsxem75lqfwa7ivnfpzccor7npdu5d7c@xad5hx4b2m4e>
On 7/8/25 12:34 PM, Manivannan Sadhasivam wrote:
> On Fri, Jul 04, 2025 at 07:36:09PM GMT, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> There is no need to reinvent the wheel. There are no users yet, and the
>> dt-bindings were never updated to accommodate for this, so fix it while
>> we still easily can.
>>
>
> What are you fixing here? Please be explicit. "std" region is not at all in the
> device memory map? Or it was present in some earlier ones and removed in the
> final tape out version?
>
> - Mani
I simply failed to describe the issue.
As of today, the MCQ code refers to the region that our bindings call
"std" by the name "ufs_mem" (which this patch fixes).
Totally same thing in hardware, but it would obviously not work without
DT changes (which would be rightfully rejected as there is no reason to
change the name).
Konrad
next prev parent reply other threads:[~2025-07-08 15:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 17:36 [RFC/RFT PATCH 0/5] Clean up UFS(-qcom) MCQ situation Konrad Dybcio
2025-07-04 17:36 ` [PATCH RFC/RFT 1/5] ufs: ufs-qcom: Fix UFS base region name in MCQ case Konrad Dybcio
2025-07-07 17:50 ` Bart Van Assche
2025-07-08 10:34 ` Manivannan Sadhasivam
2025-07-08 15:26 ` Konrad Dybcio [this message]
2025-07-04 17:36 ` [PATCH RFC/RFT 2/5] ufs: ufs-qcom: Remove inferred MCQ mappings Konrad Dybcio
2025-07-07 17:51 ` Bart Van Assche
2025-07-08 15:29 ` Konrad Dybcio
2025-07-08 11:13 ` Manivannan Sadhasivam
2025-07-08 16:32 ` Konrad Dybcio
2025-07-04 17:36 ` [PATCH RFC/RFT 3/5] ufs: ufs-qcom: Don't try to map inexistent regions Konrad Dybcio
2025-07-04 17:36 ` [PATCH RFC/RFT 4/5] ufs: ufs-qcom: Rename "mcq_sqd" to "mcq_opr" Konrad Dybcio
2025-07-04 17:36 ` [PATCH RFC/RFT 5/5] ufs: ufs-qcom: Kill ufshcd_res_info Konrad Dybcio
2025-07-07 17:54 ` Bart Van Assche
2025-07-08 11:28 ` [RFC/RFT PATCH 0/5] Clean up UFS(-qcom) MCQ situation Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595c73aa-17e1-4d00-9cbe-abfff813546d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bvanassche@acm.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®