From: Arnd Bergmann <arnd@arndb.de>
To: Chao Xie <xiechao.mail@gmail.com>
Cc: Marek Vasut <marex@denx.de>, Chao Xie <chao.xie@marvell.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
drwyrm@gmail.com, stefan@openezx.org, laforge@openezx.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
sleep_walker@suse.cz, slapin@ossfans.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH V3 5/5] input: pxa27x-keypad: add device tree support
Date: Wed, 19 Jun 2013 11:25:26 +0200 [thread overview]
Message-ID: <5961561.7UgodVjTLY@wuerfel> (raw)
In-Reply-To: <CADApbeiQWOi8SYEFf0bOsf1yn+TgXhwgDWaWFpGk7+nbC9bNDg@mail.gmail.com>
On Wednesday 19 June 2013 16:38:38 Chao Xie wrote:
> >> index 0000000..f8674f7
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/input/pxa27x-keypad.txt
> >> @@ -0,0 +1,60 @@
> >> +* Marvell PXA Keypad controller
> >> +
> >> +Required Properties
> >> +- compatible : should be "marvell,pxa27x-keypad"
> >> +- reg : Address and length of the register set for the device
> >> +- interrupts : The interrupt for the keypad controller
> >> +- marvell,debounce-interval : How long time the key will be
> >
> > Is there no generic prop name for this debounce interval?
> >
> I searched at drivers/input and Documents.
> Two drivers use "debounce-interval", gpio-keys.c and stmpe-keypad.c.
> They describe the meanings of "debounce-interval" at its own document file.
> Some other drivers uses "xxx,debounce-delay-ms" or "debounce-delay-ms"
> So it seems that there is no generic prop name for this debounce interval.
I'd suggest using "debounce-interval" as in gpio-keys then, since that
is the most generic driver.
Arnd
next prev parent reply other threads:[~2013-06-19 9:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 3:56 [PATCH V3 0/5] input: pxa27x-keypad: enhancement and " Chao Xie
2013-06-18 3:56 ` [PATCH V3 1/5] input: pxa27x-keypad: use matrix_keymap for matrix keyes Chao Xie
2013-06-22 15:24 ` Mike Dunn
2013-06-18 3:56 ` [PATCH V3 2/5] arm: mmp: use matrix_keymap for all boards Chao Xie
2013-06-18 3:56 ` [PATCH V3 3/5] arm: pxa: " Chao Xie
2013-06-18 14:02 ` Arnd Bergmann
2013-06-22 15:26 ` Mike Dunn
2013-06-18 3:56 ` [PATCH V3 4/5] input: pxa27x-keypad: remove the unused members at platform data Chao Xie
2013-06-18 3:56 ` [PATCH V3 5/5] input: pxa27x-keypad: add device tree support Chao Xie
2013-06-19 8:22 ` Marek Vasut
2013-06-19 8:38 ` Chao Xie
2013-06-19 9:25 ` Arnd Bergmann [this message]
2013-06-19 11:13 ` Gerhard Sittig
2013-06-20 2:01 ` Chao Xie
2013-06-20 9:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5961561.7UgodVjTLY@wuerfel \
--to=arnd@arndb.de \
--cc=chao.xie@marvell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=drwyrm@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=laforge@openezx.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=robert.jarzmik@free.fr \
--cc=slapin@ossfans.org \
--cc=sleep_walker@suse.cz \
--cc=stefan@openezx.org \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome