From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CA312FEE02; Wed, 18 Jun 2025 16:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.155.224.40 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750265762; cv=none; b=IpVfQZlpjdUN0N0686qKbzjqh8UU5GHAvJb/ZgEJtdOU7ZilIyxgbmBj3IRmKYa6nQwnbSDb8kaoxrtvOhyixBSprUrS8PsS/KBW50X6oGzwcs2DRpK5REaWCVVsv7hBcshEDxOLue9xS/ZgburrYsvdw6bijjtBCevSDr52VlY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750265762; c=relaxed/simple; bh=45dfFt7/Lw+vYZ6FODYE896bX4frJlHHJRgCr3IatxI=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=UbujXoB5SMyHrXAokyGBJoTAdX90dhvelKzK7+zCBtjSUXFRevnTUD5DfTQGCF67Dl9KwzUAJAHjqthOtruxKZdfqhTq4/6oSHLTu34+9t7RcaNXdwohKOrxr8P5LU/wRQ4RshXGNF4bnwHNlVhsfu3x5UyQaonVNQBRyePFCL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=raptorengineering.com; spf=pass smtp.mailfrom=raptorengineering.com; dkim=pass (1024-bit key) header.d=raptorengineering.com header.i=@raptorengineering.com header.b=SG8+Ktpn; arc=none smtp.client-ip=23.155.224.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=raptorengineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raptorengineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=raptorengineering.com header.i=@raptorengineering.com header.b="SG8+Ktpn" Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 828C88286FBD; Wed, 18 Jun 2025 11:55:59 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0aUYil_3E0-H; Wed, 18 Jun 2025 11:55:58 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 88B968287179; Wed, 18 Jun 2025 11:55:58 -0500 (CDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 88B968287179 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1750265758; bh=lsH6Mcb5sOzQ2SC69uB9LMQwjmUITv6dqf33k1ZaAf0=; h=Date:From:To:Message-ID:MIME-Version; b=SG8+Ktpn6Q4bBiZ3ABXaM45t5s/V+sMoNCVSb0T9rxV1PPzYIoYLjKaXLaBLSAyY/ 5qwfBhof6dKUdiJuk0rFFbPkEmcEk3yfkjd76FJk04zGXTK75NibzVgEerXqrYaRra Bkvv+mo6EnYtnHZ71trKJYhcqqd6UJLdZHQWW0CA= X-Virus-Scanned: amavisd-new at rptsys.com Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Z7uLIchHfRBv; Wed, 18 Jun 2025 11:55:58 -0500 (CDT) Received: from vali.starlink.edu (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 59BA28286FBD; Wed, 18 Jun 2025 11:55:58 -0500 (CDT) Date: Wed, 18 Jun 2025 11:55:58 -0500 (CDT) From: Timothy Pearson To: Christoph Hellwig Cc: linuxppc-dev , linux-kernel , linux-pci , Madhavan Srinivasan , Michael Ellerman , christophe leroy , Naveen N Rao , Bjorn Helgaas , Shawn Anastasio Message-ID: <596516884.1310632.1750265758190.JavaMail.zimbra@raptorengineeringinc.com> In-Reply-To: <1728509613.1310543.1750263002144.JavaMail.zimbra@raptorengineeringinc.com> References: <946966095.1309769.1750220559201.JavaMail.zimbra@raptorengineeringinc.com> <1728509613.1310543.1750263002144.JavaMail.zimbra@raptorengineeringinc.com> Subject: Re: [PATCH 3/8] powerpc/pseries/eeh: Export eeh_unfreeze_pe() and eeh_ops Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.5.0_GA_3042 (ZimbraWebClient - GC137 (Linux)/8.5.0_GA_3042) Thread-Topic: powerpc/pseries/eeh: Export eeh_unfreeze_pe() and eeh_ops Thread-Index: bupdJGUzprnsSSzB+HYmaNkawJnfUc+y9UXi ----- Original Message ----- > From: "Timothy Pearson" > To: "Christoph Hellwig" > Cc: "linuxppc-dev" , "linux-kernel" , "linux-pci" > , "Madhavan Srinivasan" , "Michael Ellerman" , > "christophe leroy" , "Naveen N Rao" , "Bjorn Helgaas" > , "Shawn Anastasio" > Sent: Wednesday, June 18, 2025 11:10:02 AM > Subject: Re: [PATCH 3/8] powerpc/pseries/eeh: Export eeh_unfreeze_pe() and eeh_ops > ----- Original Message ----- >> From: "Christoph Hellwig" >> To: "Timothy Pearson" >> Cc: "linuxppc-dev" , "linux-kernel" >> , "linux-pci" >> , "Madhavan Srinivasan" , >> "Michael Ellerman" , >> "christophe leroy" , "Naveen N Rao" >> , "Bjorn Helgaas" >> , "Shawn Anastasio" >> Sent: Wednesday, June 18, 2025 12:38:56 AM >> Subject: Re: [PATCH 3/8] powerpc/pseries/eeh: Export eeh_unfreeze_pe() and >> eeh_ops > >> On Tue, Jun 17, 2025 at 11:22:39PM -0500, Timothy Pearson wrote: >>> /* Platform dependent EEH operations */ >>> struct eeh_ops *eeh_ops = NULL; >>> +EXPORT_SYMBOL(eeh_ops); >> >> Exporting ops vectors is generally a really bad idea. Please build a >> proper abstraction instead. >> >> And use EXPORT_SYMBOL_GPL for any kind of low-level API. > > Fair enough. I'll add a properly exported method for PE get_state() and update > the series in the next couple of days. Somehow I completely missed eeh_pe_get_state() the first time around. I don't need to change the API, v2 incoming now.