mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_proto: check for missing EC_CMD_HOST_EVENT_GET_WAKE_MASK
Date: Thu, 23 Jul 2020 10:04:16 +0200	[thread overview]
Message-ID: <59657973-cdef-eaf2-47f2-368205015750@collabora.com> (raw)
In-Reply-To: <CA+ASDXMk7Tg7Lwqt8Pv5BQT0J40dpJtqrL9TAn8y5Nj3TCkj6Q@mail.gmail.com>

Hi Brian,

On 22/7/20 22:50, Brian Norris wrote:
> On Wed, Jul 22, 2020 at 3:19 AM Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
>>
>> Hi Brian,
>>
>> Thank you for your patch, I'll take a look soon but I'd like to ask if you can
>> join the discussion with this patchset [1], specially this one [2]. We're trying
>> to match EC errors with standard linux kernel errors because we think can be
>> helpful.
>>
>> [1] https://lore.kernel.org/patchwork/cover/1276734/
>> [2] https://lore.kernel.org/patchwork/patch/1276738/
> 
> Hi Enric,
> 
> Thanks, I'll do that. I do wonder sometimes how non-maintainers should
> best support "community" around these things, for subsystems that
> don't have a dedicated mailing list and are therefore sent only to
> maintainers + LKML-fire-hose. I could probably subscribe to LKML and
> filter it, but something tells me my mailbox will still manage to
> explode somehow... Anyway, I digress.
> 

We talked sometimes on having a dedicated ML, but for one reason or the other,
and as we don't have a lot of volume, we didn't set up (could be an option).

Another thing that we can do (although this is specific for you and doesn't
solve the problem with people like you that are interested on this), is add you
as a reviewer in the MAINTAINERS file. The CrOS EC has a lot of subtleties, and
having more ChromeOS people involved in the reviewing upstream is more than welcome.

Regards,
Enric

> Other than perhaps taking a lesson not to propagate -ENOTSUPP, I don't
> think this series should block on that, as this is a bugfix IMO.
> 
> Regards,
> Brian
> 

  parent reply	other threads:[~2020-07-23  8:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22  1:57 [PATCH 1/2] platform/chrome: cros_ec_proto: ignore unnecessary wakeups on old ECs Brian Norris
2020-07-22  1:57 ` [PATCH 2/2] platform/chrome: cros_ec_proto: check for missing EC_CMD_HOST_EVENT_GET_WAKE_MASK Brian Norris
2020-07-22 10:19   ` Enric Balletbo i Serra
2020-07-22 20:50     ` Brian Norris
2020-07-22 21:13       ` Guenter Roeck
2020-07-23  0:43         ` Brian Norris
2020-07-23  0:50           ` Brian Norris
2020-07-23  0:54             ` Guenter Roeck
2020-07-23  8:08           ` Enric Balletbo i Serra
2020-07-23  8:04       ` Enric Balletbo i Serra [this message]
2020-07-24 19:39         ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59657973-cdef-eaf2-47f2-368205015750@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=bleung@chromium.org \
    --cc=briannorris@chromium.org \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®