From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B73DC433C1 for ; Tue, 23 Mar 2021 09:45:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C31B2619BD for ; Tue, 23 Mar 2021 09:45:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbhCWJpO (ORCPT ); Tue, 23 Mar 2021 05:45:14 -0400 Received: from foss.arm.com ([217.140.110.172]:42940 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbhCWJoo (ORCPT ); Tue, 23 Mar 2021 05:44:44 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 632F31042; Tue, 23 Mar 2021 02:44:44 -0700 (PDT) Received: from [10.57.55.187] (unknown [10.57.55.187]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DCB8E3F718; Tue, 23 Mar 2021 02:44:42 -0700 (PDT) Subject: Re: [PATCH v4 05/19] kvm: arm64: Disable guest access to trace filter controls To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, anshuman.khandual@arm.com, leo.yan@linaro.org, Will Deacon , Mark Rutland , Catalin Marinas , linux-arm-kernel@lists.infradead.org References: <20210225193543.2920532-1-suzuki.poulose@arm.com> <20210225193543.2920532-6-suzuki.poulose@arm.com> <8cb6eced29d9749d88af6f6d2f649019@kernel.org> From: Suzuki K Poulose Message-ID: <59682421-a985-ec71-3ade-09c17aa58b5a@arm.com> Date: Tue, 23 Mar 2021 09:44:41 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <8cb6eced29d9749d88af6f6d2f649019@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/03/2021 09:16, Marc Zyngier wrote: > Hi Suzuki, > > On 2021-03-22 22:24, Suzuki K Poulose wrote: >> Hi Marc, >> >> On 25/02/2021 19:35, Suzuki K Poulose wrote: >>> Disable guest access to the Trace Filter control registers. >>> We do not advertise the Trace filter feature to the guest >>> (ID_AA64DFR0_EL1: TRACE_FILT is cleared) already, but the guest >>> can still access the TRFCR_EL1 unless we trap it. >>> >>> This will also make sure that the guest cannot fiddle with >>> the filtering controls set by a nvhe host. >>> >>> Cc: Marc Zyngier >>> Cc: Will Deacon >>> Cc: Mark Rutland >>> Cc: Catalin Marinas >>> Signed-off-by: Suzuki K Poulose >> >> We have already have the v8.4 self hosted tracing support in 5.12-rcX. >> Do you think you can pick this up for this 5.12 ? > > Sure, no problem. Shall I pick patch #3 at the same time? Yes please. Thanks ! Suzuki