mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <zbr@ioremap.net>
To: David Fries <david@fries.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thorsten Bschorr <thorsten@bschorr.de>,
	Jonathan ALIBERT <jonathan.alibert@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] w1_therm reference count family data
Date: Wed, 13 May 2015 17:59:51 +0300	[thread overview]
Message-ID: <5969431431529191@web10h.yandex.ru> (raw)
In-Reply-To: <20150509005150.GL32351@spacedout.fries.net>

Hi

09.05.2015, 03:52, "David Fries" <David@Fries.net>:
> A temperature conversion can take 750 ms and when possible the
> w1_therm slave driver drops the bus_mutex to allow other bus
> operations, but that includes operations such as a periodic slave
> search, which can remove this slave when it is no longer detected.
> If that happens the sl->family_data will be freed and set to NULL
> causing w1_slave_show to crash when it wakes up.
>
> Signed-off-by: David Fries <David@Fries.net>
> Reported-By: Thorsten Bschorr <thorsten@bschorr.de>
> Tested-by: Thorsten Bschorr <thorsten@bschorr.de>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> ---
> This should be applied to the stable series as well.  In the name of
> full disclosure, this just narrows the race window, from crashing in
> normal operation on the reporters system to no longer crashing with
> multiple readers and another process hammering on inserting/removing
> the slave device.

Greg, please pull it upstream

      reply	other threads:[~2015-05-13 14:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09  0:51 David Fries
2015-05-13 14:59 ` Evgeniy Polyakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5969431431529191@web10h.yandex.ru \
    --to=zbr@ioremap.net \
    --cc=david@fries.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathan.alibert@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thorsten@bschorr.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®