From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751395AbdGRGGM (ORCPT ); Tue, 18 Jul 2017 02:06:12 -0400 Received: from regular1.263xmail.com ([211.150.99.138]:36989 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbdGRGGK (ORCPT ); Tue, 18 Jul 2017 02:06:10 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: gregkh@linuxfoundation.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <7845526dd6a095340a0814c6aa507cb9> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <596DA54D.8060001@rock-chips.com> Date: Tue, 18 Jul 2017 14:06:05 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Greg KH CC: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, peter@hurleysoftware.com, Jiri Slaby , Vineet Gupta , linux-serial@vger.kernel.org, linux-snps-arc@lists.infradead.org Subject: Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early write References: <1500352203-21513-1-git-send-email-jeffy.chen@rock-chips.com> <1500352203-21513-2-git-send-email-jeffy.chen@rock-chips.com> <20170718050838.GA7529@kroah.com> In-Reply-To: <20170718050838.GA7529@kroah.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On 07/18/2017 01:08 PM, Greg KH wrote: > On Tue, Jul 18, 2017 at 12:29:59PM +0800, Jeffy Chen wrote: >> The earlycon would be alive outside the init code in these cases: >> 1/ we have keep_bootcon in cmdline. >> 2/ we don't have a real console to switch to. >> >> So remove the __init marking to avoid invalid memory access. >> >> Signed-off-by: Jeffy Chen >> --- >> > > I can't apply "RFC" patches. If you have tested and found this series > to be correct, can you resend it without that on the patch? oh, sorry, i'll resend it :) but i'm still not sure how to fix other hang cases(mentioned in the cover-letter, earlycon's required clks/pm domain been disabled by ignore unused initcalls or serial console driver's runtime suspend). > > thanks, > > greg k-h > > >