From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751487AbdGRJhE (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Jul 2017 05:37:04 -0400
Received: from regular1.263xmail.com ([211.150.99.136]:49719 "EHLO
        regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751322AbdGRJhC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Jul 2017 05:37:02 -0400
X-263anti-spam: KSV:0;BIG:0;
X-MAIL-GRAY: 0
X-MAIL-DELIVERY: 1
X-KSVirus-check: 0
X-ADDR-CHECKED4: 1
X-ABS-CHECKED: 1
X-SKE-CHECKED: 1
X-ANTISPAM-LEVEL: 2
X-RL-SENDER: jeffy.chen@rock-chips.com
X-FST-TO: oneukum@suse.com
X-SENDER-IP: 103.29.142.67
X-LOGIN-NAME: jeffy.chen@rock-chips.com
X-UNIQUE-TAG: <aa98f48940ba947c8b82fa07fd319e3f>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Message-ID: <596DD6AE.2030704@rock-chips.com>
Date: Tue, 18 Jul 2017 17:36:46 +0800
From: jeffy <jeffy.chen@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0
MIME-Version: 1.0
To: Oliver Neukum <oneukum@suse.com>,
        Marcel Holtmann <marcel@holtmann.org>
CC: briannorris@chromium.org, dianders@chromium.org,
        Johan Hedberg <johan.hedberg@gmail.com>, xiyou.wangcong@gmail.com,
        "Gustavo F. Padovan" <gustavo@padovan.org>,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred
References: <1500343579-9831-1-git-send-email-jeffy.chen@rock-chips.com>   <6E21F79E-93AA-4461-BA6B-67715501714F@holtmann.org>  <1500363015.16072.5.camel@suse.com> <596DC200.1080006@rock-chips.com> <1500367310.502.0.camel@suse.com>
In-Reply-To: <1500367310.502.0.camel@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Oliver,

On 07/18/2017 04:41 PM, Oliver Neukum wrote:
> Am Dienstag, den 18.07.2017, 16:08 +0800 schrieb jeffy:
>>> I am afraid not. We cannot silently drop one part of a transmission.
>>> I am afraid that the correct algorithm, if we encounter an error at
>>> that stage, is to abort the operation and report an error.
>>>
>> so i should break the loop when error happens right?
>
> Yes
ok, i'll do that.
>
>>
>> and i uploaded 2 version of patches, which one do you prefer to go on?
>
> Where to?
https://patchwork.kernel.org/patch/9847037
and
https://patchwork.kernel.org/patch/9846617

>
> 	Regards
> 		Oliver
>
>
>
>