From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Aiqun Yu (Maria)" <quic_aiquny@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Tengfei Fan <quic_tengfan@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@quicinc.com
Subject: Re: [PATCH v3 1/1] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1
Date: Wed, 20 Dec 2023 12:20:01 +0100 [thread overview]
Message-ID: <596c4ed6-bf3d-4406-8b28-2b34548520d1@linaro.org> (raw)
In-Reply-To: <72305a35-02e6-4ff6-8251-01f986530c5d@quicinc.com>
On 20/12/2023 11:33, Aiqun Yu (Maria) wrote:
>>>>
>>>> Don't touch the bindings unless you understand what you are doing.
>>>> Your patch will be NAKed. There can be a DSI panel attached to the DSI
>>>> host, which means there is a need for #address-cells / #size-cells.
>>>>
>>> Could you please help to elaborate more on details? Like what's the
>>> right example here for the "qcom,mdss-dsi-ctrl" driver node needed to
>>> have "#address-cells"/"#size-cells".
>>
>> As I wrote, the attached DSI panels make use of #address-cells / #size-cells.
>>
>> Please take a look at the sdm845-mtp.dts, which provides a complex
>> enough example (a panel which is attached to both DSI0 and DSI1
>> hosts).
> I can see the panel example now.
> While panel@0 likely node is not at in the binding that I've checked.
"Likely not" is not the same as "cannot".
> There are quite a few of binding document about the same driver. I
You keep mixing drivers, bindings and devices which does not help this
discussion. I really do not understand above sentence.
> checked 5 of the bindings document and moste of them are alike, and
> don't have the panel example.:(
Example like the example DTS in the binding? What does it have to do
with anything here? What are we talking here about?
>>
>>> Thx to chime in that we have put a good amount of time here.
>>
>> Can't quite catch you here.
>>
>>>> Please stop wasting the time on dtc warning. The bindings (and the
>>>> file) are correct.
>>> I don't agree here.
>>> Either it is a wrong usage of "#address-cells"/"#size-cells", or dtc
>>> warning should be fixed with this usage take into account.
>>> "dtb check" will be a good guideline for developers to follow, I don't
>>> think it is wasting time here.
>>
>> It is a guideline, but not a rule. No warnings by default is more of
>> the rule. W=1 enables warnings that developers have to classify and
>> cope with.
>>
>> E.g. I don't think dtc correctly handles the case when there are both
>> with-address and no-address nodes (e.g. 'panel@0' and 'ports'). Note,
>> I might be mistaken there.
> Now I understand the issue, here is some thinking from my end, and
> welcome others to chime in with more ideas:
> 1. Only put "#address-cells" "#size-cells" right before node of panel@0.
> 2. Align current binding document with "panel@0" examples.
Examples? Again, about what examples are you talking? Mixing terminology
does not help this discussion, so let's be specific:
Touching examples just because you want, without valid reason: no
> 3. Too many bindings files for driver "qcom,mdss-dsi-ctrl", shall we
> align them into 1 binding files.
You are joking right? First of all, there is no driver
"qcom,mdss-dsi-ctrl". Don't mix the terms, because it does not help the
discussion. Second, please read previous discussions related to these
bindings.
> 4. enhance the dtc warning check if we still want to have
> "#address-cells" "#size-cells" even if there is no "panel@0" attached.
>
> @krzy here I try to answer your comments here as well.
> I am disagree on leave the warning as it is. And want to do something to
> improve this. Ideas above.
> Let me know if any comments is not right addressed from your comments.
You want to do something without understanding the problem which results
in random band-aids over some warning. Instead, please dig deeper to
understand the problem and then propose solution.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-20 11:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 0:31 [PATCH v3 0/1] arm64: dts: qcom: sm8550: remove Tengfei Fan
2023-12-19 0:31 ` [PATCH v3 1/1] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1 Tengfei Fan
2023-12-19 7:17 ` Krzysztof Kozlowski
2023-12-19 7:42 ` Tengfei Fan
2023-12-19 9:36 ` Aiqun Yu (Maria)
2023-12-19 9:41 ` Krzysztof Kozlowski
2023-12-19 10:09 ` Aiqun Yu (Maria)
2023-12-19 10:13 ` Krzysztof Kozlowski
2023-12-19 10:21 ` Dmitry Baryshkov
2023-12-20 0:53 ` Aiqun Yu (Maria)
2023-12-20 7:06 ` Dmitry Baryshkov
2023-12-20 10:33 ` Aiqun Yu (Maria)
2023-12-20 11:10 ` Dmitry Baryshkov
2023-12-21 1:57 ` Aiqun Yu (Maria)
2023-12-21 6:59 ` Dmitry Baryshkov
2023-12-21 8:49 ` Aiqun Yu (Maria)
2023-12-21 8:57 ` Krzysztof Kozlowski
2023-12-22 9:10 ` Aiqun Yu (Maria)
2023-12-22 9:30 ` Krzysztof Kozlowski
2023-12-21 9:56 ` Dmitry Baryshkov
2023-12-20 11:20 ` Krzysztof Kozlowski [this message]
2023-12-20 7:10 ` Krzysztof Kozlowski
2023-12-19 19:33 ` (subset) [PATCH v3 0/1] arm64: dts: qcom: sm8550: remove Bjorn Andersson
2023-12-20 5:34 ` Aiqun Yu (Maria)
2023-12-20 7:11 ` Krzysztof Kozlowski
2023-12-20 7:23 ` Dmitry Baryshkov
2023-12-20 12:28 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=596c4ed6-bf3d-4406-8b28-2b34548520d1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_tengfan@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®